March 2022 - Koha-bugs - lists.koha-community.org

[Bug 9097] 'Welcome mail' for new library users
by bugzilla-daemon＠bugs.koha-community.org 06 Mar '22

06 Mar '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9097 --- Comment #14 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- (In reply to Martin Renvoize from comment #13) > Does that cover everything? Almost! I think the original idea here was to have a button for manual sending/resending of a notice. So maybe we could add that to the 'More' menu if possible? It could also be useful if patrons don't give an email address at first, but add one later. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 29432] New: Item type deletion should test frameworks
by bugzilla-daemon＠bugs.koha-community.org 04 Mar '22

04 Mar '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29432 Bug ID: 29432 Summary: Item type deletion should test frameworks Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: MARC Bibliographic data support Assignee: koha-bugs(a)lists.koha-community.org Reporter: fridolin.somers(a)biblibre.com QA Contact: testopia(a)bugs.koha-community.org Actually the test to allow deleting an item type is : sub can_be_deleted { my ($self) = @_; my $nb_items = Koha::Items->search( { itype => $self->itemtype } )->count; my $nb_biblioitems = Koha::Biblioitems->search( { itemtype => $self->itemtype } )->count; return $nb_items + $nb_biblioitems == 0 ? 1 : 0; } But using item types on biblioitems.itemtype is not mandatory (for items.itype I do not know), so we should test if this DB column is configured in frameworks to use item types. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 3

[Bug 30229] New: Last barcode added duplicates in label batch if page refreshes
by bugzilla-daemon＠bugs.koha-community.org 04 Mar '22

04 Mar '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30229 Bug ID: 30229 Summary: Last barcode added duplicates in label batch if page refreshes Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Label/patron card printing Assignee: cnighswonger(a)foundations.edu Reporter: sbrown(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org Note: I believe this is more an issue of how browsers work than a bug, and the duplicate(s) can be deleted with a click - but I'm documenting this here in case anyone else searches for it. When creating a label batch, if you refresh the page, the last barcode added will be duplicated. (Tested in Firefox on 21.05.09 and 20.05.14.) Steps to replicate: -Start a new label batch -Add barcode 111 -Add barcode 222 -In a separate tab, edit the call number for barcode 111 -Refresh your label batch page to see edit - barcode 222 is now repeated at end of batch The updated call number *will* apply to the batch/print correctly without refreshing the label batch page, but libraries may want to see the update before proceeding with the export. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15594] Sequence of MARC 260 subfields different on XSLT result list and detail page
by bugzilla-daemon＠bugs.koha-community.org 04 Mar '22

04 Mar '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15594 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #15 from Nick Clemens <nick(a)bywatersolutions.com> --- Small patch, small cleanup, I think this can go ahead PQA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15594] Sequence of MARC 260 subfields different on XSLT result list and detail page
by bugzilla-daemon＠bugs.koha-community.org 04 Mar '22

04 Mar '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15594 --- Comment #14 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 131385 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131385&action=e… Bug 15594: (QA follow-up) Move span to publisher name, fix whitespace, only add spaces once per loop This patch updates the whitespace for readbility Moves the Ogranization span to the subfield b, publisher name only Moves check for last/whitespace to the loop Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15594] Sequence of MARC 260 subfields different on XSLT result list and detail page
by bugzilla-daemon＠bugs.koha-community.org 04 Mar '22

04 Mar '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15594 --- Comment #13 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 131384 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131384&action=e… Bug 15594: Class in now unchanged after the patch I'm not sure if this is the actual issue, but I found that the patch puts the span with the class "publisher_name" inside a new span with typeOf="Organization". In this patch, I removed that new span, to keep it coherent with the previous code. Also, the MARC 260 subfields are displayed correctly ! Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15594] Sequence of MARC 260 subfields different on XSLT result list and detail page
by bugzilla-daemon＠bugs.koha-community.org 04 Mar '22

04 Mar '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15594 --- Comment #12 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 131383 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131383&action=e… Bug 15594: preserve sequence of 260 subfields in (staff) detail page When ordered $a$b$a$b$c in the MARC object, 260 subfields are displayed $a$a$b$b$c. This goes against the standard. This patch preserves the order. 0) create a notice with $a$b$a subfields. In that (mixed) order. 1) Go to staff detail page and see the fields displayed as "aab" 2) apply the patch 3) validate the aba display. Signed-off-by: David Nind <david(a)davidnind.com> Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15594] Sequence of MARC 260 subfields different on XSLT result list and detail page
by bugzilla-daemon＠bugs.koha-community.org 04 Mar '22

04 Mar '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15594 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130194|0 |1 is obsolete| | Attachment #130195|0 |1 is obsolete| | Attachment #131363|0 |1 is obsolete| | --- Comment #11 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 131382 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131382&action=e… Bug 15594: preserve sequence of 260 subfields in detail page When ordered $a$b$a$b$c in the MARC object, 260 subfields are displayed $a$a$b$b$c. This goes against the standard. This patch preserves the order. 0) create a notice with $a$b$a subfields. In that (mixed) order. 1) Go to detail page and see the fields displayed as "aab" 2) apply the patch 3) validate the aba display. Signed-off-by: David Nind <david(a)davidnind.com> Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15594] Sequence of MARC 260 subfields different on XSLT result list and detail page
by bugzilla-daemon＠bugs.koha-community.org 04 Mar '22

04 Mar '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15594 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 30125] New: Add full-stack tests for API pagination
by bugzilla-daemon＠bugs.koha-community.org 04 Mar '22

04 Mar '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30125 Bug ID: 30125 Summary: Add full-stack tests for API pagination Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: chris(a)bigballofwax.co.nz Reporter: tomascohen(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org Currently we have some tests on the helper, and also a few (incomplete) tests in api/v1/checkouts.t I propose we add a new file with full tests coverage for pagination, using the always-picked-as-sample GET /cities route. -- You are receiving this mail because: You are watching all bug changes.

1 14