June 2022 - Koha-bugs - lists.koha-community.org

[Bug 28859] New: Table Settings should control Checked out by field in Checkout history
by bugzilla-daemon＠bugs.koha-community.org 11 Nov '22

11 Nov '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28859 Bug ID: 28859 Summary: Table Settings should control Checked out by field in Checkout history Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs(a)lists.koha-community.org Reporter: sally.healey(a)cheshiresharedservices.gov.uk QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com Koha Administration > Table Settings controls all whether fields are visible/can be toggled by users. 'Checked out by' is solely controlled by a system preference (RecordStaffUserOnCheckout) - and is not an option in the Table Settings controls. To replicate: - Set system preference: RecordStaffUserOnCheckout to 'record' - Check an item out to a patron - Go to the item's Checkout history - cgi-bin/koha/catalogue/issuehistory.pl - Note that 'Checked out by' column is visible - Go to Koha > Administration > Table Settings - Choose Catalog - Choose Page: detail - Choose Table id: checkoutshistory-table - Note that 'Checked out by' is not an option This also has the effect of targeting the wrong field via Table Settings. To replicate: - Set system preference: RecordStaffUserOnCheckout to 'record' - Check an item out to a patron - Go to the item's Checkout history - cgi-bin/koha/catalogue/issuehistory.pl - Note that 'Checked out by' column is visible - Go to Koha > Administration > Table Settings - Choose Catalog - Choose Page: detail - Choose Table id: checkoutshistory-table - Check some fields to be 'Is hidden by default' i.e. 'checked_out_from' and 'renewed' - Reload the item's Checkout history - Note that the columns 'Checked out from' and 'Checked out by' are hidden, but 'Renewed' is not This is because 'Checked out by' is sitting in the original 'Renewed' position in the table. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 26

[Bug 21635] New: Incorrect GROUP BY clause in batchMod.pl
by bugzilla-daemon＠bugs.koha-community.org 11 Nov '22

11 Nov '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21635 Bug ID: 21635 Summary: Incorrect GROUP BY clause in batchMod.pl Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: major Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org batchMod.pl: DBD::mysql::st execute failed: 'koha_kohadev.authorised_values.authorised_val ue' isn't in GROUP BY [for Statement "SELECT authorised_value, lib FROM authorised_values LEFT JOIN authorised_values_branches ON ( id = av_id ) WHERE category = ? AND ( branchcode = ? OR branchcode IS NULL ) GROUP BY lib ORDER BY lib, lib_opac" with ParamValues: 0='WITHDRAWN', 1="CPL"] at /home/vagrant/kohaclone/tools/batchMod.pl line 396. We must use Koha::AuthorisedValues->search instead of a raw SQL query. -- You are receiving this mail because: You are watching all bug changes.

1 13

[Bug 21529] New: Print notices no longer outputs html notices
by bugzilla-daemon＠bugs.koha-community.org 11 Nov '22

11 Nov '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21529 Bug ID: 21529 Summary: Print notices no longer outputs html notices Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Notices Assignee: koha-bugs(a)lists.koha-community.org Reporter: stefan.berndtsson(a)ub.gu.se QA Contact: testopia(a)bugs.koha-community.org When a print notice letter (for example HOLD) is marked as "HTML message" it is expected for gather_print_notices.pl (with --html) to accept the message content and not escape the html. Since Bug 13618 this is no longer true. batch/print-notices.tt explicitly adds "| html" before inserting the content regardless of the "HTML message" flag. circ/printslip.tt on the other hand, checks the flag and escapes only if plain output is used. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 24

[Bug 21270] New: Not finding what you're looking for displaying uselessly
by bugzilla-daemon＠bugs.koha-community.org 11 Nov '22

11 Nov '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21270 Bug ID: 21270 Summary: Not finding what you're looking for displaying uselessly Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: ILL Assignee: koha-bugs(a)lists.koha-community.org Reporter: philippe.blouin(a)inlibro.com When doing OPAC search, at the bottom you have an offer presented with "Not finding what you're looking for" to introduce Suggestions or ILL if enabled. Bug 7317 modified the if-else and now if you enable ILLModule but not AnonSuggestions and are not logged, you have this little string sitting there, offering nothing to the user. Just taunting them... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 41

[Bug 20886] New: Koha::Object::TO_JSON indiscriminately casting to integer
by bugzilla-daemon＠bugs.koha-community.org 11 Nov '22

11 Nov '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20886 Bug ID: 20886 Summary: Koha::Object::TO_JSON indiscriminately casting to integer Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: andrew.isherwood(a)ptfs-europe.com QA Contact: testopia(a)bugs.koha-community.org As noted in bug 20797 there appears to be a bug in Koha::Object::TO_JSON. Specifically: elsif ( _numeric_column_type( $columns_info->{$col}->{data_type} ) ) { # TODO: Remove once the solution for # https://rt.cpan.org/Ticket/Display.html?id=119904 # is ported to whatever distro we support by that time $unblessed->{$col} += 0; } Here we are explicitly casting to an integer to workaround an upstream bug. This works fine unless the data in question comes from a numeric type column but is NULL, in which case it is cast to 0. I suspect the desired behaviour here is for it to remain unaltered unless the value is also numeric. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 20

[Bug 17050] New: Accessing the REST API through Plack kicks the session out
by bugzilla-daemon＠bugs.koha-community.org 11 Nov '22

11 Nov '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17050 Bug ID: 17050 Summary: Accessing the REST API through Plack kicks the session out Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt(a)gmail.com Reporter: tomascohen(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org While working on bug 17030 for integrating the REST API on the packages ot make it finally available, I found that the session is lost when Plack is used to access it. To reproduce: - Follow the steps for the Plack patch in bug 17030 => FAIL: Notice no matter what permissions your user has you get: { "error": "You don't have the required permission" } - On a separate tab, notice you've been kicked out from Koha. This doesn't happen with Plack disabled. -- You are receiving this mail because: You are watching all bug changes.

1 32

[Bug 24043] New: ILL module can't show requests from more than one backend
by bugzilla-daemon＠bugs.koha-community.org 11 Nov '22

11 Nov '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24043 Bug ID: 24043 Summary: ILL module can't show requests from more than one backend Change sponsored?: --- Product: Koha Version: 18.11 Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: ILL Assignee: koha-bugs(a)lists.koha-community.org Reporter: magnus(a)libriotech.no A customer has 6 requests created with the FreeForm backend and 10 with the Libris backend. The table of requests tries to display a mix of these, but shows this error in the dev tools console: Uncaught TypeError: Cannot read property 'name' of undefined at createStatus (ill-requests.pl:714) at jquery.dataTables.min_18.1105000.js:18 at Object.b.fnGetData (jquery.dataTables.min_18.1105000.js:12) at B (jquery.dataTables.min_18.1105000.js:16) at Ia (jquery.dataTables.min_18.1105000.js:14) at mb (jquery.dataTables.min_18.1105000.js:66) at T (jquery.dataTables.min_18.1105000.js:30) at ia (jquery.dataTables.min_18.1105000.js:48) at HTMLTableElement.<anonymous> (jquery.dataTables.min_18.1105000.js:95) at Function.each (jquery-2.2.3.min_18.1105000.js:2) The code around ill-requests.pl line 714 looks like this: var createStatus = function(data, type, row, meta) { var origData = meta.settings.oInit.originalData; if (origData.length > 0) { var status_name = meta.settings.oInit.originalData[0].capabilities[ row.status ].name; switch( status_name ) { case "New request": return _("Ny förfrågan"); case "Requested": return _("Begärd"); Now if I manipulate Koha/REST/V1/Illrequests.pm line 56 to look like this: # Get all requests my @requests = Koha::Illrequests->as_list; # @requests = @requests[6..9]; I can choose which requests to display in the table, by changing the numbers in the brackets. Displaying only the FreeForm requests works fine, and displaying only the Libris requests works fine. So it looks like the problem is to display a mix. I am not sure I completely understand the JS here, but I have a hunch that meta.settings.oInit.originalData[0].capabilities[ means we are trying to use the metadata and the capabilities of the first ([0]) request returned to display *all* the requests. And the backends have different statuses, so trying to look up a Libris status in the set of FreeForm statuses fails? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 35

[Bug 21460] New: Filtering ILL requests on borrowernumber does not work
by bugzilla-daemon＠bugs.koha-community.org 11 Nov '22

11 Nov '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21460 Bug ID: 21460 Summary: Filtering ILL requests on borrowernumber does not work Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: ILL Assignee: koha-bugs(a)lists.koha-community.org Reporter: magnus(a)libriotech.no To reproduce, start on detail view for a patron, e.g. /cgi-bin/koha/members/moremember.pl?borrowernumber=5 Click on the "Interlibrary loans" tab on the left of the screen. This takes you to /cgi-bin/koha/ill/ill-requests.pl?borrowernumber=5, which displays all ILL requests, not just the ones for borrowernumber 5. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 53

[Bug 20797] New: If an Ill request has an associated bib record, the detail view should contain a link to the record
by bugzilla-daemon＠bugs.koha-community.org 11 Nov '22

11 Nov '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20797 Bug ID: 20797 Summary: If an Ill request has an associated bib record, the detail view should contain a link to the record Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: ILL Assignee: koha-bugs(a)lists.koha-community.org Reporter: martin.renvoize(a)ptfs-europe.com Currently, the ILL request detail view shows a plain biblionumber.. this should be a link through to the bib record view. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 75

[Bug 20639] New: Allow setting a default/single backend for OPAC driven requests
by bugzilla-daemon＠bugs.koha-community.org 11 Nov '22

11 Nov '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20639 Bug ID: 20639 Summary: Allow setting a default/single backend for OPAC driven requests Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: ILL Assignee: koha-bugs(a)lists.koha-community.org Reporter: martin.renvoize(a)ptfs-europe.com If you have more than one ILL backend installed, and OPAC ILL Requests enabled the OPAC users are currently faced with a dropdown list of backends to start a request on. This is often meaningless to the end user and as such a default should be configurable at the least and preferably the ability to set a fast path to only allow a prefered backend to be used from the OPAC. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 43