June 2022 - Koha-bugs - lists.koha-community.org

[Bug 24369] New: Add ability to set CORS header in Koha
by bugzilla-daemon＠bugs.koha-community.org 11 Nov '22

11 Nov '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24369 Bug ID: 24369 Summary: Add ability to set CORS header in Koha Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: kyle(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org The reports API can produce JSON that would be useful on other library related websites, but the use of it appears to be blocked by default via CORS. It would be nice if there were a Koha syspref to set the CORS header rather than mucking about with htaccess files and whatnot. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 30

[Bug 24321] New: Make objects.search use mappings from Koha::Object(s)
by bugzilla-daemon＠bugs.koha-community.org 11 Nov '22

11 Nov '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24321 Bug ID: 24321 Summary: Make objects.search use mappings from Koha::Object(s) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: REST API Assignee: koha-bugs(a)lists.koha-community.org Reporter: tomascohen(a)gmail.com Now Koha::Object(s) implement 'to_api' and 'attributes_from_api' there's no need to implement such mappings on the controllers for simple Koha::Object<->API conversions. The to_api mappings have already been moved to Koha::Object level. It is time for the to_model ones. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 105

[Bug 22280] New: The ILL module assumes every status needs a next/previous status
by bugzilla-daemon＠bugs.koha-community.org 11 Nov '22

11 Nov '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22280 Bug ID: 22280 Summary: The ILL module assumes every status needs a next/previous status Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: ILL Assignee: koha-bugs(a)lists.koha-community.org Reporter: magnus(a)libriotech.no Target Milestone: --- Swedish ILL is very centrally driven, so some status changes are only done by updates from the API. That means that these statuses do not need a prev_actions or a next_actions: IN_NEG => { prev_actions => [ ], id => 'IN_NEG', name => 'Inlån Negativt svar', ui_method_name => 'Negativt svar', method => 'requestitem', next_actions => [ ], ui_method_icon => 'fa-send-o' }, But leaving these blank as above leads to errors, around line 386 of /usr/share/koha/lib/Koha/Illrequest.pm: # Update all core methods' next_actions. foreach my $prev_action ( @{$backend_status->{prev_actions}} ) { if ( grep $prev_action, @core_status_ids ) { my @next_actions = @{$status_graph->{$prev_action}->{next_actions}}; ### ERROR HERE push @next_actions, $backend_status_key; $status_graph->{$prev_action}->{next_actions} = \@next_actions; } } # Update all core methods' prev_actions foreach my $next_action ( @{$backend_status->{next_actions}} ) { if ( grep $next_action, @core_status_ids ) { my @prev_actions = @{$status_graph->{$next_action}->{prev_actions}}; ### AND HERE push @prev_actions, $backend_status_key; $status_graph->{$next_action}->{prev_actions} = \@prev_actions; } } The error is something like "Can't treat an undefined value as an array". Changing those lines to check if an array is defined makes the error go away, and I have not seen any bad side effects: @{$status_graph->{$prev_action}->{next_actions}} if $status_graph->{$prev_action}->{next_actions}; ### NO MORE ERROR HERE @{$status_graph->{$next_action}->{prev_actions}} if $status_graph->{$next_action}->{prev_actions}; ### OR HERE Does that change make sense to others, or am I missing some other way to work around this? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 27

[Bug 22196] New: Clean up Mana KB administration template
by bugzilla-daemon＠bugs.koha-community.org 11 Nov '22

11 Nov '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22196 Bug ID: 22196 Summary: Clean up Mana KB administration template Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org Depends on: 17047 Target Milestone: --- There are some markup and content corrections to be made to the Mana KB administration template. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 [Bug 17047] Mana Knowledge Base : share data -- You are receiving this mail because: You are watching all bug changes.

1 25

[Bug 20260] New: Use CodeMirror for the SQL reports editor
by bugzilla-daemon＠bugs.koha-community.org 11 Nov '22

11 Nov '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20260 Bug ID: 20260 Summary: Use CodeMirror for the SQL reports editor Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Reports Assignee: koha-bugs(a)lists.koha-community.org Reporter: magnus(a)libriotech.no QA Contact: testopia(a)bugs.koha-community.org We are already using CodeMirror (http://codemirror.net) somewhere. I would guess in Rancor, the advanced cataloguing editor. How about also using it for syntax highlighting when editing the SQL of an SQL report? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 28

[Bug 21725] New: Incorrect HAVING in group by in Acquisitions.pm
by bugzilla-daemon＠bugs.koha-community.org 11 Nov '22

11 Nov '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21725 Bug ID: 21725 Summary: Incorrect HAVING in group by in Acquisitions.pm Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs(a)lists.koha-community.org Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org prove -v t/db_dependent/Acquisition/GetBasketsInfosByBookseller.t DBD::mysql::st execute failed: Non-grouping field 'expected_items' is used in HAVING clause [for Statement " SELECT aqbasket.basketno, aqbasket.basketname, aqbasket.note, aqbasket.booksellernote, aqbasket.contractnumber, aqbasket.creationdate, aqbasket.closedate, aqbasket.booksellerid, aqbasket.authorisedby, aqbasket.booksellerinvoicenumber, aqbasket.basketgroupid, aqbasket.deliveryplace, aqbasket.billingplace, aqbasket.branch, aqbasket.is_standing, aqbasket.create_items, SUM(aqorders.quantity) AS total_items, SUM( IF ( aqorders.orderstatus = 'cancelled', aqorders.quantity, 0 ) ) AS total_items_cancelled, COUNT(DISTINCT aqorders.biblionumber) AS total_biblios, SUM( IF(aqorders.datereceived IS NULL AND (aqorders.datecancellationprinted IS NULL OR aqorders.datecancellationprinted='0000-00-00') , aqorders.quantity , 0) ) AS expected_items FROM aqbasket LEFT JOIN aqorders ON aqorders.basketno = aqbasket.basketno WHERE booksellerid = ? GROUP BY aqbasket.basketno, aqbasket.basketname, aqbasket.note, aqbasket.booksellernote, aqbasket.contractnumber, aqbasket.creationdate, aqbasket.closedate, aqbasket.booksellerid, aqbasket.authorisedby, aqbasket.booksellerinvoicenumber, aqbasket.basketgroupid, aqbasket.deliveryplace, aqbasket.billingplace, aqbasket.branch, aqbasket.is_standing, aqbasket.create_items HAVING (closedate IS NULL OR (expected_items > 0))" with ParamValues: 0='359'] at /home/vagrant/kohaclone/C4/Acquisition.pm line 719. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 16

[Bug 27927] New: longoverdue cronjob renews items before marking lost when both RenewAccruingItemWhenPaid and WhenLostForgiveFine are enabled
by bugzilla-daemon＠bugs.koha-community.org 11 Nov '22

11 Nov '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27927 Bug ID: 27927 Summary: longoverdue cronjob renews items before marking lost when both RenewAccruingItemWhenPaid and WhenLostForgiveFine are enabled Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Fines and fees Assignee: koha-bugs(a)lists.koha-community.org Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org longoverdue.pl calls 'LostItem' C4::Circulation::LostItem calls _FixOverduesOnReturn C4::Circulation::_FixOverduesOnReturn create a Koha::Account::Line for the amount of the accruing fine and calls apply passing the existing fine Koha::Account::Line calls renew_item when the fee is paid The item is then renewed, a notice (potentially) sent, and then the item marked lost and charged The sending of a renewal notice is quite confusing to patrons -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 34

[Bug 23171] New: Improve plugin performance
by bugzilla-daemon＠bugs.koha-community.org 11 Nov '22

11 Nov '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23171 Bug ID: 23171 Summary: Improve plugin performance Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: martin.renvoize(a)ptfs-europe.com QA Contact: testopia(a)bugs.koha-community.org CC: agustinmoyano(a)theke.io, andrew.isherwood(a)ptfs-europe.com, arthur.suzuki(a)biblibre.com, black23(a)gmail.com, dcook(a)prosentient.com.au, fridolin.somers(a)biblibre.com, jonathan.druart(a)bugs.koha-community.org, katrin.fischer(a)bsz-bw.de, kyle(a)bywatersolutions.com, martin.renvoize(a)ptfs-europe.com, mirko(a)abunchofthings.net, mtj(a)kohaaloha.com, mtompset(a)hotmail.com, nick(a)bywatersolutions.com, rbit(a)rbit.cz, tomascohen(a)gmail.com, wizzyrea(a)gmail.com Depends on: 21073, 22053 Blocks: 22832, 22834, 23168 Target Milestone: --- Bug #21073 introduced the plugin_methods table, but the methods being added include all inherited and imported methods alongside those implemented by the plugin in question... we should limit to those implemented directly by the plugin. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21073 [Bug 21073] Improve plugin performance https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22053 [Bug 22053] Ability to disable some plugins https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22832 [Bug 22832] Require plugins to specify the methods they implement https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22834 [Bug 22834] Add a method for plugins to return the absolute path for bundled files https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23168 [Bug 23168] Database Updates broken due to conflicts in bug 21073 and bug 22053 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 13

[Bug 20536] New: ILL: authnotrequired not explicitly unset
by bugzilla-daemon＠bugs.koha-community.org 11 Nov '22

11 Nov '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20536 Bug ID: 20536 Summary: ILL: authnotrequired not explicitly unset Change sponsored?: --- Product: Koha Version: master Hardware: All URL: http://wiki.koha-community.org/wiki/ILL_Module OS: All Status: NEW Severity: new feature Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: martin.renvoize(a)ptfs-europe.com QA Contact: testopia(a)bugs.koha-community.org CC: alex.sassmannshausen(a)gmail.com, andrew.isherwood(a)ptfs-europe.com, benjamin.rokseth(a)deichman.no, black23(a)gmail.com, bob(a)calyx.net.au, bouzid.fergani(a)inlibro.com, caroline.cyr-la-rose(a)inlibro.com, dch(a)interleaf.ie, eric.begin(a)inLibro.com, francois.charbonnier(a)inlibro.com, frank.hansen(a)ub.lu.se, gmcharlt(a)gmail.com, hagud(a)orex.es, janet.mcgowan(a)ptfs-europe.com, jonathan.druart(a)bugs.koha-community.org, jonathan.field(a)ptfs-europe.com, josef.moravec(a)gmail.com, katrin.fischer(a)bsz-bw.de, kyle.m.hall(a)gmail.com, kyle(a)bywatersolutions.com, lisetteslatah(a)gmail.com, magnus(a)libriotech.no, manueltamayao(a)gmail.com, martin.renvoize(a)ptfs-europe.com, mirko(a)abunchofthings.net, mtompset(a)hotmail.com, nick(a)bywatersolutions.com, philippe.blouin(a)inlibro.com, pongtawat(a)punsarn.asia, sally.healey(a)cheshiresharedservices.gov.uk, sarah(a)secadvertising.com, severine.queune(a)bulac.fr, tomascohen(a)gmail.com, veron(a)veron.ch Depends on: 7317, 19588 Blocks: 18203, 18588, 18589, 18590, 18591, 18592, 18837, 19587, 19605, 19773, 19810, 19822, 20041, 20284, 20515, 20001 In the ILL intranet controller, the authnotrequired flag is not explicitly unset in get_template_and_user and as such if a user attempts to navigate directly to any of the ILL forms they are faced with an error rather than the standard login redirect. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18203 [Bug 18203] Add per borrower category restrictions on ILL placement. https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18588 [Bug 18588] Integrate ILL generic_emails in notices system. https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589 [Bug 18589] Show ILLs as part of patron profile https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18590 [Bug 18590] Make it possible to search among ILL requests https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18591 [Bug 18591] Allow an arbitrary number of comments on ILLs https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18592 [Bug 18592] Link from bib detail view to ILL module https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18837 [Bug 18837] Add an unmediated Interlibrary Loans workflow https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19587 [Bug 19587] "Place request with partners" button must be hidden if no partners defined https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19588 [Bug 19588] There is no ILL requests history https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19605 [Bug 19605] ILL backends should be pluggable through regular Koha plugins https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19773 [Bug 19773] Illrequests.t raises a warning https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19810 [Bug 19810] ILL: 404 error when activating ILL on a package installation https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19822 [Bug 19822] Add system preferences for ILL Module https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20001 [Bug 20001] ILL: Adding a 'new request' from OPAC is not possible https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20041 [Bug 20041] ILL module missing from more menu in staff when activated https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20284 [Bug 20284] ILL: Adding a 'new request' from OPAC fails with template error if text exists in ILLModuleCopyrightClearance https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20515 [Bug 20515] "ILL Request" menu options displayed when user has no ILL permissions -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 24

[Bug 21585] New: Missing firstname shows as "null" in table of ILL requests
by bugzilla-daemon＠bugs.koha-community.org 11 Nov '22

11 Nov '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21585 Bug ID: 21585 Summary: Missing firstname shows as "null" in table of ILL requests Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: ILL Assignee: koha-bugs(a)lists.koha-community.org Reporter: magnus(a)libriotech.no I have some libraries that are entered into Koha as borrowers, using the surname field for the name of the library and not using the firstname field. When these libraries are listed in the Patron column of the ILL requests table, the missing firstname is shown as "null", so the name is displayed as "null Some Library". I think the problem is somewhere in the conversion from DB "NULL" to JSON. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 19