June 2022 - Koha-bugs - lists.koha-community.org

[Bug 15050] Nonpublic note searchable from OPAC
by bugzilla-daemon＠bugs.koha-community.org 09 Jun '22

09 Jun '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15050 --- Comment #22 from Elaine Bradtke <eb(a)efdss.org> --- I know this is specifically about item records, but there are non-public fields in the biblio records too. These are used by special libraries and archives who handle rare and otherwise unusual material. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10950] Add preferred pronoun field to patron record
by bugzilla-daemon＠bugs.koha-community.org 09 Jun '22

09 Jun '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10950 Lucas Gass <lucas(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs(a)lists.koha-commun |lucas(a)bywatersolutions.com |ity.org | Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0

[Bug 10950] Add preferred pronoun field to patron record
by bugzilla-daemon＠bugs.koha-community.org 09 Jun '22

09 Jun '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10950 --- Comment #19 from Lucas Gass <lucas(a)bywatersolutions.com> --- Created attachment 135909 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135909&action=e… Bug 10950: Display pronouns field -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0

[Bug 10950] Add preferred pronoun field to patron record
by bugzilla-daemon＠bugs.koha-community.org 09 Jun '22

09 Jun '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10950 --- Comment #18 from Lucas Gass <lucas(a)bywatersolutions.com> --- Created attachment 135908 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135908&action=e… Bug 10950: Add intranet/OPAC form fields -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0

[Bug 11889] Option to keep public or shared lists when deleting patron
by bugzilla-daemon＠bugs.koha-community.org 09 Jun '22

09 Jun '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11889 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #99 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- I'm in agreement with Marcel here.. lets be pragmatic and get this moving. Whilst there's lots of patches here, the final diff is actually small and well formed.. lots of good golfing. I think 'virtualshelves' is the wrong naming for the Koha:: namespace really.. but that's not new here and I think should be handled in it's own bug.. 'Koha::Biblio::Lists' or 'Koha::Lists::Biblios' perhaps. After all that, the QA scripts is passing, tests are happy and I think this is a solid improvement. Passing QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11889] Option to keep public or shared lists when deleting patron
by bugzilla-daemon＠bugs.koha-community.org 09 Jun '22

09 Jun '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11889 --- Comment #98 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 135901 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135901&action=e… Bug 11889: (QA follow-up) Spelling Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11889] Option to keep public or shared lists when deleting patron
by bugzilla-daemon＠bugs.koha-community.org 09 Jun '22

09 Jun '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11889 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135876|0 |1 is obsolete| | --- Comment #97 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 135900 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135900&action=e… Bug 11889: (follow-up) We did not need get_shared_shelves after all Test plan: Run t/db_dependent/Virtualshelves.t Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11889] Option to keep public or shared lists when deleting patron
by bugzilla-daemon＠bugs.koha-community.org 09 Jun '22

09 Jun '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11889 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135875|0 |1 is obsolete| | --- Comment #96 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 135899 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135899&action=e… Bug 11889: (follow-up) Get rid of FIXME in Koha::Patron Instead of get_lists, I added ->virtualshelves. I removed the addition of the suffix to the shelf name here; if we really want that (doubts), we should do it pref based. Removing a staff member with public lists would result in weird names with shelf numbers on the OPAC. (Should be very easy to restore.) Used this opportunity to refactor the patron->delete subtest a bit: switching to build_object, removing the 'retrieved patrons', differentiating between staff patron and patron for sharing, adding a few tests. Test plan: Enable transfer ownership. Delete a patron with lists in interface. Check what happened. Run t/db_dependent/Koha/Patrons.t. Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11889] Option to keep public or shared lists when deleting patron
by bugzilla-daemon＠bugs.koha-community.org 09 Jun '22

09 Jun '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11889 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135874|0 |1 is obsolete| | --- Comment #95 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 135898 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135898&action=e… Bug 11889: (QA follow-up) Fix tests We need some changes for 28959 changing category to public. Added the userenv mocking. Note: A follow-up does a bit more refactoring here. But they should pass at least now. Test plan: Run t/db_dependent/Virtualshelves.t Run t/db_dependent/Koha/Patrons.t Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11889] Option to keep public or shared lists when deleting patron
by bugzilla-daemon＠bugs.koha-community.org 09 Jun '22

09 Jun '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11889 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135873|0 |1 is obsolete| | --- Comment #94 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 135897 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135897&action=e… Bug 11889: (QA follow-up) Changes for wantarray move in ->search See bug 29844. Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0