June 2022 - Koha-bugs - lists.koha-community.org

[Bug 11889] Disown a list
by bugzilla-daemon＠bugs.koha-community.org 09 Jun '22

09 Jun '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11889 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Signed Off CC| |martin.renvoize@ptfs-europe | |.com --- Comment #86 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- This was reported by myself in 2014 ! And Aleisha did a brave attempt to get this in in 2017. And then we started a discussion that kept this development in permafrost until now. And it will probably will stay there if we want to address all issues reported here. I would really love to get this further now. So I would propose the following: [1] Aleisha has 2 patches here, rest I added. There was already a signoff but since I added and refreshed it now, I take the signoff and ask for another QAer to have a look. Martin or Jonathan perhaps? [2] This development allows you to choose between current behavior or move ownership of public and shared lists to the staff member deleting a user. If you dont like transferring ownership like this, do not yet enable the pref. The fact that we have this pref, allows us to push this on its own. Important: note that deleting users with cron in an 'anonymized workflow' will still lead to deleting lists. We should still address that on a new report! Bug 30933. Allowing to designate a special user as owner. [3] We still need a separate transfer ownership feature. Will try to add some code on bug 25498. With [2] and [3] I think we covered all concerns in the discussion here, providing a foundation for several workflows with or without specially designated users for general lists. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 30932] New: Error while automatic upgrading
by bugzilla-daemon＠bugs.koha-community.org 09 Jun '22

09 Jun '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30932 Bug ID: 30932 Summary: Error while automatic upgrading Change sponsored?: --- Product: Koha Version: 21.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Installation and upgrade (web-based installer) Assignee: koha-bugs(a)lists.koha-community.org Reporter: keith(a)thesorbos.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com While running the automatic upgrading process, the system stops with this error. Our installation is now stuck. Can't open the system at all. Updating database structure Update errors : Upgrade to 21.12.00.016 [04:05:32]: Bug 30060 - Update user_permissions to add primary key and remove null option from code column ERROR: {UNKNOWN}: DBI Exception: DBD::mysql::db do failed: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'IF EXISTS `PRIMARY`' at line 1 at /usr/share/koha/lib/C4/Installer.pm line 739 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 3

[Bug 11889] Disown a list
by bugzilla-daemon＠bugs.koha-community.org 09 Jun '22

09 Jun '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11889 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135866|0 |1 is obsolete| | --- Comment #85 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 135876 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135876&action=e… Bug 11889: (follow-up) We did not need get_shared_shelves after all Test plan: Run t/db_dependent/Virtualshelves.t Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11889] Disown a list
by bugzilla-daemon＠bugs.koha-community.org 09 Jun '22

09 Jun '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11889 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135865|0 |1 is obsolete| | --- Comment #84 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 135875 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135875&action=e… Bug 11889: (follow-up) Get rid of FIXME in Koha::Patron Instead of get_lists, I added ->virtualshelves. I removed the addition of the suffix to the shelf name here; if we really want that (doubts), we should do it pref based. Removing a staff member with public lists would result in weird names with shelf numbers on the OPAC. (Should be very easy to restore.) Used this opportunity to refactor the patron->delete subtest a bit: switching to build_object, removing the 'retrieved patrons', differentiating between staff patron and patron for sharing, adding a few tests. Test plan: Enable transfer ownership. Delete a patron with lists in interface. Check what happened. Run t/db_dependent/Koha/Patrons.t. Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11889] Disown a list
by bugzilla-daemon＠bugs.koha-community.org 09 Jun '22

09 Jun '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11889 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135864|0 |1 is obsolete| | --- Comment #83 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 135874 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135874&action=e… Bug 11889: (QA follow-up) Fix tests We need some changes for 28959 changing category to public. Added the userenv mocking. Note: A follow-up does a bit more refactoring here. But they should pass at least now. Test plan: Run t/db_dependent/Virtualshelves.t Run t/db_dependent/Koha/Patrons.t Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11889] Disown a list
by bugzilla-daemon＠bugs.koha-community.org 09 Jun '22

09 Jun '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11889 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135863|0 |1 is obsolete| | --- Comment #82 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 135873 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135873&action=e… Bug 11889: (QA follow-up) Changes for wantarray move in ->search See bug 29844. Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11889] Disown a list
by bugzilla-daemon＠bugs.koha-community.org 09 Jun '22

09 Jun '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11889 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135862|0 |1 is obsolete| | --- Comment #81 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 135872 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135872&action=e… Bug 11889: (QA follow-up) Convert to new atomicupdate style The first patch contained an old .sql atomic update. Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11889] Disown a list
by bugzilla-daemon＠bugs.koha-community.org 09 Jun '22

09 Jun '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11889 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135861|0 |1 is obsolete| | --- Comment #80 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 135871 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135871&action=e… Bug 11889: (QA follow-up) Add POD ground work Make QA tools a fraction happier ;) Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11889] Disown a list
by bugzilla-daemon＠bugs.koha-community.org 09 Jun '22

09 Jun '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11889 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135860|0 |1 is obsolete| | --- Comment #79 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 135870 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135870&action=e… Bug 11889: (follow-up) Tests and new get_shared_shelves Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> This is a manual reconstruction of an older patch, that git did not want to apply anymore (sha trouble etc.) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11889] Disown a list
by bugzilla-daemon＠bugs.koha-community.org 09 Jun '22

09 Jun '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11889 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135859|0 |1 is obsolete| | --- Comment #78 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 135869 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135869&action=e… Bug 11889: (QA follow-up) Add entry to sysprefs.sql Also changes the insert in the atomic update to an insert ignore, as we generally do for inserting sysprefs (see updatedatabase). Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> Signed-off-by: Cédric Vita <cedric.vita(a)dracenie.com> -- You are receiving this mail because: You are watching all bug changes.

1 0