July 2022 - Koha-bugs - lists.koha-community.org

[Bug 15348] Change/Edit estimated delivery date per order line
by bugzilla-daemon＠bugs.koha-community.org 04 Jul '22

04 Jul '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #43 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Hi Aleisha, 1) there were several complaints by the QA tools that I have fixed 2 in separate follow-up patches. Could you please fix the third one? I have not been able to figure this one out: FAIL acqui/moddeliverydate.pl FAIL valid Useless use of private variable in void context 2) This bit here is not translatable: var modalTitle = $(this).attr("title") + " (order number " + ordernumber + ")"; 3) When adding a new order, there is no calendar widget for the estimated delivery date column. I have tried to do an update to flatpickr in a follow-up, but I think it's not complete yet. I believe these type of lines need to be removed from the files as well: $("#estimated_delivery_date").datepicker(); 4) Looking for 'datepicker' in the code, I saw that there is code for a modal in lateorders.tt, but it doesn't appear to be used, it looks like moddeliverdatey.tt is used instead. A modal like the edit notes one on the same page would really nice and more consistent: <div class="modal-content"> <div class="modal-header"> <button type="button" class="closebtn" data-dismiss="modal" aria-label="Close"><span aria-hidden="true">×</span></button> <h4 class="modal-title" id="dateEditorLabel">Estimated delivery date</h4> </div> <div class="modal-body"> <input type="text" id="estimated_delivery_date" size="10" name="estimated_delivery_date" class="datepicker" value="[% estimated_delivery_date | html %]"/> <div class="hint">[% INCLUDE 'date-format.inc' %]</div> <input type="hidden" id="date_ordernumber" name="ordernumber" value="" /> <input type="hidden" name="op" value="save" /> </div> 5) It's not possible to edit the estimated delivery date from a closed basket. If you reopen and close the basket, the close date will be updated, that is also used as the order date. So we need to be able to update this without reopening. 6) When editing the delivery date from the late orders page, things would explode. I fixed the import statements in a follow-up. Hope I caught them all. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15348] Change/Edit estimated delivery date per order line
by bugzilla-daemon＠bugs.koha-community.org 04 Jul '22

04 Jul '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348 --- Comment #42 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 137099 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137099&action=e… Bug 15348: (follow-up) Update calendar widget to flatpickr -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15348] Change/Edit estimated delivery date per order line
by bugzilla-daemon＠bugs.koha-community.org 04 Jul '22

04 Jul '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348 --- Comment #41 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 137098 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137098&action=e… Bug 15348: (follow-up) Fix imports in moddeliverydate.pl -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 31096] New: [DOCS] Review and update acquisitions chapter
by bugzilla-daemon＠bugs.koha-community.org 04 Jul '22

04 Jul '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31096 Bug ID: 31096 Summary: [DOCS] Review and update acquisitions chapter Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Documentation Assignee: koha-bugs(a)lists.koha-community.org Reporter: david(a)davidnind.com QA Contact: testopia(a)bugs.koha-community.org Review and update acquisitions chapter to bring up to date. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 1

[Bug 15348] Change/Edit estimated delivery date per order line
by bugzilla-daemon＠bugs.koha-community.org 04 Jul '22

04 Jul '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137061|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15348] Change/Edit estimated delivery date per order line
by bugzilla-daemon＠bugs.koha-community.org 04 Jul '22

04 Jul '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348 --- Comment #40 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 137061 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137061&action=e… Bug 15348: (QA follow-up) Fix useless use of proviate variable in void context FAIL acqui/moddeliverydate.pl FAIL valid Useless use of private variable in void context -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 27857] New: Koha::Patron->extended_attributes skips checks
by bugzilla-daemon＠bugs.koha-community.org 04 Jul '22

04 Jul '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27857 Bug ID: 27857 Summary: Koha::Patron->extended_attributes skips checks Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: tomascohen(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org Patron attributes can have some requirements: - Be unique across the DB - (Not) bd repeatable This is correctly handled by both - Koha::Patron::Attribute->store - Koha::Patron->add_extended_attribute But then, there's Koha::Patron->extended_attributes, that can overwrite them all at once, but doesn't rely on those methods, and uses DBIC relations instead, so no checks on attribute constraints are made. We need to fix it. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 58

[Bug 15348] Change/Edit estimated delivery date per order line
by bugzilla-daemon＠bugs.koha-community.org 04 Jul '22

04 Jul '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348 --- Comment #39 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 137058 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137058&action=e… Bug 15348: (follow-up) Fix export of dt_from_string FAIL acqui/addorder.pl FAIL valid " dt_from_string " is not exported by the Koha::DateUtils module Can't continue after import errors -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15348] Change/Edit estimated delivery date per order line
by bugzilla-daemon＠bugs.koha-community.org 04 Jul '22

04 Jul '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348 --- Comment #38 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 137057 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137057&action=e… Bug 15348: (follow-up) Fix TT filters from html to uri -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 31094] New: day
by bugzilla-daemon＠bugs.koha-community.org 04 Jul '22

04 Jul '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31094 Bug ID: 31094 Summary: day Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Authentication Assignee: koha-bugs(a)lists.koha-community.org Reporter: santrinakal757(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org CC: dpavlin(a)rot13.org Created attachment 137051 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137051&action=e… Anjay anjay -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 1