August 2022 - Koha-bugs - lists.koha-community.org

[Bug 28125] New: All OPAC holds blocked when OPACHiddenItems contains incorrect values
by bugzilla-daemon＠bugs.koha-community.org 26 Aug '22

26 Aug '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28125 Bug ID: 28125 Summary: All OPAC holds blocked when OPACHiddenItems contains incorrect values Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Hold requests Assignee: koha-bugs(a)lists.koha-community.org Reporter: andrew(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com Depends on: 15448 >From bug 15448, we're now checking OPACHiddenItems to see if something is hidden before we allow a hold on it. However, the manner in which that check is performed causes a problem if the syspref contains incorrect values. To recreate: - make sure OPACHiddenItems is empty - find a holdable item on the OPAC, confirm you can place a hold on it - enter "itemlost: [AB]" in OPACHiddenItems (an incorrect value because itemlost can only contain 1 bit) - confirm your item is not hidden from the OPAC but you are told it is not available for holds You'll see the same behavior if you use an incorrect field name, like "lost" or "itemtype." Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15448 [Bug 15448] Placing hold on specific items doesn't enforce OpacHiddenItems -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 21

[Bug 3150] Move emails for sending cart and list contents into notices tool
by bugzilla-daemon＠bugs.koha-community.org 26 Aug '22

26 Aug '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #105 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Patches currently don't apply and the conflicts looked a bit too intimidating for me: Applying: Bug 3150: Move emails for sending cart and list contents to notices Using index info to reconstruct a base tree... M basket/sendbasket.pl M installer/data/mysql/en/mandatory/sample_notices.yml M opac/opac-sendbasket.pl M opac/opac-sendshelf.pl M virtualshelves/sendshelf.pl Falling back to patching base and 3-way merge... Auto-merging virtualshelves/sendshelf.pl CONFLICT (content): Merge conflict in virtualshelves/sendshelf.pl Auto-merging opac/opac-sendshelf.pl CONFLICT (content): Merge conflict in opac/opac-sendshelf.pl Auto-merging opac/opac-sendbasket.pl CONFLICT (content): Merge conflict in opac/opac-sendbasket.pl Auto-merging installer/data/mysql/en/mandatory/sample_notices.yml Auto-merging basket/sendbasket.pl CONFLICT (content): Merge conflict in basket/sendbasket.pl error: Failed to merge in the changes. Patch failed at 0001 Bug 3150: Move emails for sending cart and list contents to notices hint: Use 'git am --show-current-patch=diff' to see the failed patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-3150-Move-emails-for-sending-cart-and-list-con-Oc2KWz.patch -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15348] Change/Edit estimated delivery date per order line
by bugzilla-daemon＠bugs.koha-community.org 26 Aug '22

26 Aug '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348 --- Comment #119 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Rebased, tests pass and retested functionality on addorder.pl -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15348] Change/Edit estimated delivery date per order line
by bugzilla-daemon＠bugs.koha-community.org 26 Aug '22

26 Aug '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139365|0 |1 is obsolete| | --- Comment #118 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 139845 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139845&action=e… Bug 15348: (follow-up) Fix pre-selected date when editing from late orders page When editing the estimated delivery date from the late orders page, with multiple late orders, the selected date in the edit form would always be the same, not matching the edited date. With this page, the edited date will match what is shown in the form. Signed-off-by: Katrin Fischer <katrin.fischer(a)bsz-bw.de> Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15348] Change/Edit estimated delivery date per order line
by bugzilla-daemon＠bugs.koha-community.org 26 Aug '22

26 Aug '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139364|0 |1 is obsolete| | --- Comment #117 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 139844 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139844&action=e… Bug 15348: (follow-up) Fix sorting of estimated delivery date on basket summary page Also removes some unneded variables from the table footers that are used to display amount totals. Signed-off-by: Katrin Fischer <katrin.fischer(a)bsz-bw.de> Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15348] Change/Edit estimated delivery date per order line
by bugzilla-daemon＠bugs.koha-community.org 26 Aug '22

26 Aug '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139363|0 |1 is obsolete| | --- Comment #116 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 139843 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139843&action=e… Bug 15348: (follow-up) Move estimated delivery date before supplier report and fix column settings On the basket summary page the estimated delivery date column was moved before the supplier report column, that is only visible when EDIFACT has been activated. It also adds the new column to the table configuration. Signed-off-by: Katrin Fischer <katrin.fischer(a)bsz-bw.de> Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15348] Change/Edit estimated delivery date per order line
by bugzilla-daemon＠bugs.koha-community.org 26 Aug '22

26 Aug '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139362|0 |1 is obsolete| | --- Comment #115 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 139842 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139842&action=e… Bug 15348: (follow-up) Fix filtering results on estimated delivery date Adding another clause to the SQL so that the specified estimated delivery date is used for filtering first, and the calculated delivery date is used if there is no specified estimated delivery date. Signed-off-by: Christian Stelzenmüller <christian.stelzenmueller(a)bsz-bw.de> Signed-off-by: Katrin Fischer <katrin.fischer(a)bsz-bw.de> Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15348] Change/Edit estimated delivery date per order line
by bugzilla-daemon＠bugs.koha-community.org 26 Aug '22

26 Aug '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139361|0 |1 is obsolete| | --- Comment #114 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 139841 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139841&action=e… Bug 15348: (follow-up) Fix modal to edit delivery date This allows you to empty the delivery date and ensures the current date shows Signed-off-by: Christian Stelzenmüller <christian.stelzenmueller(a)bsz-bw.de> Signed-off-by: Katrin Fischer <katrin.fischer(a)bsz-bw.de> Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15348] Change/Edit estimated delivery date per order line
by bugzilla-daemon＠bugs.koha-community.org 26 Aug '22

26 Aug '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139360|0 |1 is obsolete| | --- Comment #113 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 139840 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139840&action=e… Bug 15348: DBIC changes DO NOT PUSH For testing purposes Signed-off-by: Christian Stelzenmüller <christian.stelzenmueller(a)bsz-bw.de> Signed-off-by: Katrin Fischer <katrin.fischer(a)bsz-bw.de> Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15348] Change/Edit estimated delivery date per order line
by bugzilla-daemon＠bugs.koha-community.org 26 Aug '22

26 Aug '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139359|0 |1 is obsolete| | --- Comment #112 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 139839 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139839&action=e… Bug 15348: (follow-up) Fix calendar widget, translateability, etc Also add functionality to edit the estimated delivery date from a closed basket. Signed-off-by: Christian Stelzenmüller <christian.stelzenmueller(a)bsz-bw.de> Signed-off-by: Katrin Fischer <katrin.fischer(a)bsz-bw.de> Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0