August 2022 - Koha-bugs - lists.koha-community.org

[Bug 31353] New: Improve display of lost items when placing holds in OPAC
by bugzilla-daemon＠bugs.koha-community.org 18 Aug '22

18 Aug '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31353 Bug ID: 31353 Summary: Improve display of lost items when placing holds in OPAC Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard(a)myacpl.org Reporter: katrin.fischer(a)bsz-bw.de QA Contact: testopia(a)bugs.koha-community.org Bug 31314 revealed some oddness in our display of lost items. It changed from: # Management of lost or long overdue items - if ( $itemInfo->{itemlost} ) { - - # FIXME localized strings should never be in Perl code - $itemLoopIter->{message} = - $itemInfo->{itemlost} == 1 ? "(lost)" - : $itemInfo->{itemlost} == 2 ? "(long overdue)" - : ""; - $itemInfo->{backgroundcolor} = 'other'; - } To: + [% IF ( itemLoo.itemlost == 1 || itemLoo.itemlost == 2 ) %] [%# FIXME Why only for 1 or 2? Shouldn't we test for withdrawn as well? %] <span class="lost">Unavailable (lost or missing)</span> [% END %] Indeed we should display the description of the LOST authorised value here for all authorised values that are > 0. -- You are receiving this mail because: You are watching all bug changes.

1 2

[Bug 31275] New: AdditionalContents.search_for_display returns branch block and All block
by bugzilla-daemon＠bugs.koha-community.org 18 Aug '22

18 Aug '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31275 Bug ID: 31275 Summary: AdditionalContents.search_for_display returns branch block and All block Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Tools Assignee: koha-bugs(a)lists.koha-community.org Reporter: m.de.rooy(a)rijksmuseum.nl QA Contact: testopia(a)bugs.koha-community.org If there is a branch specific block, you normally dont want the All block to appear too. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 12

[Bug 15348] Change/Edit estimated delivery date per order line
by bugzilla-daemon＠bugs.koha-community.org 18 Aug '22

18 Aug '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348 --- Comment #102 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- (In reply to Martin Renvoize from comment #101) > Happy to coach on converting to API later btw.. it would be good to get more > devs up to speed on it.. I'm under no illusions there are certainly rough > edges still ;P Planning to 'harass' you guys for helping me sort the API related pages in the wiki once the update has happened, we have a lot of pages but I have no idea which information is actually current. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15326] Add CMS feature
by bugzilla-daemon＠bugs.koha-community.org 18 Aug '22

18 Aug '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29190 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15348] Change/Edit estimated delivery date per order line
by bugzilla-daemon＠bugs.koha-community.org 18 Aug '22

18 Aug '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348 --- Comment #101 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Happy to coach on converting to API later btw.. it would be good to get more devs up to speed on it.. I'm under no illusions there are certainly rough edges still ;P -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15348] Change/Edit estimated delivery date per order line
by bugzilla-daemon＠bugs.koha-community.org 18 Aug '22

18 Aug '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #100 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- The code works and there are no obvious regressions.. QA scripts are also happy.. I don't really understand why we introduce a new controller here where an API would have made more sense.. code only appears to have been submitted in 2020 and the API was already starting to get a lot more use. Passing QA however.. it just means more work for someone down the line to update it to use API's. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15348] Change/Edit estimated delivery date per order line
by bugzilla-daemon＠bugs.koha-community.org 18 Aug '22

18 Aug '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139343|0 |1 is obsolete| | --- Comment #99 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 139365 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139365&action=e… Bug 15348: (follow-up) Fix pre-selected date when editing from late orders page When editing the estimated delivery date from the late orders page, with multiple late orders, the selected date in the edit form would always be the same, not matching the edited date. With this page, the edited date will match what is shown in the form. Signed-off-by: Katrin Fischer <katrin.fischer(a)bsz-bw.de> Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15348] Change/Edit estimated delivery date per order line
by bugzilla-daemon＠bugs.koha-community.org 18 Aug '22

18 Aug '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139342|0 |1 is obsolete| | --- Comment #98 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 139364 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139364&action=e… Bug 15348: (follow-up) Fix sorting of estimated delivery date on basket summary page Also removes some unneded variables from the table footers that are used to display amount totals. Signed-off-by: Katrin Fischer <katrin.fischer(a)bsz-bw.de> Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15348] Change/Edit estimated delivery date per order line
by bugzilla-daemon＠bugs.koha-community.org 18 Aug '22

18 Aug '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139341|0 |1 is obsolete| | --- Comment #97 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 139363 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139363&action=e… Bug 15348: (follow-up) Move estimated delivery date before supplier report and fix column settings On the basket summary page the estimated delivery date column was moved before the supplier report column, that is only visible when EDIFACT has been activated. It also adds the new column to the table configuration. Signed-off-by: Katrin Fischer <katrin.fischer(a)bsz-bw.de> Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15348] Change/Edit estimated delivery date per order line
by bugzilla-daemon＠bugs.koha-community.org 18 Aug '22

18 Aug '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139340|0 |1 is obsolete| | --- Comment #96 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 139362 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139362&action=e… Bug 15348: (follow-up) Fix filtering results on estimated delivery date Adding another clause to the SQL so that the specified estimated delivery date is used for filtering first, and the calculated delivery date is used if there is no specified estimated delivery date. Signed-off-by: Christian Stelzenmüller <christian.stelzenmueller(a)bsz-bw.de> Signed-off-by: Katrin Fischer <katrin.fischer(a)bsz-bw.de> Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0