September 2022 - Koha-bugs - lists.koha-community.org

[Bug 30504] New: Value builder for field $181
by bugzilla-daemon＠bugs.koha-community.org 07 Dec '22

07 Dec '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30504 Bug ID: 30504 Summary: Value builder for field $181 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Cataloging Assignee: koha-bugs(a)lists.koha-community.org Reporter: jeremy.breuillard(a)biblibre.com QA Contact: testopia(a)bugs.koha-community.org CC: m.de.rooy(a)rijksmuseum.nl It could be easier to have plugins on each subfield for field $181 : $a, $b, $c and $2 The value builder plugins let you choose a code based on unimarc official documents and depending on the item you want to store in koha -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 28

[Bug 30506] New: Value builder for field 182
by bugzilla-daemon＠bugs.koha-community.org 07 Dec '22

07 Dec '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30506 Bug ID: 30506 Summary: Value builder for field 182 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Cataloging Assignee: koha-bugs(a)lists.koha-community.org Reporter: jeremy.breuillard(a)biblibre.com QA Contact: testopia(a)bugs.koha-community.org CC: m.de.rooy(a)rijksmuseum.nl It could be easier to have plugins on each subfield for field $182 : $a, $c and $2 The value builder plugins let you choose a alphanumeric code based on unimarc official documents and depending on the item you want to store in koha -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 28

[Bug 29159] New: UNIMARC update from IFLA for new Koha installations
by bugzilla-daemon＠bugs.koha-community.org 07 Dec '22

07 Dec '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29159 Bug ID: 29159 Summary: UNIMARC update from IFLA for new Koha installations Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: new feature Priority: P5 - low Component: MARC Bibliographic data support Assignee: koha-bugs(a)lists.koha-community.org Reporter: Igor.A.Sychev(a)mail.ru QA Contact: testopia(a)bugs.koha-community.org Hello! Field 181, 182, 183 UNIMARK contains encoded data. It is now a simple text box. Please, add "Tag editor". https://cdn.ifla.org/wp-content/uploads/files/assets/uca/unimarc_updates/BI… https://cdn.ifla.org/wp-content/uploads/files/assets/uca/unimarc_updates/BI… https://cdn.ifla.org/wp-content/uploads/files/assets/uca/unimarc_updates/BI… -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 6

[Bug 19963] New: ethnicity and ethnicity tables and columns survived update
by bugzilla-daemon＠bugs.koha-community.org 06 Dec '22

06 Dec '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19963 Bug ID: 19963 Summary: ethnicity and ethnicity tables and columns survived update Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Database Assignee: koha-bugs(a)lists.koha-community.org Reporter: katrin.fischer(a)bsz-bw.de QA Contact: testopia(a)bugs.koha-community.org The database update for 3.21.00.033 should have removed the ethnicity table and the ethnicity and ethnotes columns from borrowers, deletedborrowers and borrower_modifications. This didn't work right in all cases. I just noticed that all those survived in our older databases. The reason is that the database update only checked for NULL when counting existing data, but not for "": 11054 $DBversion = "3.21.00.033"; 11055 if ( CheckVersion($DBversion) ) { 11056 11057 my $done = 0; 11058 my $count_ethnicity = $dbh->selectrow_arrayref(q| 11059 SELECT COUNT(*) FROM ethnicity 11060 |); 11061 my $count_borrower_modifications = $dbh->selectrow_arrayref(q| 11062 SELECT COUNT(*) 11063 FROM borrower_modifications 11064 WHERE ethnicity IS NOT NULL 11065 OR ethnotes IS NOT NULL 11066 |); 11067 my $count_borrowers = $dbh->selectrow_arrayref(q| 11068 SELECT COUNT(*) 11069 FROM borrowers 11070 WHERE ethnicity IS NOT NULL 11071 OR ethnotes IS NOT NULL 11072 |); 11073 # We don't care about the ethnicity of the deleted borrowers, right? 11074 if ( $count_ethnicity->[0] == 0 11075 and $count_borrower_modifications->[0] == 0 11076 and $count_borrowers->[0] == 0 11077 ) { 11078 $dbh->do(q| 11079 DROP TABLE ethnicity 11080 |); 11081 $dbh->do(q| 11082 ALTER TABLE borrower_modifications 11083 DROP COLUMN ethnicity, 11084 DROP COLUMN ethnotes 11085 |); 11086 $dbh->do(q| 11087 ALTER TABLE borrowers 11088 DROP COLUMN ethnicity, 11089 DROP COLUMN ethnotes 11090 |); 11091 $dbh->do(q| 11092 ALTER TABLE deletedborrowers 11093 DROP COLUMN ethnicity, 11094 DROP COLUMN ethnotes 11095 |); 11096 $done = 1; 11097 } 11098 if ( $done ) { 11099 print "Upgrade to $DBversion done (Bug 10020: Drop table ethnicity and columns ethnicity and ethnotes)\n"; 11100 } 11101 else { 11102 print "Upgrade to $DBversion done (Bug 10020: This database contains data related to 'ethnicity'. No change will be done on the DB structure but note that the Koha codebase does not use it)\n"; 11103 } 11104 11105 SetVersion ($DBversion); -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 4

[Bug 20591] New: DBI->last_insert_id does not work as expected
by bugzilla-daemon＠bugs.koha-community.org 06 Dec '22

06 Dec '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20591 Bug ID: 20591 Summary: DBI->last_insert_id does not work as expected Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org Try the following code: use Koha::Database; use Koha::Cities; use Koha::AuthorisedValues; my $schema = Koha::Database->schema; $schema->storage->txn_begin; my $dbh = C4::Context->dbh; my $city = Koha::City->new({ city_name => 'name' })->store; say $city->cityid; say $dbh->last_insert_id( undef, undef, 'cities', undef ); say $dbh->last_insert_id( undef, undef, 'not_exist', undef ); say "==="; my $av = Koha::AuthorisedValue->new({category => 'LOC', authorised_value => 'just_a_test'})->store; say $av->id; say $dbh->last_insert_id( undef, undef, 'authorised_values', undef ); say $dbh->last_insert_id( undef, undef, 'cities', undef ); say $dbh->last_insert_id( undef, undef, 'not_exist', undef ); It will display: 12 12 12 === 401 401 401 401 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 7

[Bug 16536] New: Warn about Template Toolkit directives inside HTML tags
by bugzilla-daemon＠bugs.koha-community.org 06 Dec '22

06 Dec '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16536 Bug ID: 16536 Summary: Warn about Template Toolkit directives inside HTML tags Change sponsored?: --- Product: Project Infrastructure Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: QA tools Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: oleonard(a)myacpl.org I was testing a patch (on Bug 16525) which contained this markup: <a href="[% IF ( budget_period_id) %]/cgi-bin/koha/admin/aqbudgets.pl?budget_period_id=[% budget_period_id %][% ELSE %]/cgi-bin/koha/admin/aqbudgetperiods.pl[% END %]" class="cancel">Cancel</a> I expected it to trigger a warning by the QA tools. My system is a gitified package install, so it seems possible that this is a problem with my configuration. Running "prove xt" doesn't catch it either. -- You are receiving this mail because: You are watching all bug changes.

1 8

[Bug 24539] New: Build generic authentication module interface
by bugzilla-daemon＠bugs.koha-community.org 06 Dec '22

06 Dec '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24539 Bug ID: 24539 Summary: Build generic authentication module interface Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Authentication Assignee: koha-bugs(a)lists.koha-community.org Reporter: dcook(a)prosentient.com.au QA Contact: testopia(a)bugs.koha-community.org CC: dpavlin(a)rot13.org Locally, I run a number of custom authentication integrations for Koha, and I've been thinking it would be great if there were a generic authentication module interface. So I've refactored my local OpenID Connect implementation, so that the changes to Auth.pm and opac-auth.tt are very generic, and other authentication modules could easily leverage them without touching Auth.pm or opac-auth.tt. (The latter remains translateable as generic messages are in opac-auth.tt and they are bound to keys passed from the authentication module.) Right now, you invoke a custom endpoint (I have ideas about making those more generic and extensible too) and it passes an object to C4::Auth::checkauth(). The module for that object and some other data are persisted in the logged in user's session. To log off, you just hit the log off button, Koha gets relevant info from the user's session, and runs the authentication module's logout hook. My goal is to make it so that people can rapidly develop authentication modules, and make it easy to swap in and out different modules. (For instance, my local OpenID Connect code works and works reasonable well, but it's not perfect. However, I shouldn't need to touch Auth.pm and opac-auth.tt to improve that code. The improvements should be isolated within the specific authentication module itself.) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 29

[Bug 25713] New: get_qualified_table_name should be a class method rather than an object method
by bugzilla-daemon＠bugs.koha-community.org 06 Dec '22

06 Dec '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25713 Bug ID: 25713 Summary: get_qualified_table_name should be a class method rather than an object method Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Plugin architecture Assignee: koha-bugs(a)lists.koha-community.org Reporter: dcook(a)prosentient.com.au QA Contact: testopia(a)bugs.koha-community.org It would be very useful if "get_qualified_table_name" were a class method rather than an object method. That way you should easily get a qualified table name from anywhere in a plugin without having to instantiate a plugin object. The current method could be updated to support either class or object method invocations. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 1

[Bug 21153] New: Add system preference to hide login box on opac-main.pl
by bugzilla-daemon＠bugs.koha-community.org 06 Dec '22

06 Dec '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21153 Bug ID: 21153 Summary: Add system preference to hide login box on opac-main.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard(a)myacpl.org Reporter: dcook(a)prosentient.com.au QA Contact: testopia(a)bugs.koha-community.org There should be a system preference to hide the login box on opac-main.pl, and that system preference should also make it so that the opacmainuserblock can be 12 if opacuserlogin == 1 but the new system preference == 0. I have a lot of people who hide it with CSS, but it means that a lot of front page real estate is wasted with whitespace. -- You are receiving this mail because: You are watching all bug changes.

1 1

[Bug 25794] New: Add PKI/x509/client SSL authentication to REST API
by bugzilla-daemon＠bugs.koha-community.org 06 Dec '22

06 Dec '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25794 Bug ID: 25794 Summary: Add PKI/x509/client SSL authentication to REST API Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: REST API Assignee: koha-bugs(a)lists.koha-community.org Reporter: dcook(a)prosentient.com.au It could be useful to add PKI/x509/client SSL authentication to the REST API to ease machine-to-machine interactions. A vendor could set up all their Koha instances to trust certificates signed by the a vendor's certificate authority public key. Then all new API consumers could just get certificates issued by the vendor's CA. That said, I suppose authorization would still be a problem. With Bug 6296, they were still mapping the certificate to a Koha user. And then there's the issue of how to handle revoked certificates. Maybe it is best just to rely on OAuth2 and Basic Auth. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 3