September 2022 - Koha-bugs - lists.koha-community.org

[Bug 31247] New: Staff interface 2FA blocks logging into the OPAC
by bugzilla-daemon＠bugs.koha-community.org 14 Oct '22

14 Oct '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31247 Bug ID: 31247 Summary: Staff interface 2FA blocks logging into the OPAC Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Authentication Assignee: koha-bugs(a)lists.koha-community.org Reporter: caroline.cyr-la-rose(a)inlibro.com QA Contact: testopia(a)bugs.koha-community.org CC: dpavlin(a)rot13.org I noticed when I turned on the 2FA for my staff account, I'm no longer able to log into the OPAC with that same account. I usually use the same account for both, so I find this a major drawback in using 2FA. To test: 1) With 2FA turned off, log into the staff interface with your staff account --> login is normal 2) With 2FA turned off, log into the OPAC with the same account --> login is normal 3) Turn on 2FA 3.1) In System preferences, enable TwoFactorAuthentication 3.2) Go to 'My account' (click your username in the top right and choose 'My account) 3.3) Click More > Manage two-factor authentication 3.4) Click Enable two-factor authentication 3.5) With an authenticator app (I used FreeOTP) scan the QR code 3.6) Enter the PIN provided by the app in the PIN code field 3.7) Click Register with two-factor app 4) Log out of the staff interface 5) Log into the staff interface --> Username, password and two-factor code is needed 6) Log out of the OPAC 7) Log into the OPAC (I used the login box on the right) --> It cycles back to the login page, you can never log in 8) In the staff interface, disable 2FA 8.1) In 'My account', click More > Manage two-factor authentication 8.2) Click Disable two-factor authentication 9) Log into the OPAC --> login is normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 21

[Bug 31274] New: OPACSuggestionAutoFill must be 1 or 0
by bugzilla-daemon＠bugs.koha-community.org 14 Oct '22

14 Oct '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31274 Bug ID: 31274 Summary: OPACSuggestionAutoFill must be 1 or 0 Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: jonathan.druart+koha(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org Depends on: 14242 It's "yes" or "no". Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242 [Bug 14242] Use ISBN-field to fill out purchase suggestions using Google Books API -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 16

[Bug 30747] New: Column settings on otherholdings table in detail.tt doesnt work
by bugzilla-daemon＠bugs.koha-community.org 14 Oct '22

14 Oct '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30747 Bug ID: 30747 Summary: Column settings on otherholdings table in detail.tt doesnt work Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs(a)lists.koha-community.org Reporter: lucas(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com If you turn on the system preference SeparateHoldings you will get a otherholdings table on detail.tt. Table settings cannot be applied to this table. The the Columns icon is not present in the top pager. The reason is because of the JS: if ( !has_images[i] ) { // remove the cover_image column table_settings.splice(1,1); } table_settings.splice(1,1) is removing the table settings that control the otherholdings table columns. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 28

[Bug 30776] New: import_webservice_batch.pl cronjob completely broken
by bugzilla-daemon＠bugs.koha-community.org 14 Oct '22

14 Oct '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30776 Bug ID: 30776 Summary: import_webservice_batch.pl cronjob completely broken Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Command-line Utilities Assignee: koha-bugs(a)lists.koha-community.org Reporter: joonas.kylmala(a)iki.fi QA Contact: testopia(a)bugs.koha-community.org CC: robin(a)catalyst.net.nz The import_webservice_batch.pl cronjob doesn't work at all due to a missing import. > $ perl misc/cronjobs/import_webservice_batch.pl > Undefined subroutine &main::GetStagedWebserviceBatches called at misc/cronjobs/import_webservice_batch.pl line 46 Not sure if anyone uses this but this is an easy fix, we can remove the feature later if it is unused. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 10

[Bug 30714] New: Checkins from other branches spam the cataloguing log
by bugzilla-daemon＠bugs.koha-community.org 14 Oct '22

14 Oct '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30714 Bug ID: 30714 Summary: Checkins from other branches spam the cataloguing log Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org When an item from another branch is checked in, the holdingbranch is updated, and this change is logged. We record the checkin in statistics, we do not need the cataloguing update logged To recreate: 1 - Enable cataloguing log 2 - Check in an item with a different holding branch 3 - Check the action logs 4 - There is a cataloguing log for the holdingbranch update -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 17

[Bug 30640] New: Focus does not always move to correct search header form field
by bugzilla-daemon＠bugs.koha-community.org 14 Oct '22

14 Oct '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30640 Bug ID: 30640 Summary: Focus does not always move to correct search header form field Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org Depends on: 29155 The jQuery upgrade has introduced a bug with how the header search form is supposed to handle focus. This can be seen in any page where the "Check out" tab is present in the header search but not the pre-selected tab, e.g. the patron detail tab. On the patron details page the "Search patrons" tab is selected by default, and the cursor focus is automatically put on the form field. Switch to the "Check out" tab and you'll find that the focus doesn't move to the form field. The other tabs don't have this problem. I think this is the explanation: https://github.com/jquery/jquery/issues/4950 To fix we'll need to remove the "focus" class on form fields which might be hidden by default and update the tabs behavior to make sure the right field is focused on load. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29155 [Bug 29155] Upgrade jquery version to 3.6.0 -- You are receiving this mail because: You are watching all bug changes.

1 12

[Bug 30009] New: Records with invalid MarcXML show notes tab 'Descriptions(1)' but tab is empty
by bugzilla-daemon＠bugs.koha-community.org 14 Oct '22

14 Oct '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30009 Bug ID: 30009 Summary: Records with invalid MarcXML show notes tab 'Descriptions(1)' but tab is empty Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org See bug 29690 - find/create a record with invalid marc Notes tab shows but is empty -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 23

[Bug 22407] New: OMNIBUS: Use DBIC relations to fetch related object rather than searching for the object
by bugzilla-daemon＠bugs.koha-community.org 14 Oct '22

14 Oct '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22407 Bug ID: 22407 Summary: OMNIBUS: Use DBIC relations to fetch related object rather than searching for the object Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org Target Milestone: --- Example, instead of this: return Koha::Patrons->find( $self->guarantorid() ); We should do this: return Koha::Patron->_new_from_dbic($self->_result->guarantor); This allows us to use prefetch and perform a single query as opposed to multiple queries -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 38

[Bug 29939] New: Improve auth check in opac-ratings-ajax.pl
by bugzilla-daemon＠bugs.koha-community.org 14 Oct '22

14 Oct '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29939 Bug ID: 29939 Summary: Improve auth check in opac-ratings-ajax.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: m.de.rooy(a)rijksmuseum.nl QA Contact: testopia(a)bugs.koha-community.org This script certainly needs a better authentication check but it is less trivial than the others. The block with Koha::Ratings calls should be within a check on loggedinuser. The whole script is a weird mix between an ajax script and a regular one. This statement will crash on an undefined borrowernumber (SQL constraint): Koha::Rating->new( { biblionumber => $biblionumber, borrowernumber => $loggedinuser, rating_value => $rating_value, })->store; -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 13

[Bug 30218] New: Add subfield g to 150 heading_fields
by bugzilla-daemon＠bugs.koha-community.org 14 Oct '22

14 Oct '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30218 Bug ID: 30218 Summary: Add subfield g to 150 heading_fields Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: MARC Authority data support Assignee: koha-bugs(a)lists.koha-community.org Reporter: domm(a)plix.at QA Contact: testopia(a)bugs.koha-community.org When creating authorities via SRU or linking exising authorities (via cgi-bin/koha/authorities/auth_finder.pl) the search results are generated using the hardcoded mappings $bib_heading_fields / $auth_heading_field from C4::Heading::MARC21. For TOPIC_TERM / field 150 these mappings currently include the subfield `abvxyz68`. But: We are using the GND provided by Deutsche Nationalbibliothek. We imported some authorities from there, for example: http://d-nb.info/gnd/4114171-4 "Kind <0-3 Jahre>" (kid 0-3 years) http://d-nb.info/gnd/4196417-2 "Kind <0-4 Jahre>" (kid 0-4 years) When searching for these terms, Koha only displays "Kind", which is not very helpful, as there are a lot of different authorities for different age bands. GND stores "Kind" in 150a, and "0-3 Jahre" in 150g. But in the hardcoded mappings used by Koha, subfield g is not included. This patch adds subfield g to these mappings, thus making it possible to easily select the correct authority. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 12