September 2022 - Koha-bugs - lists.koha-community.org

[Bug 31120] New: Items will renew for zero ( 0 ) days if renewalperiod is blank/empty value
by bugzilla-daemon＠bugs.koha-community.org 20 Sep '22

20 Sep '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31120 Bug ID: 31120 Summary: Items will renew for zero ( 0 ) days if renewalperiod is blank/empty value Change sponsored?: --- Product: Koha Version: 21.05 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: kyle(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com If the rule renewalperiod is the blank empty string instead of being null/undefined or non-existant, Koha will interpret the renewal period as being zero days instead of falling back to the issuelength rule. It makes sense to me that a literal 0 here should make it renew for zero days even though that is nonsensical. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 21

[Bug 30878] New: Canceling holds from 'Holds awaiting pickup' should not reset the selected tab
by bugzilla-daemon＠bugs.koha-community.org 20 Sep '22

20 Sep '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30878 Bug ID: 30878 Summary: Canceling holds from 'Holds awaiting pickup' should not reset the selected tab Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs(a)lists.koha-community.org Reporter: lari.taskula(a)hypernova.fi QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com When canceling holds waiting over X days in "Holds awaiting pickup" view, form submission resets the selected tab to "Holds waiting". This tab reset may cause confusion for the user and lead to unwanted actions. Instead, the user should be returned to the same tab that they began with. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 14

[Bug 12285] Allow easy printing of patron's fines
by bugzilla-daemon＠bugs.koha-community.org 20 Sep '22

20 Sep '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12285 Lisette Scheer <lisettepalouse+koha(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #47 from Lisette Scheer <lisettepalouse+koha(a)gmail.com> --- Worked as expected. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12285] Allow easy printing of patron's fines
by bugzilla-daemon＠bugs.koha-community.org 20 Sep '22

20 Sep '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12285 ByWater Sandboxes <bws.sandboxes(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139042|0 |1 is obsolete| | --- Comment #46 from ByWater Sandboxes <bws.sandboxes(a)gmail.com> --- Created attachment 140800 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140800&action=e… Bug 12285: Determine patrons preferred languge Fineslip is not printed by patrons preferred language choice. To test: 1) Add content to fineslip under "en" tab. 2) Find patron with fines. 3) Set patrons preferred language as "en". 4) Print fines. => Fineslip has default content. 5) Apply patch. 6) Print slip. => Fineslip has "en" content. Sponsored-by: Koha-Suomi Oy Signed-off-by: Lisette Scheer <lisettePalouse+Koha(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12285] Allow easy printing of patron's fines
by bugzilla-daemon＠bugs.koha-community.org 20 Sep '22

20 Sep '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12285 ByWater Sandboxes <bws.sandboxes(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139041|0 |1 is obsolete| | --- Comment #45 from ByWater Sandboxes <bws.sandboxes(a)gmail.com> --- Created attachment 140799 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140799&action=e… Bug 12285: Don't print fines with undef amountoutstanding Accountlines with undefined amountoutstading value are printed in fineslip. To test: 1) Find patron with credit type accountlines. 2) Edit some of those lines from database, set their amountoutstanding as NULL. 3) Print fineslip. => Note that edited credit lines are displayed in the fineslip. 4) Apply patch. 5) Print fineslip. => Note that lines are no longer displayed in the fineslip. Sponsored-by: Koha-Suomi Oy Signed-off-by: Lisette Scheer <lisettePalouse+Koha(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12285] Allow easy printing of patron's fines
by bugzilla-daemon＠bugs.koha-community.org 20 Sep '22

20 Sep '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12285 ByWater Sandboxes <bws.sandboxes(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139040|0 |1 is obsolete| | --- Comment #44 from ByWater Sandboxes <bws.sandboxes(a)gmail.com> --- Created attachment 140798 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140798&action=e… Bug 12285: (follow-up) Correct extra quote in yml file Signed-off-by: Owen Leonard <oleonard(a)myacpl.org> Signed-off-by: Lisette Scheer <lisettePalouse+Koha(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12285] Allow easy printing of patron's fines
by bugzilla-daemon＠bugs.koha-community.org 20 Sep '22

20 Sep '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12285 ByWater Sandboxes <bws.sandboxes(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139039|0 |1 is obsolete| | --- Comment #43 from ByWater Sandboxes <bws.sandboxes(a)gmail.com> --- Created attachment 140797 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140797&action=e… Bug 12285: Use accountlines date if issue is not found Printing fines slip would raise error if patron has manually created invoice. In these cases use accountlines date instead of issues date_due. Also silence error: "Argument "" isn't numeric in numeric comparison (<=>)" Sponsored-by: Koha-Suomi Oy Signed-off-by: Owen Leonard <oleonard(a)myacpl.org> Signed-off-by: Lisette Scheer <lisettePalouse+Koha(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12285] Allow easy printing of patron's fines
by bugzilla-daemon＠bugs.koha-community.org 20 Sep '22

20 Sep '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12285 ByWater Sandboxes <bws.sandboxes(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139038|0 |1 is obsolete| | --- Comment #42 from ByWater Sandboxes <bws.sandboxes(a)gmail.com> --- Created attachment 140796 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140796&action=e… Bug 12285: Fix QA issues This patch: - removes GetBorrowerFines and reworks Fineslip to use Koha objects - adds the new notice template in the translated sample_notices.sql files - adds unit tests Sponsored-by: Koha-Suomi Oy Signed-off-by: Owen Leonard <oleonard(a)myacpl.org> Signed-off-by: Lisette Scheer <lisettePalouse+Koha(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12285] Allow easy printing of patron's fines
by bugzilla-daemon＠bugs.koha-community.org 20 Sep '22

20 Sep '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12285 ByWater Sandboxes <bws.sandboxes(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139037|0 |1 is obsolete| | --- Comment #41 from ByWater Sandboxes <bws.sandboxes(a)gmail.com> --- Created attachment 140795 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140795&action=e… Bug 12285: Allow easy printing of patron's fines. Add a printing option to the staff client patron details page to print a slip of patron's fines. To test: 1) Apply patch. 2) Check in tools > Notices & Slips that you have FINESLIP slip, and a print message there. If not, run updatedatabase.pl 3) Either create some fines for a patron, or look up a patron with existing fines. 4) From that patron's detail page, and the Print-menu in the toolbar, select "Print fines" 5) You should get a slip of the patron's fines. I removed superfluous $ signs in sample_notices.sql and updatedatabase.pl Patch works now as expected. However, it needs now a Sign-off by somebody else. Signed-off-by: Aleisha <aleishaamohia(a)hotmail.com> Rebased-by: Emmi Takkinen <emmi.takkinen(a)koha-suomi.fi> Signed-off-by: Owen Leonard <oleonard(a)myacpl.org> Signed-off-by: Lisette Scheer <lisettePalouse+Koha(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 31204] New: Edit dropdown on results.tt should indicate it is record modification
by bugzilla-daemon＠bugs.koha-community.org 20 Sep '22

20 Sep '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31204 Bug ID: 31204 Summary: Edit dropdown on results.tt should indicate it is record modification Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Tools Assignee: koha-bugs(a)lists.koha-community.org Reporter: lucas(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org On results.tt there is an option to select records and then, from the toolbar, select edit and choose either 'Batch edit' or 'Batch delete'. Some librarians have found this confusing, thinking it would lead them to 'Batch Item Modification' when instead it leads to 'Batch record modification'. We could make it less confusing by clearly indicating this function takes the user to record modification, not item modification. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 15