September 2022 - Koha-bugs - lists.koha-community.org

[Bug 12758] Failure when loading or parsing XSLT stylesheets over HTTPS
by bugzilla-daemon＠bugs.koha-community.org 20 Sep '22

20 Sep '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12758 --- Comment #33 from David Nind <david(a)davidnind.com> --- (In reply to Marcel de Rooy from comment #29) > Here is another (temporary) link. It works now and at least until monday: > https://prod-intra.rijkskoha.nl/bug12758.xsl > Use it for Results XSL. Thanks Marcel! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12758] Failure when loading or parsing XSLT stylesheets over HTTPS
by bugzilla-daemon＠bugs.koha-community.org 20 Sep '22

20 Sep '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12758 David Nind <david(a)davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138201|0 |1 is obsolete| | --- Comment #32 from David Nind <david(a)davidnind.com> --- Created attachment 140792 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140792&action=e… Bug 12758: Add new module call in Koha::XSLT::Base Reviving a report back from 2014. The workaround is now moved to a separate helper module from another patch. Test plan: Test OPACXSLTDetailsDisplay with an https reference. You may try: https://library.rijksmuseum.nl/opac-tmpl/bootstrap/en/xslt/zztest.xsl If you flush and restart, the opac detail pages will contain the text 'This is my MARC record.'. NOTE: If you point to an xslt file over https that contains includes or imports, you will still get the error: Failed to load external entity. To address that, we need to extend the _resolve_includes sub. Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> Signed-off-by: David Nind <david(a)davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12758] Failure when loading or parsing XSLT stylesheets over HTTPS
by bugzilla-daemon＠bugs.koha-community.org 20 Sep '22

20 Sep '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12758 David Nind <david(a)davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138200|0 |1 is obsolete| | --- Comment #31 from David Nind <david(a)davidnind.com> --- Created attachment 140791 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140791&action=e… Bug 12758: Introduce Koha::XSLT::HTTPS This module now fetches a https stylesheet and returns it as a string to Base. (As a workaround waiting for a real solution in the underlying libraries.) The module can be extended to resolve includes but this requires parsing the xslt code. Test plan: [1] Run t/Koha_XSLT_HTTPS.t Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> Signed-off-by: David Nind <david(a)davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12758] Failure when loading or parsing XSLT stylesheets over HTTPS
by bugzilla-daemon＠bugs.koha-community.org 20 Sep '22

20 Sep '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12758 David Nind <david(a)davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138199|0 |1 is obsolete| | --- Comment #30 from David Nind <david(a)davidnind.com> --- Created attachment 140790 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140790&action=e… Bug 12758: Make LWP::Protocol::https required module Moving from recommends to required in cpanfile. Reference info: Debian package liblwp-protocol-https-perl is available for Buster (6.07-2) and Bullseye (6.10-1). Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> Signed-off-by: David Nind <david(a)davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12758] Failure when loading or parsing XSLT stylesheets over HTTPS
by bugzilla-daemon＠bugs.koha-community.org 20 Sep '22

20 Sep '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12758 David Nind <david(a)davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12758] Failure when loading or parsing XSLT stylesheets over HTTPS
by bugzilla-daemon＠bugs.koha-community.org 20 Sep '22

20 Sep '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12758 --- Comment #29 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- (In reply to David Nind from comment #28) > I think that is because > https://library.rijksmuseum.nl/opac-tmpl/bootstrap/en/xslt/zztest.xsl is not > accessible Ah sorry. Yes that was probably gone with the wind :) Temporary file in a container that got replaced or so. Here is another (temporary) link. It works now and at least until monday: https://prod-intra.rijkskoha.nl/bug12758.xsl Use it for Results XSL. Showing something like this in results display: What a great title: Learning Perl / -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 31583] New: Improve formatting options of labels with UseACQFrameworkForBiblioRecords
by bugzilla-daemon＠bugs.koha-community.org 20 Sep '22

20 Sep '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31583 Bug ID: 31583 Summary: Improve formatting options of labels with UseACQFrameworkForBiblioRecords Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs(a)lists.koha-community.org Reporter: katrin.fischer(a)bsz-bw.de QA Contact: testopia(a)bugs.koha-community.org When UseACQFrameworkForBiblioRecords is used, the labels shown in front of the fields are in the format: Subfield description (TagSubfield) I think it would be nice to add the subfield separator or a space and also wrap the MARC information in a span with class so it can easily be formatted differently or the MARC information be removed. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 30308] New: bulkmarcimport.pl broken by OAI-PMH:AutoUpdateSets(EmbedItemData)
by bugzilla-daemon＠bugs.koha-community.org 19 Sep '22

19 Sep '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30308 Bug ID: 30308 Summary: bulkmarcimport.pl broken by OAI-PMH:AutoUpdateSets(EmbedItemData) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Command-line Utilities Assignee: koha-bugs(a)lists.koha-community.org Reporter: magnus(a)libriotech.no QA Contact: testopia(a)bugs.koha-community.org CC: robin(a)catalyst.net.nz I was trying to import records and items with bulkmarcimport.pl. The records were added, but no items were saved to the DB. Turning off OAI-PMH:AutoUpdateSets and OAI-PMH:AutoUpdateSetsEmbedItemData fixed the problem. I think this is what happens: 1. bulkmarcimport.pl calls C4::Biblio::AddBiblio on line 461: eval { ( $biblionumber, $biblioitemnumber ) = AddBiblio( $record, '', { defer_marc_save => 1 } ) }; https://git.koha-community.org/Koha-community/Koha/src/branch/master/misc/m… 2. C4::Biblio::AddBiblio has this code: # update OAI-PMH sets if(C4::Context->preference("OAI-PMH:AutoUpdateSets")) { C4::OAI::Sets::UpdateOAISetsBiblio($biblionumber, $record); } https://git.koha-community.org/Koha-community/Koha/src/branch/master/C4/Bib… 3. C4::OAI::Sets::UpdateOAISetsBiblio does this: if (C4::Context->preference('OAI-PMH:AutoUpdateSetsEmbedItemData')) { C4::Biblio::EmbedItemsInMarcBiblio({ marc_record => $record, biblionumber => $biblionumber }); } https://git.koha-community.org/Koha-community/Koha/src/branch/master/C4/OAI… 4. C4::Biblio::EmbedItemsInMarcBiblio does: my ($params) = @_; $marc = $params->{marc_record}; ... _strip_item_fields($marc, $frameworkcode); # ... and embed the current items my $dbh = C4::Context->dbh; my $sth = $dbh->prepare("SELECT itemnumber FROM items WHERE biblionumber = ?"); https://git.koha-community.org/Koha-community/Koha/src/branch/master/C4/Bib… The end result is that item data is stripped from the record that is about to be imported, and no item data is added from the DB, since they are not there yet. Not sure how to fix this. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 28

[Bug 31138] New: DataTables is not raising error to the end user
by bugzilla-daemon＠bugs.koha-community.org 19 Sep '22

19 Sep '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31138 Bug ID: 31138 Summary: DataTables is not raising error to the end user Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: major Priority: P5 - low Component: Staff Client Assignee: jonathan.druart+koha(a)gmail.com Reporter: jonathan.druart+koha(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com DataTables is not raising error to the end user, it's only displaying a generic message in the console. This leads to lot of questions on IRC or the mailing list ("the table is empty"). We can do better and display what went wrong. We could also imagine add a link to the wiki for the more common problems (won't be implemented here however). -- You are receiving this mail because: You are watching all bug changes.

1 18

[Bug 30458] New: Librarian ( manager_id ) not included in accountline when using "Payout amount" button
by bugzilla-daemon＠bugs.koha-community.org 19 Sep '22

19 Sep '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30458 Bug ID: 30458 Summary: Librarian ( manager_id ) not included in accountline when using "Payout amount" button Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Fines and fees Assignee: koha-bugs(a)lists.koha-community.org Reporter: kyle(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 20