September 2022 - Koha-bugs - lists.koha-community.org

[Bug 3150] Move emails for sending cart and list contents into notices tool
by bugzilla-daemon＠bugs.koha-community.org 07 Sep '22

07 Sep '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140247|0 |1 is obsolete| | --- Comment #117 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 140254 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140254&action=e… Bug 3150: (follow-up) HTML filtering TT notices and removing old files Signed-off-by: David Nind <david(a)davidnind.com> Signed-off-by: David Nind <david(a)davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 3150] Move emails for sending cart and list contents into notices tool
by bugzilla-daemon＠bugs.koha-community.org 07 Sep '22

07 Sep '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140246|0 |1 is obsolete| | --- Comment #116 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 140253 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140253&action=e… Bug 3150: Move emails for sending cart and list contents to notices This patch creates notices using Template Toolkit syntax for sending emails containing cart and list contents. To test: 1. Apply Bug 27266 2. Run update database and restart services 3. In the staff client, add multiple items to your cart and to a list 4. Go to your cart and click Send to email the contents 5. Add an email and a comment and click Send 6. Confirm the information shown in the success message is correct 7. In your terminal, log into the database. View the message queue ( i.e. select * from message_queue; ). Confirm that your email has been queued and the content is all correct. Confirm the cart contents has been included as an attachment. 8. Go to your list and click Send list to email the contents 9. Repeat steps 5-7 10. Log into the OPAC 11. Add multiple items to your cart and to a list 12. Repeat steps 4-9 13. By the end, you should have four emails in your message queue. All of the data about the items should be correct, they should all have attachments, and be addressed to the correct email address. Sponsored-by: Bibliotheksservice-Zentrum Baden-Württemberg (BSZ) Signed-off-by: David Nind <david(a)davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> Signed-off-by: David Nind <david(a)davidnind.com> Signed-off-by: David Nind <david(a)davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 3150] Move emails for sending cart and list contents into notices tool
by bugzilla-daemon＠bugs.koha-community.org 07 Sep '22

07 Sep '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 --- Comment #115 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 140252 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140252&action=e… Bug 3150: (QA follow-up) Remove borrowernumber from EnqueueLetter -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 3150] Move emails for sending cart and list contents into notices tool
by bugzilla-daemon＠bugs.koha-community.org 07 Sep '22

07 Sep '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137878|0 |1 is obsolete| | --- Comment #114 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 140251 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140251&action=e… Bug 3150: (follow-up) Fix .yml formatting FAIL yaml_valid YAML::XS::Load Error: The problem: did not find expected key was found at document: 1, line: 1748, column: 1 while parsing a block mapping at line: 23, column: 1 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 3150] Move emails for sending cart and list contents into notices tool
by bugzilla-daemon＠bugs.koha-community.org 07 Sep '22

07 Sep '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137720|0 |1 is obsolete| | --- Comment #113 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 140250 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140250&action=e… Bug 3150: (follow-up) Fixing errors and notices Signed-off-by: David Nind <david(a)davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 3150] Move emails for sending cart and list contents into notices tool
by bugzilla-daemon＠bugs.koha-community.org 07 Sep '22

07 Sep '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137719|0 |1 is obsolete| | --- Comment #112 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 140249 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140249&action=e… Bug 3150: (follow-up) Add missing bracket Signed-off-by: David Nind <david(a)davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 3150] Move emails for sending cart and list contents into notices tool
by bugzilla-daemon＠bugs.koha-community.org 07 Sep '22

07 Sep '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137718|0 |1 is obsolete| | --- Comment #111 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 140248 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140248&action=e… Bug 3150: (follow-up) Reformat notices, don't send if no sender email This patch reformats the notices so that the is_html flag is disabled and the notices display better It also throws an error if trying to send an email but the logged in borrower has no valid email address. Signed-off-by: David Nind <david(a)davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 3150] Move emails for sending cart and list contents into notices tool
by bugzilla-daemon＠bugs.koha-community.org 07 Sep '22

07 Sep '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137717|0 |1 is obsolete| | --- Comment #110 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 140247 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140247&action=e… Bug 3150: (follow-up) HTML filtering TT notices and removing old files Signed-off-by: David Nind <david(a)davidnind.com> Signed-off-by: David Nind <david(a)davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 3150] Move emails for sending cart and list contents into notices tool
by bugzilla-daemon＠bugs.koha-community.org 07 Sep '22

07 Sep '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137716|0 |1 is obsolete| | --- Comment #109 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 140246 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140246&action=e… Bug 3150: Move emails for sending cart and list contents to notices This patch creates notices using Template Toolkit syntax for sending emails containing cart and list contents. To test: 1. Apply Bug 27266 2. Run update database and restart services 3. In the staff client, add multiple items to your cart and to a list 4. Go to your cart and click Send to email the contents 5. Add an email and a comment and click Send 6. Confirm the information shown in the success message is correct 7. In your terminal, log into the database. View the message queue ( i.e. select * from message_queue; ). Confirm that your email has been queued and the content is all correct. Confirm the cart contents has been included as an attachment. 8. Go to your list and click Send list to email the contents 9. Repeat steps 5-7 10. Log into the OPAC 11. Add multiple items to your cart and to a list 12. Repeat steps 4-9 13. By the end, you should have four emails in your message queue. All of the data about the items should be correct, they should all have attachments, and be addressed to the correct email address. Sponsored-by: Bibliotheksservice-Zentrum Baden-Württemberg (BSZ) Signed-off-by: David Nind <david(a)davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> Signed-off-by: David Nind <david(a)davidnind.com> Signed-off-by: David Nind <david(a)davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 3150] Move emails for sending cart and list contents into notices tool
by bugzilla-daemon＠bugs.koha-community.org 07 Sep '22

07 Sep '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 --- Comment #108 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Agree with Katrin.. I'm not close enough to this code to do the rebase.. not sure what's changed to cause the conflict so unpicking the diff is challenging. -- You are receiving this mail because: You are watching all bug changes.

1 0