September 2022 - Koha-bugs - lists.koha-community.org

[Bug 3150] Move emails for sending cart and list contents into notices tool
by bugzilla-daemon＠bugs.koha-community.org 07 Sep '22

07 Sep '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 --- Comment #107 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Comment on attachment 137716 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137716 Bug 3150: Move emails for sending cart and list contents to notices Review of attachment 137716: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=315…) ----------------------------------------------------------------- ::: basket/sendbasket.pl @@ +101,5 @@ > + my $user_email = $patron->first_valid_email_address || C4::Context->preference('KohaAdminEmailAddress'); > + C4::Letters::EnqueueLetter({ > + letter => $letter, > + message_transport_type => 'email', > + borrowernumber => $patron->borrowernumber, I'm not sure we should be setting borrowernumber here.. it's somewhat misleading as the notice will appear as being sent to this borrower under their notices.. we don't really have the directionality in the UI to clearly show if a message was inbound or outbound so I don't know that it should be tied to the user here. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 3150] Move emails for sending cart and list contents into notices tool
by bugzilla-daemon＠bugs.koha-community.org 07 Sep '22

07 Sep '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 --- Comment #106 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- (In reply to Katrin Fischer from comment #80) > I think I have confused it with another thing we did a while ago as an > anti-Spam measure (bug 24588) > > I am not sure if it has to do with the from address, but there are other > notices we send or potentially send from KohaAdminEmailAddress, like the > cart emails. > > Martin, as you pointed it out, do we need to keep (and maybe move to a > separate report to make it consistent) or can we drop that here? I think we can probably drop it actually.. I can't find anywhere in the wider world that recognises that header at all. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 23342] New: Branch Transfer Limits branch_transfer_limits.pl DBI to Koha::Object, fix variable semantics
by bugzilla-daemon＠bugs.koha-community.org 07 Sep '22

07 Sep '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23342 Bug ID: 23342 Summary: Branch Transfer Limits branch_transfer_limits.pl DBI to Koha::Object, fix variable semantics Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: olli-antti.kivilahti(a)hypernova.fi QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com branch_transfer_limits.pl uses DBI SQL statements in the controller. Replace those with Koha::Objects. change branchcode to fromBranch to clarify what is the purpose of the branchcode. Prepare for more BranchTransferLimit authorised value limiting types. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 10

[Bug 7960] Choice to not show the text labels for item types
by bugzilla-daemon＠bugs.koha-community.org 06 Sep '22

06 Sep '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7960 David Nind <david(a)davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement adds the release notes| |class "itypetext" around | |item type descriptions so | |they can be hidden with | |CSS. To hide the | |descriptions, add | |.itypetext { display:none; | |} to the OPACUserCSS (for | |the OPAC) or | |IntranetUserCSS (for the | |staff interface) system | |preferences. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7960] Choice to not show the text labels for item types
by bugzilla-daemon＠bugs.koha-community.org 06 Sep '22

06 Sep '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7960 David Nind <david(a)davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140217|0 |1 is obsolete| | --- Comment #26 from David Nind <david(a)davidnind.com> --- Created attachment 140237 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140237&action=e… Bug 7960: Add class to item type descriptions so they can be hidden with CSS This patch adds the class "itypetext" around item type descriptions so they can easily be hidden with CSS. To test: 1. Navigate to the pages listed below to confirm that the text descriptions do show. 2. Add .itypetext { display:none; } to IntranetUserCSS and OPACUserCSS system preferences and save. 3. Go back to the pages listed below and confirm that the text descriptions DO NOT show. = STAFF CLIENT = - catalogue/advsearch.tt - catalogue/detail.tt - catalogue/results.tt - reserve/request.tt - virtualshelves/shelves.tt = OPAC = - opac-advsearch.tt - opac-detail.tt - opac-readingrecord.tt - opac-reserve.tt - opac-shelves.tt - opac-user.tt Refer to David Nind's test notes from Comment 23 for a more detailed plan for acessing these pages. Sponsored-by: Catalyst IT Signed-off-by: Charles Farmer <charles.farmer(a)inLibro.com> Signed-off-by: David Nind <david(a)davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7960] Choice to not show the text labels for item types
by bugzilla-daemon＠bugs.koha-community.org 06 Sep '22

06 Sep '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7960 David Nind <david(a)davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 31522] New: Koha::Email does not like non-ASCII in name part of email address
by bugzilla-daemon＠bugs.koha-community.org 06 Sep '22

06 Sep '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31522 Bug ID: 31522 Summary: Koha::Email does not like non-ASCII in name part of email address Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: m.de.rooy(a)rijksmuseum.nl QA Contact: testopia(a)bugs.koha-community.org Trying to use address like 'Michèlle <ascii(a)email.com>' makes Koha::Email raise an exception. This comes from Email::Valid and provides the following reason: rfc822 Replacing the è with e resolves the check. Note that this RFC was already obsoleted in ... 2001 ! Is this normal, major or ? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 7

[Bug 12758] Failure when loading or parsing XSLT stylesheets over HTTPS
by bugzilla-daemon＠bugs.koha-community.org 06 Sep '22

06 Sep '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12758 --- Comment #26 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- (In reply to Marcel de Rooy from comment #25) > (In reply to Lucas Gass from comment #20) > > Marcel, > > > > Is this ready for testing? > > Lukas, the current patches can be tested. They will only resolve pure https > references without includes or imports. > That would need further work and could be done on a new report? Ping Lucas -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 31501] New: After upgrading to 22.05, I am not able to search Patrons.
by bugzilla-daemon＠bugs.koha-community.org 06 Sep '22

06 Sep '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31501 Bug ID: 31501 Summary: After upgrading to 22.05, I am not able to search Patrons. Change sponsored?: --- Product: Koha Version: 22.05 Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Patrons Assignee: koha-bugs(a)lists.koha-community.org Reporter: liny(a)cusat.ac.in QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com Created attachment 140011 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140011&action=e… Patron are not displaying here After upgrading to 22.05, I am not able to search Patrons. It says Processing. But no results or errors are coming. Log file also has no information. if I give a cardnumber in search box its redirecting to that patrons page directly. But if there are more one result, it shows nothing in datatable. Please help -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 13

[Bug 7960] Choice to not show the text labels for item types
by bugzilla-daemon＠bugs.koha-community.org 06 Sep '22

06 Sep '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7960 --- Comment #25 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Have rebased and addressed: (In reply to David Nind from comment #23) > I've tested, but haven't signed off. > > 3. For the staff interface and with the CSS to hide the text description: > . catalogue/detail.tt: see note for staff interface and > catalogue/detail.tt - can't hide text description for 'Itemtype' shown on > the details page before the holdings tab > Fixed this > 4. For the OPAC, I'm not sure how to test opac-results-grouped.tt: there is > no opac-results-grouped.tt file, item type icon and text show for normal > OPAC search results when OPACnoItemTypeImages system preference is set to > 'Show', with OPAC CSS to hide no text description is shown in search results > (but icon is). > >From an old version of Koha, have removed this from the test plan -- You are receiving this mail because: You are watching all bug changes.

1 0