January 2023 - Koha-bugs - lists.koha-community.org

[Bug 11844] Additional fields for order lines
by bugzilla-daemon＠bugs.koha-community.org 20 Jan '23

20 Jan '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 --- Comment #48 from Julian Maurice <julian.maurice(a)biblibre.com> --- Created attachment 145540 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145540&action=e… Bug 11844: Fix QA issues (POD, TT filters, file exec flag) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11844] Additional fields for order lines
by bugzilla-daemon＠bugs.koha-community.org 20 Jan '23

20 Jan '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 --- Comment #47 from Julian Maurice <julian.maurice(a)biblibre.com> --- Created attachment 145536 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145536&action=e… Bug 11844: Take into account itemtypes, branches, and cn_source MARC subfields can be linked to "authorised values" that are not real authorised values: itemtypes, branches, and cn_source. Those were not taken into account. This patch fixes that Test plan: 1. Create additional fields for order lines with a MARC subfield that is linked to one of those "fake" authorised values list 2. Follow the same steps as in the main test plan -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11844] Additional fields for order lines
by bugzilla-daemon＠bugs.koha-community.org 20 Jan '23

20 Jan '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145517|0 |1 is obsolete| | --- Comment #46 from Julian Maurice <julian.maurice(a)biblibre.com> --- Created attachment 145535 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145535&action=e… Bug 11844: Use additional fields for order lines This patch allows to create additional fields for order lines. Once created, these fields can be filled during order line creation or modification. If additional field is linked to a MARC field, there are two possible scenario: - MARC field mode = get: The field cannot be modified and its value is retrieved from the bibliographic record (current behaviour) - MARC field mode = set: The field can be modified and its value is saved to the bibliographic record (new behaviour) If additional field is linked to an authorised value category, then authorised values are used. If not directly linked to an authorised value category, but linked to a MARC field, a search for an AV category is made on MARC default framework. This patch doesn't display additional fields value anywhere (except in order line creation/modification). Future patches will do that. Test plan: 1/ Go to Acquisitions home 2/ In the left menu, click on "Add order line fields" 3/ Click on "New field" button 4/ Give the field a name (unique), no AV category and no MARC field. 5/ Save. 6/ Create 5 other fields: a/ no AV category, a MARC field not linked to AV category, MARC field mode = get b/ no AV category, a MARC field not linked to AV category, MARC field mode = set c/ no AV category, a MARC field linked to AV category, MARC field mode = get d/ no AV category, a MARC field linked to AV category, MARC field mode = set e/ an AV category, no MARC field 7/ Create everything you need to be able to create order lines (supplier, basket, ...) 8/ Create an order line. At bottom of the page, you should see your additional fields, with authorised values dropdrown list for fields (c), (d) and (e). Fields (a) and (c) should be disabled. 9/ Fill these fields with some data and save order line 10/ check that data was correctly saved into biblio for fields (b) and (d), but not for (a) and (c) 11/ modify the same order line, check that values you've filled are correctly retrieved and that values for (a) and (c) were correctly retrieved from the bibliographic record 12/ modify all values, save, and check biblio once again Signed-off-by: Harold Dramer <harold.dramer(a)nyls.edu> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14341] XSLT 773$x
by bugzilla-daemon＠bugs.koha-community.org 20 Jan '23

20 Jan '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14341 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=16522 --- Comment #4 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Might make sense to do this after bug 16522 is pushed as it moves the 773 XSLT template into the Utils files, so only 2 spots will need updating. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11844] Additional fields for order lines
by bugzilla-daemon＠bugs.koha-community.org 20 Jan '23

20 Jan '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 --- Comment #45 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- I rebased, there are also some not too hard looking QA script fails: FAIL Koha/AdditionalField.pm FAIL pod coverage POD is missing for 'effective_authorised_value_category' OK Koha/Object/Mixin/AdditionalFields.pm OK Koha/Schema/Result/Aqorder.pm OK acqui/addorder.pl OK acqui/neworderempty.pl OK admin/additional-fields.pl FAIL installer/data/mysql/atomicupdate/bug-11844.pl FAIL file permissions File must have the exec flag OK installer/data/mysql/kohastructure.sql FAIL koha-tmpl/intranet-tmpl/prog/en/includes/additional-fields-entry.inc FAIL filters missing_filter at line 35 ( This value will be saved to the [% field.marcfield %] subfield of the selected biblio.) OK koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty.tt FAIL koha-tmpl/intranet-tmpl/prog/en/modules/admin/additional-fields.tt FAIL forbidden patterns forbidden pattern: trailing space char (line 127) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11844] Additional fields for order lines
by bugzilla-daemon＠bugs.koha-community.org 20 Jan '23

20 Jan '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141116|0 |1 is obsolete| | --- Comment #44 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 145517 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145517&action=e… Bug 11844: Use additional fields for order lines This patch allows to create additional fields for order lines. Once created, these fields can be filled during order line creation or modification. If additional field is linked to a MARC field, there are two possible scenario: - MARC field mode = get: The field cannot be modified and its value is retrieved from the bibliographic record (current behaviour) - MARC field mode = set: The field can be modified and its value is saved to the bibliographic record (new behaviour) If additional field is linked to an authorised value category, then authorised values are used. If not directly linked to an authorised value category, but linked to a MARC field, a search for an AV category is made on MARC default framework. This patch doesn't display additional fields value anywhere (except in order line creation/modification). Future patches will do that. Test plan: 1/ Go to Acquisitions home 2/ In the left menu, click on "Add order line fields" 3/ Click on "New field" button 4/ Give the field a name (unique), no AV category and no MARC field. 5/ Save. 6/ Create 5 other fields: a/ no AV category, a MARC field not linked to AV category, MARC field mode = get b/ no AV category, a MARC field not linked to AV category, MARC field mode = set c/ no AV category, a MARC field linked to AV category, MARC field mode = get d/ no AV category, a MARC field linked to AV category, MARC field mode = set e/ an AV category, no MARC field 7/ Create everything you need to be able to create order lines (supplier, basket, ...) 8/ Create an order line. At bottom of the page, you should see your additional fields, with authorised values dropdrown list for fields (c), (d) and (e). Fields (a) and (c) should be disabled. 9/ Fill these fields with some data and save order line 10/ check that data was correctly saved into biblio for fields (b) and (d), but not for (a) and (c) 11/ modify the same order line, check that values you've filled are correctly retrieved and that values for (a) and (c) were correctly retrieved from the bibliographic record 12/ modify all values, save, and check biblio once again Signed-off-by: Harold Dramer <harold.dramer(a)nyls.edu> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 31954] New: Patron search has no h1 heading
by bugzilla-daemon＠bugs.koha-community.org 20 Jan '23

20 Jan '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31954 Bug ID: 31954 Summary: Patron search has no h1 heading Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: katrin.fischer(a)bsz-bw.de QA Contact: testopia(a)bugs.koha-community.org For accessibility every page should have an h1 level heading and have a clear hierarchical structure of headings. Patron search only has 2 h3 headings. -- You are receiving this mail because: You are watching all bug changes.

1 9

[Bug 32480] New: Specify module and action of action_logs entries to purge
by bugzilla-daemon＠bugs.koha-community.org 20 Jan '23

20 Jan '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32480 Bug ID: 32480 Summary: Specify module and action of action_logs entries to purge Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Command-line Utilities Assignee: koha-bugs(a)lists.koha-community.org Reporter: alexbuckley(a)catalyst.net.nz QA Contact: testopia(a)bugs.koha-community.org CC: robin(a)catalyst.net.nz It would be helpful if libraries had the following action_logs purging behaviour: - Be able to specify the module and action of action_logs entries they would like to purge. Use case: Libraries with a patron import overwriting patron records several times a day will likely want to truncate member 'create' entries from the action_logs tables, whilst retaining other patron action_logs entries. - Be able to specify a different number of days for purging different modules. Use case: The library with the patron import may want to purge member 'create' action logs older than 30 days, but purge all other logs older than 365 days. We think this could be accomplished by adding a separate script for purging action_logs: ./purge_logs.pl --module MEMBERS --action CREATE --days 30 ./purge_logs.pl --module all --action all --days 365 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 5

[Bug 23979] New: "Account is locked" message on moremember.pl should be displayed on the "Check out" tab in addition to the "Details" tab
by bugzilla-daemon＠bugs.koha-community.org 20 Jan '23

20 Jan '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23979 Bug ID: 23979 Summary: "Account is locked" message on moremember.pl should be displayed on the "Check out" tab in addition to the "Details" tab Change sponsored?: --- Product: Koha Version: 19.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: george(a)nekls.org QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com Bug 21311 removes the "This account has been locked!" message from the OPAC when a patron account has been locked because someone has attempted to log into that account with an incorrect password more than the number of times specified by the system preference FailedLoginAttempts. This means that a patron may not know that their account has been locked if someone other than themselves has attempted to hack their account. Bug 21312 adds an "Account is locked" message on the patron's "Details" tab when a patron has locked their account by logging in with an incorrect password more than the number of times specified by the system preference FailedLoginAttempts. Most public library staff access a patron's account through the "Check out" tool which takes them directly to the "Check out" tab on the patron's account rather than the "Details" tab. The "Check out" tool is, after all, the default action of the header_search input box on the Koha home page. Having the "Account is locked" message only on the "Details" tab means that when a patron comes into the library and says "I don't understand why I can't get into my account" when staff look up the patron's account through "Check out", as they normally do, they have to take the extra step of switching to the "Details" tab to find out that the "Account is locked." The "Account is locked" message on moremember.pl should be displayed on the "Check out" tab in addition to the "Details" tab. George -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 24

[Bug 22854] New: Add separate column for administrative locked patron
by bugzilla-daemon＠bugs.koha-community.org 20 Jan '23

20 Jan '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22854 Bug ID: 22854 Summary: Add separate column for administrative locked patron Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs(a)lists.koha-community.org Reporter: m.de.rooy(a)rijksmuseum.nl QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com Target Milestone: --- See bug 21336. This is now arranged by using the same column login_attempts. login_attempts > pref_value means locked login_attempts < 0 means admin lock Do we need one or even two new columns? [1] locked: regular lock (resulting from entering wrong password), boolean replacing the check attempts > pref. Note that changing the pref might lock or unlock users now. Do we want that? [2] admin_locked: administrative lock, resulting from e.g. removing GDPR consent, boolean -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 5