October 2023 - Koha-bugs - lists.koha-community.org

[Bug 8367] How long is a hold waiting for pickup at a more granular level
by bugzilla-daemon＠bugs.koha-community.org 18 Oct '23

18 Oct '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 ByWater Sandboxes <bws.sandboxes(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #157147|0 |1 is obsolete| | --- Comment #278 from ByWater Sandboxes <bws.sandboxes(a)gmail.com> --- Created attachment 157352 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157352&action=e… Bug 8367: (QA follow-up) Improve display when value not set for rule When a rule is not set for a speficic line, the value in the syspref will be used. This should be made clear in the interface. To test: 1 - Add a new rule for a specific item type 2 - Do not fill the 'Hold pickup period' 3 - Confirm that the rule defaults to the system preference 4 - Hover on 'Default' in the circ rules under 'Hold pickup period' 5 - Confirm the text is readable Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> Signed-off-by: Kelly <kelly(a)bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> Signed-off-by: Kelly <kelly(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8367] How long is a hold waiting for pickup at a more granular level
by bugzilla-daemon＠bugs.koha-community.org 18 Oct '23

18 Oct '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 ByWater Sandboxes <bws.sandboxes(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #157146|0 |1 is obsolete| | --- Comment #277 from ByWater Sandboxes <bws.sandboxes(a)gmail.com> --- Created attachment 157351 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157351&action=e… Bug 8367: (QA follow-up) Update message on Hold waiting pickup report Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> https://bugs.koha-community.org/show_bug.cgi?id=8367 Signed-off-by: Kelly <kelly(a)bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> Signed-off-by: Kelly <kelly(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8367] How long is a hold waiting for pickup at a more granular level
by bugzilla-daemon＠bugs.koha-community.org 18 Oct '23

18 Oct '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 ByWater Sandboxes <bws.sandboxes(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #157145|0 |1 is obsolete| | --- Comment #276 from ByWater Sandboxes <bws.sandboxes(a)gmail.com> --- Created attachment 157350 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157350&action=e… Bug 8367: (follow-up) possible to delete circ rule Signed-off-by: Emmi Takkinen <emmi.takkinen(a)koha-suomi.fi> Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> Signed-off-by: Kelly <kelly(a)bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> Signed-off-by: Kelly <kelly(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8367] How long is a hold waiting for pickup at a more granular level
by bugzilla-daemon＠bugs.koha-community.org 18 Oct '23

18 Oct '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 ByWater Sandboxes <bws.sandboxes(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #157144|0 |1 is obsolete| | --- Comment #275 from ByWater Sandboxes <bws.sandboxes(a)gmail.com> --- Created attachment 157349 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157349&action=e… Bug 8367: (follow-up) Remove unnecessary code and atomic update Signed-off-by: Emmi Takkinen <emmi.takkinen(a)koha-suomi.fi> Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> Signed-off-by: Kelly <kelly(a)bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> Signed-off-by: Kelly <kelly(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8367] How long is a hold waiting for pickup at a more granular level
by bugzilla-daemon＠bugs.koha-community.org 18 Oct '23

18 Oct '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 ByWater Sandboxes <bws.sandboxes(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #157143|0 |1 is obsolete| | --- Comment #274 from ByWater Sandboxes <bws.sandboxes(a)gmail.com> --- Created attachment 157348 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157348&action=e… Bug 8367: (follow-up) Fix tests Signed-off-by: Emmi Takkinen <emmi.takkinen(a)koha-suomi.fi> Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> Signed-off-by: Kelly <kelly(a)bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> Signed-off-by: Kelly <kelly(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8367] How long is a hold waiting for pickup at a more granular level
by bugzilla-daemon＠bugs.koha-community.org 18 Oct '23

18 Oct '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 ByWater Sandboxes <bws.sandboxes(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #157142|0 |1 is obsolete| | --- Comment #273 from ByWater Sandboxes <bws.sandboxes(a)gmail.com> --- Created attachment 157347 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157347&action=e… Bug 8367: (follow-up) Remove pickup delay message from OPAC It adds unnecessary complexity and information. Signed-off-by: Emmi Takkinen <emmi.takkinen(a)koha-suomi.fi> Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> Signed-off-by: Kelly <kelly(a)bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> Signed-off-by: Kelly <kelly(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8367] How long is a hold waiting for pickup at a more granular level
by bugzilla-daemon＠bugs.koha-community.org 18 Oct '23

18 Oct '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 ByWater Sandboxes <bws.sandboxes(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #157141|0 |1 is obsolete| | --- Comment #272 from ByWater Sandboxes <bws.sandboxes(a)gmail.com> --- Created attachment 157346 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157346&action=e… Bug 8367: (follow-up) Fix pickup delay text on OPAC and other bits Signed-off-by: Emmi Takkinen <emmi.takkinen(a)koha-suomi.fi> Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> Signed-off-by: Kelly <kelly(a)bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> Signed-off-by: Kelly <kelly(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8367] How long is a hold waiting for pickup at a more granular level
by bugzilla-daemon＠bugs.koha-community.org 18 Oct '23

18 Oct '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 ByWater Sandboxes <bws.sandboxes(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #157140|0 |1 is obsolete| | --- Comment #271 from ByWater Sandboxes <bws.sandboxes(a)gmail.com> --- Created attachment 157345 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157345&action=e… Bug 8367: Make database update idempotent (across different MariaDB versions) The previous query seemed to work on MariaDB 10.1.48 (used by koha-testing-docker), but it didn't work on MariaDB 10.3.29 (default in Debian 10 as of this writing), but this patched query works on both indempotently. Signed-off-by: Emmi Takkinen <emmi.takkinen(a)koha-suomi.fi> Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> Signed-off-by: Kelly <kelly(a)bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> Signed-off-by: Kelly <kelly(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8367] How long is a hold waiting for pickup at a more granular level
by bugzilla-daemon＠bugs.koha-community.org 18 Oct '23

18 Oct '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 ByWater Sandboxes <bws.sandboxes(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #157139|0 |1 is obsolete| | --- Comment #270 from ByWater Sandboxes <bws.sandboxes(a)gmail.com> --- Created attachment 157344 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157344&action=e… Bug 8367: Make database update idempotent Signed-off-by: Emmi Takkinen <emmi.takkinen(a)koha-suomi.fi> Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> Signed-off-by: Kelly <kelly(a)bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> Signed-off-by: Kelly <kelly(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8367] How long is a hold waiting for pickup at a more granular level
by bugzilla-daemon＠bugs.koha-community.org 18 Oct '23

18 Oct '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 ByWater Sandboxes <bws.sandboxes(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #157138|0 |1 is obsolete| | --- Comment #269 from ByWater Sandboxes <bws.sandboxes(a)gmail.com> --- Created attachment 157343 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157343&action=e… Bug 8367: Add holds_pickup_period circulation rule So that pickup delay can have a different value per patron category, item type or branch. To test: 1) Update database, restart services 2) Set ReservesMaxPickUpDelay syspref (if not already set) 3) Edit your circulation rules and set a value under 'Holds pickup period (day) that is DIFFERENT from ReservesMaxPickUpDelay. Set a few different numbers for different branches as well. 4) Place a hold on a biblio from the staff client. 5) Check in an item from that biblio and confirm the hold as waiting 6) Confirm the expiration date is calculated using the 'Holds pickup period' value instead of the ReservesMaxPickUpDelay syspref 7) Revert the waiting status and delete the hold 8) Re-place the hold on the biblio on the OPAC. Notice that when you change the pick up location, the number of days in the pickup message below the dropdown changes based on the circ rules. 9) Create a holiday with a date that will overlap with the 'Holds pickup period' 10) Check in an item from that biblio and confirm the hold as waiting 11) Confirm the expiration date is calculated using the 'Holds pickup period' value AND considers the special holiday 12) Confirm tests pass t/db_dependent/Holds/WaitingReserves.t 13) Test Talking Tech: 13a) Enable TalkingTechItivaPhoneNotification 13b) Go to Tools -> Notices & slips. Add content to the HOLD phone (itiva) notice. 13c) In your terminal, run perl /path/to/koha/misc/cronjobs/thirdparty/TalkingTech_itiva_outbound.pl -o ~/itiva.tmp -w 0 --type=RESERVE Sponsored-by: Catalyst IT Signed-off-by: Emmi Takkinen <emmi.takkinen(a)koha-suomi.fi> Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> Signed-off-by: Kelly <kelly(a)bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> Signed-off-by: Kelly <kelly(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0