October 2023 - Koha-bugs - lists.koha-community.org

[Bug 8367] How long is a hold waiting for pickup at a more granular level
by bugzilla-daemon＠bugs.koha-community.org 14 Oct '23

14 Oct '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153235|0 |1 is obsolete| | --- Comment #253 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 157138 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157138&action=e… Bug 8367: Add holds_pickup_period circulation rule So that pickup delay can have a different value per patron category, item type or branch. To test: 1) Update database, restart services 2) Set ReservesMaxPickUpDelay syspref (if not already set) 3) Edit your circulation rules and set a value under 'Holds pickup period (day) that is DIFFERENT from ReservesMaxPickUpDelay. Set a few different numbers for different branches as well. 4) Place a hold on a biblio from the staff client. 5) Check in an item from that biblio and confirm the hold as waiting 6) Confirm the expiration date is calculated using the 'Holds pickup period' value instead of the ReservesMaxPickUpDelay syspref 7) Revert the waiting status and delete the hold 8) Re-place the hold on the biblio on the OPAC. Notice that when you change the pick up location, the number of days in the pickup message below the dropdown changes based on the circ rules. 9) Create a holiday with a date that will overlap with the 'Holds pickup period' 10) Check in an item from that biblio and confirm the hold as waiting 11) Confirm the expiration date is calculated using the 'Holds pickup period' value AND considers the special holiday 12) Confirm tests pass t/db_dependent/Holds/WaitingReserves.t 13) Test Talking Tech: 13a) Enable TalkingTechItivaPhoneNotification 13b) Go to Tools -> Notices & slips. Add content to the HOLD phone (itiva) notice. 13c) In your terminal, run perl /path/to/koha/misc/cronjobs/thirdparty/TalkingTech_itiva_outbound.pl -o ~/itiva.tmp -w 0 --type=RESERVE Sponsored-by: Catalyst IT Signed-off-by: Emmi Takkinen <emmi.takkinen(a)koha-suomi.fi> Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> Signed-off-by: Kelly <kelly(a)bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8367] How long is a hold waiting for pickup at a more granular level
by bugzilla-daemon＠bugs.koha-community.org 14 Oct '23

14 Oct '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 34363] New: Clicking on Holds or Overdues on the patron summary on OPAC links you to Checkouts tab
by bugzilla-daemon＠bugs.koha-community.org 14 Oct '23

14 Oct '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34363 Bug ID: 34363 Summary: Clicking on Holds or Overdues on the patron summary on OPAC links you to Checkouts tab Change sponsored?: --- Product: Koha Version: 22.11 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard(a)myacpl.org Reporter: dch(a)interleaf.ie QA Contact: testopia(a)bugs.koha-community.org Since 22.11, the Holds nav links under User summary in the OPAC are linking to the Checkouts tab in the patron's account, not the Holds tab. The Overdues link is also linking to the Checkouts tab and not the Overdues tab. Login to library account User Summary Welcome, Fred Bloggs 4 checkouts 1 overdue 1 hold pending Regardless of which of the above links you click on it opens on Checked out tab -- You are receiving this mail because: You are watching all bug changes.

1 2

[Bug 34813] New: Passing empty array from pl result in empty string in tt
by bugzilla-daemon＠bugs.koha-community.org 14 Oct '23

14 Oct '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34813 Bug ID: 34813 Summary: Passing empty array from pl result in empty string in tt Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: jonathan.druart+koha(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org See https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155782 Back from holiday, might be a bit rusty, but this is a weird behaviour. If you send test => [] from pl, [% test %] will display an empty string, and [% test.size %] won't display 0 We may need to check some occurrences of % git grep '\.size == 0' **/*.tt **/*.inc -- You are receiving this mail because: You are watching all bug changes.

1 3

[Bug 32178] query parameters in check_api_auth lets anyone assume a user id
by bugzilla-daemon＠bugs.koha-community.org 14 Oct '23

14 Oct '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32178 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 34321] New: Tidy skeleton too
by bugzilla-daemon＠bugs.koha-community.org 14 Oct '23

14 Oct '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34321 Bug ID: 34321 Summary: Tidy skeleton too Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: m.de.rooy(a)rijksmuseum.nl QA Contact: testopia(a)bugs.koha-community.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 9

[Bug 33379] New: virtualshelfcontents.flag seems useless
by bugzilla-daemon＠bugs.koha-community.org 14 Oct '23

14 Oct '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33379 Bug ID: 33379 Summary: virtualshelfcontents.flag seems useless Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: jonathan.druart+koha(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org Looks like we should remove this column, it's not used. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 22

[Bug 34240] New: Add hint about having to use Koha-to-MARC mappings for Koha link in frameworks
by bugzilla-daemon＠bugs.koha-community.org 14 Oct '23

14 Oct '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34240 Bug ID: 34240 Summary: Add hint about having to use Koha-to-MARC mappings for Koha link in frameworks Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs(a)lists.koha-community.org Reporter: katrin.fischer(a)bsz-bw.de QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com When configuring subfields in bibliographic frameworks the 'Koha link' is on locked as you need to set it through Koha-to-MARC mappings. We should add a hint about that changed behavior. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 18

[Bug 34217] New: Add missing cypress tests for vendors in agreements and licenses
by bugzilla-daemon＠bugs.koha-community.org 14 Oct '23

14 Oct '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34217 Bug ID: 34217 Summary: Add missing cypress tests for vendors in agreements and licenses Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: ERM Assignee: jonathan.druart+koha(a)gmail.com Reporter: pedro.amorim(a)ptfs-europe.com CC: jonathan.druart+koha(a)gmail.com, jonathan.field(a)ptfs-europe.com, martin.renvoize(a)ptfs-europe.com, matt.blenkinsop(a)ptfs-europe.com, pedro.amorim(a)ptfs-europe.com Bug 34206 made it evident we are missing tests for vendors in agreements and licenses. -- You are receiving this mail because: You are watching all bug changes.

1 30

[Bug 34414] New: Remove DBD::Mock
by bugzilla-daemon＠bugs.koha-community.org 14 Oct '23

14 Oct '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34414 Bug ID: 34414 Summary: Remove DBD::Mock Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: m.de.rooy(a)rijksmuseum.nl QA Contact: testopia(a)bugs.koha-community.org Bug 33940 will remove t/Members/cardnumber.t that APPEARS to use a feature of DBD::Mock, i.e. filling $dbh->{mock_add_resultset}. But since the module is not loaded there (since ages), the whole thing is not even working! Simple illustration. Suppose you have borrower 50. Run update cardnumber='123456789' where borrowernumber=50; Now run t/Members/cardnumber.t not ok 3 - 123456789 is shorter than 10 # Failed test '123456789 is shorter than 10' # at t/Members/cardnumber.t line 36. # got: '1' # expected: '2' What happened? Instead of using the mocked empty set, checkcardnumber finds your 123456789 cardnumber in the database. Deception ! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 14