February 2023 - Koha-bugs - lists.koha-community.org

[Bug 3150] Move emails for sending cart and list contents into notices tool
by bugzilla-daemon＠bugs.koha-community.org 13 Feb '23

13 Feb '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145681|0 |1 is obsolete| | --- Comment #147 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Created attachment 146565 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146565&action=e… Bug 3150: (QA follow-up) Remove borrowernumber from EnqueueLetter Signed-off-by: David Nind <david(a)davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 3150] Move emails for sending cart and list contents into notices tool
by bugzilla-daemon＠bugs.koha-community.org 13 Feb '23

13 Feb '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145680|0 |1 is obsolete| | --- Comment #146 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Created attachment 146564 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146564&action=e… Bug 3150: (follow-up) Fixing errors and notices Signed-off-by: David Nind <david(a)davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 3150] Move emails for sending cart and list contents into notices tool
by bugzilla-daemon＠bugs.koha-community.org 13 Feb '23

13 Feb '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145679|0 |1 is obsolete| | --- Comment #145 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Created attachment 146563 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146563&action=e… Bug 3150: (follow-up) Add missing bracket Signed-off-by: David Nind <david(a)davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 3150] Move emails for sending cart and list contents into notices tool
by bugzilla-daemon＠bugs.koha-community.org 13 Feb '23

13 Feb '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145678|0 |1 is obsolete| | --- Comment #144 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Created attachment 146562 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146562&action=e… Bug 3150: (follow-up) Reformat notices, don't send if no sender email This patch reformats the notices so that the is_html flag is disabled and the notices display better It also throws an error if trying to send an email but the logged in borrower has no valid email address. Signed-off-by: David Nind <david(a)davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 3150] Move emails for sending cart and list contents into notices tool
by bugzilla-daemon＠bugs.koha-community.org 13 Feb '23

13 Feb '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145677|0 |1 is obsolete| | --- Comment #143 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Created attachment 146561 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146561&action=e… Bug 3150: (follow-up) HTML filtering TT notices and removing old files Signed-off-by: David Nind <david(a)davidnind.com> Signed-off-by: David Nind <david(a)davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 3150] Move emails for sending cart and list contents into notices tool
by bugzilla-daemon＠bugs.koha-community.org 13 Feb '23

13 Feb '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145676|0 |1 is obsolete| | --- Comment #142 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Created attachment 146560 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146560&action=e… Bug 3150: Move emails for sending cart and list contents to notices This patch creates notices using Template Toolkit syntax for sending emails containing cart and list contents. To test: 1. Apply Bug 27266 2. Run update database and restart services 3. In the staff client, add multiple items to your cart and to a list 4. Go to your cart and click Send to email the contents 5. Add an email and a comment and click Send 6. Confirm the information shown in the success message is correct 7. In your terminal, log into the database. View the message queue ( i.e. select * from message_queue; ). Confirm that your email has been queued and the content is all correct. Confirm the cart contents has been included as an attachment. 8. Go to your list and click Send list to email the contents 9. Repeat steps 5-7 10. Log into the OPAC 11. Add multiple items to your cart and to a list 12. Repeat steps 4-9 13. By the end, you should have four emails in your message queue. All of the data about the items should be correct, they should all have attachments, and be addressed to the correct email address. Sponsored-by: Bibliotheksservice-Zentrum Baden-Württemberg (BSZ) Signed-off-by: David Nind <david(a)davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> Signed-off-by: David Nind <david(a)davidnind.com> Signed-off-by: David Nind <david(a)davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 3150] Move emails for sending cart and list contents into notices tool
by bugzilla-daemon＠bugs.koha-community.org 13 Feb '23

13 Feb '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11844] Additional fields for order lines
by bugzilla-daemon＠bugs.koha-community.org 12 Feb '23

12 Feb '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia(a)bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11844] Additional fields for order lines
by bugzilla-daemon＠bugs.koha-community.org 12 Feb '23

12 Feb '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11844] Additional fields for order lines
by bugzilla-daemon＠bugs.koha-community.org 12 Feb '23

12 Feb '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Signed Off |Failed QA --- Comment #66 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- This generally looks great.. but there's a few last unit tests missing. Could we have some tests for the new Koha::AdditionalField::effective_authorised_value_category method please. I'm afraid I'm also not seeing any additions for the C4::Acquisition::TransferOrder changes either. Finally, the changes in Koha/Object/Mixin/AdditionalFields.pm don't appear to be tested either. Sorry Julian, this is great work and I wouldn't want it accidentally undone in a future change. Failing QA for now. -- You are receiving this mail because: You are watching all bug changes.

1 0