February 2023 - Koha-bugs - lists.koha-community.org

[Bug 21982] New: Circulation statistics wizard does not count deleted items
by bugzilla-daemon＠bugs.koha-community.org 06 Feb '23

06 Feb '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21982 Bug ID: 21982 Summary: Circulation statistics wizard does not count deleted items Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Reports Assignee: koha-bugs(a)lists.koha-community.org Reporter: caroline.cyr-la-rose(a)inlibro.com QA Contact: testopia(a)bugs.koha-community.org A client noticed that deleted items are not counted in circulation stats when using the statistics wizard. Here is the test plan: 1) Search the catalog for a record with an available item 2) Loan out that item to a user and return it 3) Go in Reports > Statistics wizards > Circulation 4) Fill in the form - Choose a period that includes today - Choose "Type" = Checkout - Choose Item type for both "Row" and "Column" 5) Leave the rest as is and click "Submit" 6) Note the quantity of loans for the itemtype of your item 7) Go back to your item and delete it 8) Go back to your report and refresh 9) Notice that the amount of loans is less than it was before It's not because the item is deleted that the loan didn't happen The wizard should look at both items and deleted_items to calculate the amount of circulation transactions. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 26

[Bug 14251] Allow use of CSS in discharge letter
by bugzilla-daemon＠bugs.koha-community.org 06 Feb '23

06 Feb '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14251 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |32892 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32892 [Bug 32892] Email template used when generating DISCHARGE PDF -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14251] Allow use of CSS in discharge letter
by bugzilla-daemon＠bugs.koha-community.org 06 Feb '23

06 Feb '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14251 --- Comment #27 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Created attachment 146297 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146297&action=e… Bug 14251: Add weasyprint dependency Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14251] Allow use of CSS in discharge letter
by bugzilla-daemon＠bugs.koha-community.org 06 Feb '23

06 Feb '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14251 --- Comment #26 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Created attachment 146296 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146296&action=e… Bug 14251: Add warning in about.pl for missing weasyprint To test: 1. Have weasyprint installed 2. Go to the About > System information page => SUCCESS: No warning about weasyprint 3. Uninstall weasyprint 4. Repeat 2 => SUCCESS: A warning is displayed and makes sense 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14251] Allow use of CSS in discharge letter
by bugzilla-daemon＠bugs.koha-community.org 06 Feb '23

06 Feb '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14251 --- Comment #25 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Created attachment 146295 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146295&action=e… Bug 14251: Allow use of CSS in discharge letter The discharge feature relies PDF::FromHTML which explicitly doesn't handle CSS [1]. This patch makes it use the `weasyprint` command-line tool to generate the PDF. This tool handles CSS correctly. To test: 1. Install weasyprint: $ apt install weasyprint 2. Add some style to your DISCHARGE letter. I used: <<today>> <h1>Discharge confirmation</h1> <p style="background-color: yellow;"><<branches.branchname>> certifies that the following borrower:<br> <<borrowers.firstname>> <<borrowers.surname>> (cardnumber: <<borrowers.cardnumber>>)<br> has returned all items.</p> 3. Have some non-latin chars on the patron name. I picked 'Henry Acevedo' and added 'Δοκιμή' as picked from bug 23589. Only to check no regressions. 4. Enable the 'UseDischarge' syspref 5. Go to Henry's detail page 6. Choose More > Discharge and Generate the discharge => SUCCESS: - Style is applied to the PDF - Greek characters are displayed correctly 7. Run the tests: $ kshell k$ prove -v t/db_dependent/Patron/Borrower_Discharge.t => SUCCESS: The rewritten tests pass! 8. Remove weasyprint: $ apt remove weasyprint 9. Repeat 7 => SUCCESS: Tests pass, relevant test is skipped because of missing weasyprint 10. Sign off :-D [1] https://metacpan.org/pod/PDF::FromHTML#CAVEATS -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14251] Allow use of CSS in discharge letter
by bugzilla-daemon＠bugs.koha-community.org 06 Feb '23

06 Feb '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14251 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146170|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14251] Allow use of CSS in discharge letter
by bugzilla-daemon＠bugs.koha-community.org 06 Feb '23

06 Feb '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14251 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146169|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14251] Allow use of CSS in discharge letter
by bugzilla-daemon＠bugs.koha-community.org 06 Feb '23

06 Feb '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14251 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146168|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14251] Allow use of CSS in discharge letter
by bugzilla-daemon＠bugs.koha-community.org 06 Feb '23

06 Feb '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14251 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 32793] New: import_patrons.pl typo in usage
by bugzilla-daemon＠bugs.koha-community.org 06 Feb '23

06 Feb '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32793 Bug ID: 32793 Summary: import_patrons.pl typo in usage Change sponsored?: --- Product: Koha Version: 22.11 Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Command-line Utilities Assignee: koha-bugs(a)lists.koha-community.org Reporter: pedro.amorim(a)ptfs-europe.com QA Contact: testopia(a)bugs.koha-community.org CC: robin(a)catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 16