March 2023 - Koha-bugs - lists.koha-community.org

[Bug 28975] New: Holds queue lists can show holds from all libraries even with IndependentBranches
by bugzilla-daemon＠bugs.koha-community.org 15 Mar '23

15 Mar '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28975 Bug ID: 28975 Summary: Holds queue lists can show holds from all libraries even with IndependentBranches Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: caroline.cyr-la-rose(a)inlibro.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com When using IndependentBranches, usually all branches are removed from the drop-down menus. But in the Holds Queue page, there is the possibility to choose "All branches". From there, you can see holds for patrons from other branches and even click on the names of the patrons to access their file and see their information (!!). To recreate : 1) Activate IndependentBranches, IndependentBranchesPatronModifications and IndependentBranchesTransfers 2) Create a staff user with limited permissions (NOT a superlibrarian), including holds permissions. Here are mine as an example - circulate (all) - catalogue - borrowers - delete_borrowers - edit_borrowers - reserveforothers (all) - reports (all) 3) Create (or make sure you already have) a patron in another branch (we'll call them patron X) 4) Place a hold for patron X on an available item from their own library 5) Run misc/cronjobs/holds/build_holds_queue.pl 6) Go to Circulation > Holds queue and make sure you can see the hold 7) Log in as your limited staff patron 8) Go to Circulation > Holds queue 9) In the drop-down menu, choose "All" and click Submit -- Patron X and their hold appear in the list 10) Click on patron X's name -- You can access patron X's file and see their information Superlibrarians should be able to select any library, but non-superlibrarians should only be able to select their own library from the drop-down menu. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 27

[Bug 32291] New: What is a library category?
by bugzilla-daemon＠bugs.koha-community.org 15 Mar '23

15 Mar '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32291 Bug ID: 32291 Summary: What is a library category? Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: katrin.fischer(a)bsz-bw.de QA Contact: testopia(a)bugs.koha-community.org Also noticed a while ago, while translating. The errors mention library categories repeatedly, but I didn't figure out how to trigger those messages or what they were referring to. What is a library category and how can you add one? The page is Administration > Libraries koha-tmpl/intranet-tmpl/prog/en/modules/admin/branches.tt [% CASE 'error_on_update_category' %] An error occurred when updating this library category. Perhaps it already exists. [% CASE 'error_on_insert_category' %] An error occurred when adding this library category. The categorycode might already exist. [% CASE 'error_on_delete_category' %] An error occurred when deleting this library category. Check the logs. [% CASE 'success_on_update_category' %] Library category updated successfully. [% CASE 'success_on_insert_category' %] Library category added successfully. [% CASE 'success_on_delete_category' %] Library category deleted successfully. [% CASE 'cannot_delete_category' %] This library category cannot be deleted. [% m.data.libraries_count | html %] libraries are still using it. -- You are receiving this mail because: You are watching all bug changes.

1 22

[Bug 31675] New: Remove packages from debian/control that are no longer used
by bugzilla-daemon＠bugs.koha-community.org 15 Mar '23

15 Mar '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31675 Bug ID: 31675 Summary: Remove packages from debian/control that are no longer used Change sponsored?: --- Product: Koha Version: 21.11 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: kyle(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org As far as I can tell, we are no longer using CGI::Session::Serialize::YAML or YAML::Syck, but they are still marked dependencies for the Debian package. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 15

[Bug 32037] New: Circulation module in action logs has bad links for deleted items
by bugzilla-daemon＠bugs.koha-community.org 15 Mar '23

15 Mar '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32037 Bug ID: 32037 Summary: Circulation module in action logs has bad links for deleted items Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Tools Assignee: koha-bugs(a)lists.koha-community.org Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org The action log viewer attempts to build links to items/biblios etc. These links are broken when the item is deleted We are fetching the object to determine link values, so we should simply display the info field when no object is found -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 15

[Bug 31881] New: Link in MARC view does not work
by bugzilla-daemon＠bugs.koha-community.org 15 Mar '23

15 Mar '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31881 Bug ID: 31881 Summary: Link in MARC view does not work Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: koha-bugs(a)lists.koha-community.org Reporter: fridolin.somers(a)biblibre.com QA Contact: testopia(a)bugs.koha-community.org CC: m.de.rooy(a)rijksmuseum.nl In framework a subfield can be defined with a link (with a search field). This create an hyperlink in MARC view. Currently the link does not work because search query contains 'field,phr:', which is useless since the link contains 'idx=field,phr' -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 17

[Bug 32016] New: Fix clear filter button behavior on parcel.pl
by bugzilla-daemon＠bugs.koha-community.org 15 Mar '23

15 Mar '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32016 Bug ID: 32016 Summary: Fix clear filter button behavior on parcel.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Acquisitions Assignee: koha-bugs(a)lists.koha-community.org Reporter: thibaud.guillot(a)biblibre.com QA Contact: testopia(a)bugs.koha-community.org Since 20.11, there is only one filter per column or one global filter on 'cgi-bin/koha/acqui/parcel.pl?invoiceid=X' when you want to receive shipments. With many shopping carts, it can be useful to filter by certain criteria, passed by column or/and by the "global" search input. But when we click receive and get redirected to 'cgi-bin/koha/acqui/orderreceive.pl?ordernumber=X&invoiceid=Y' after saving or canceling action, back to previous page, data table is still filtered but we cannot clear the input from the global search filter. There is a parameter for datatable which can be passed to false to avoid saving the state of the datatable but this is not a solution because it can be tedious to set again the desired filters. The problem is related to the fact that the state of the datatable is saved by a cookie, retrieved when loading this same datatable. But when initializing the "clear filter" button, the class disabled is added if the search is empty and the recovery of the cookie is not taken into account. This is a first correction proposal that I will submit and which corrects the problem on the other datatables which would have the same behavior. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 22

[Bug 32622] New: Auth.t failing on D8
by bugzilla-daemon＠bugs.koha-community.org 15 Mar '23

15 Mar '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32622 Bug ID: 32622 Summary: Auth.t failing on D8 Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: chris(a)bigballofwax.co.nz Reporter: jonathan.druart+koha(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org Caught by Jenkins 15:08:08 koha_1 | # Failed test 'While still logged in, relogin with another user' 15:08:08 koha_1 | # at t/db_dependent/Auth.t line 219. 15:08:08 koha_1 | # Looks like you planned 7 tests but ran 6. 15:08:08 koha_1 | # Looks like you failed 1 test of 6 run. 15:08:08 koha_1 | 15:08:08 koha_1 | # Failed test 'checkauth() tests' 15:08:08 koha_1 | # at t/db_dependent/Auth.t line 331. 15:08:08 koha_1 | Can't locate object method "mock" via package "0" (perhaps you forgot to load "0"?) at t/db_dependent/Auth.t line 176. The code is: t/db_dependent/Auth.t 175 my $mock2 = Test::MockModule->new('CGI') ->mock( 'request_method', 'POST' ) 176 ->mock( 'cookie', sub { return $sessionID; } ); # oversimplified.. It's caused by a version mismatch of Test::MockModule with D8, which does not have this commit: https://github.com/geofffranks/test-mockmodule/commit/fef9e742e45e2437e3449… We could remove the chaining, or... deactivate D8 builds, which should have been already done actually :) -- You are receiving this mail because: You are watching all bug changes.

1 18

[Bug 31873] New: Can't call method "safe_delete" on an undefined value at cataloguing/additem.pl
by bugzilla-daemon＠bugs.koha-community.org 15 Mar '23

15 Mar '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31873 Bug ID: 31873 Summary: Can't call method "safe_delete" on an undefined value at cataloguing/additem.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: m.de.rooy(a)rijksmuseum.nl QA Contact: testopia(a)bugs.koha-community.org Line 379 in 21.11. Line 415 in master now. my $item = Koha::Items->find($itemnumber); my $error = $item->safe_delete; No check whatsoever. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 18

[Bug 29458] New: Show login button consistently in relation to login instructions, reset and register links
by bugzilla-daemon＠bugs.koha-community.org 15 Mar '23

15 Mar '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29458 Bug ID: 29458 Summary: Show login button consistently in relation to login instructions, reset and register links Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: m.de.rooy(a)rijksmuseum.nl QA Contact: testopia(a)bugs.koha-community.org Modal form from masthead: Usercode Password Instructions Reset Register Login opac-auth (click Login from home page): Usercode Password Login Reset Instructions Register opac-main: Usercode Password Login Instructions Reset Register I would suggest to follow the pattern from the home page. After entering usercode and password, next step is normally click Login. Below that offer Instructions, Reset and Register. Do the same on modal and opac-auth. -- You are receiving this mail because: You are watching all bug changes.

1 36

[Bug 31086] New: Do not allow hold requests with no branchcode
by bugzilla-daemon＠bugs.koha-community.org 15 Mar '23

15 Mar '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31086 Bug ID: 31086 Summary: Do not allow hold requests with no branchcode Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Hold requests Assignee: koha-bugs(a)lists.koha-community.org Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com Holds require a branchcode, various code expects this, however, we do not enforce this requirement when saving holds -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 47