March 2023 - Koha-bugs - lists.koha-community.org

[Bug 8179] Receiving multiple order lines at once
by bugzilla-daemon＠bugs.koha-community.org 15 Mar '23

15 Mar '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179 Agustín Moyano <agustinmoyano(a)theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148218|0 |1 is obsolete| | --- Comment #93 from Agustín Moyano <agustinmoyano(a)theke.io> --- Created attachment 148233 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148233&action=e… Bug 8179: Receive multiple orders This patch implements the code to allow a patron to receive multiple orders at the same time in /cgi-bin/koha/acqui/orderreceive.pl page To test: 1. apply all patches 2. updatedatabase 3. Go to system preferences and allow AcqReceiveMultipleOrderLines 4. In acquisitions module, create a vendor if you don't have one and add 3 baskets.. one with create items on ordering, one with create items on receiving and finally one with create items when cataloguing 5. Fill baskets with orders (There should be at least 15 orders in total). There should be a mix of orders created by suggestions, others by subscriptions and others by neither of those methods. 6. Close all baskets and receive shipment. CHECK => in /cgi-bin/koha/acqui/parcel.pl page, in top table there is a column with checkboxes, and a button that says "Receive selected" 7. If all orders from all baskets are shown in the table, set the rows per page to 10, so table has more than one page 8. Check some of the checkboxes CHECK => "Receive selected" button shows how many rows are selected 9. Go to the next page and select some more rows CHECK => Changing page does not modify how many rows where selected 10. Go back to previous page CHECK => Previously selected rows are still selected 11. Reload the page to deselect all rows 12. Select only one row and click on "Receive selected" button CHECK => the page /cgi-bin/koha/acqui/orderreceive.pl behaves just the same as if the "receive" link in the selected row would have been clicked. 13. Click on cancel to go back to parcel.pl page 14. Select all rows (even the ones from the next page of the table) and click on "Receive selected" CHECH => In orderreceive.pl page there is a table with all selected rows 15. Ensure table has more than one page, as in step 7 16. Click on the "edit" link in the last row of the current page CHECK => A modal window is displayed with 4 tabs within: Info, Accounting, Receipt history and Items CHECK => Modal has 4 buttons at the bottom, 'Previous' to go to previos order, 'Cancel' to close the modal without keeping modifications, 'Save' to close modal keeping modifications and 'Next' to go to the next order CHECK => Even that we are at the end of the current page, 'Next' button is still available 17. Click on 'Next' button CHECK => The table behind the modal now displays the next page, and the modal was not closed 18. Click on 'Previous' CHECK => The table behind the modal went back to the first page, and the modal was not closed 19. Click on 'Previous' button till you reach the first row of the first page CHECK => Only when you reach the first row of the first page 'Previous' button gets disabled 20. Click on 'Next' button till you reach the last row of the last page CHECK => Only when you reach the last button of the last page 'Next' button gets disabled 21. Check that behaviour for the different types of order are still the same a. For orders that where created through suggestion, check that the suggestion info is present in Info tab. If when suggestion was accepted you set a reason, a dropdown to change the reason shoul display also. b. For orders that where created through subscriptions, check that the Items tab is disabled, and the Receipt history is enabled. On accounting tab you should be able to change quantity ordered. If there were less items received than ordered, the next time you receive this order the child order generated from this one shoul appear in receipt history. c. For orders that don't come from subscription and creates there items on ordering, Receipt history should be disabled, and a table with prefilled items shold appear in the Items tab. You can edit them and the changes should appear in the item's row. d. For orders that don't come from subscription and creates there items on receiving, Receipt history should be disabled, and a form to create the items should appear in Items tab. When you add an item a table should appear. e. For orders that don't come from subscription and creates there ites on cataloguing, Receipt history and Items tabs should be disabled. f. Any changes made in quantity (received or ordered) or funds in the modal should be reflected in the table if you click save from the modal. 22. Once you've done all you checking and verifications click save 23. While saving a progress bar should appear 24. If no error was detected, you should be redirected back to parcel.pl page 25. If an error or warning was detected (like there is an order with 0 items to receive) the save button should be disabled and warnings are dispayed. 26. prove t/db_dependent/Koha/Acquisition/Fund.t t/db_dependent/Koha/Acquisitoin/Order.t t/db_dependent/Koha/Item.t Sponsored-by: Virginia Polytechnic Institute and State University -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14251] Allow use of CSS in discharge letter
by bugzilla-daemon＠bugs.koha-community.org 15 Mar '23

15 Mar '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14251 --- Comment #36 from Kyle M Hall <kyle(a)bywatersolutions.com> --- > I don't remember exactly right now, but I recall wkhtmltopdf could use > weasyprint as backend, or latex. And the latter was like 800MB in > dependencies. Sounds like you are thinking of Pandoc (https://pandoc.org/) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14251] Allow use of CSS in discharge letter
by bugzilla-daemon＠bugs.koha-community.org 15 Mar '23

15 Mar '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14251 --- Comment #35 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- (In reply to Kyle M Hall from comment #34) > Just an FYI, weasyprint is not a very performant application. I recently > surveyed most available foss html to pdf options out there. I ended up using > wkhtmltopdf to generate 5000 page pdfs in under a minute each. I don't remember exactly right now, but I recall wkhtmltopdf could use weasyprint as backend, or latex. And the latter was like 800MB in dependencies. I agree we should move forward with this, and even centralize PDF generation in a class and make the v backend swappable until we find the perfect tool. I didn't know about chrome/chromium headless. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8179] Receiving multiple order lines at once
by bugzilla-daemon＠bugs.koha-community.org 15 Mar '23

15 Mar '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179 --- Comment #92 from Agustín Moyano <agustinmoyano(a)theke.io> --- Created attachment 148218 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148218&action=e… Bug 8179: Receive multiple orders This patch implements the code to allow a patron to receive multiple orders at the same time in /cgi-bin/koha/acqui/orderreceive.pl page To test: 1. apply all patches 2. updatedatabase 3. Go to system preferences and allow AcqReceiveMultipleOrderLines 4. In acquisitions module, create a vendor if you don't have one and add 3 baskets.. one with create items on ordering, one with create items on receiving and finally one with create items when cataloguing 5. Fill baskets with orders (There should be at least 15 orders in total). There should be a mix of orders created by suggestions, others by subscriptions and others by neither of those methods. 6. Close all baskets and receive shipment. CHECK => in /cgi-bin/koha/acqui/parcel.pl page, in top table there is a column with checkboxes, and a button that says "Receive selected" 7. If all orders from all baskets are shown in the table, set the rows per page to 10, so table has more than one page 8. Check some of the checkboxes CHECK => "Receive selected" button shows how many rows are selected 9. Go to the next page and select some more rows CHECK => Changing page does not modify how many rows where selected 10. Go back to previous page CHECK => Previously selected rows are still selected 11. Reload the page to deselect all rows 12. Select only one row and click on "Receive selected" button CHECK => the page /cgi-bin/koha/acqui/orderreceive.pl behaves just the same as if the "receive" link in the selected row would have been clicked. 13. Click on cancel to go back to parcel.pl page 14. Select all rows (even the ones from the next page of the table) and click on "Receive selected" CHECH => In orderreceive.pl page there is a table with all selected rows 15. Ensure table has more than one page, as in step 7 16. Click on the "edit" link in the last row of the current page CHECK => A modal window is displayed with 4 tabs within: Info, Accounting, Receipt history and Items CHECK => Modal has 4 buttons at the bottom, 'Previous' to go to previos order, 'Cancel' to close the modal without keeping modifications, 'Save' to close modal keeping modifications and 'Next' to go to the next order CHECK => Even that we are at the end of the current page, 'Next' button is still available 17. Click on 'Next' button CHECK => The table behind the modal now displays the next page, and the modal was not closed 18. Click on 'Previous' CHECK => The table behind the modal went back to the first page, and the modal was not closed 19. Click on 'Previous' button till you reach the first row of the first page CHECK => Only when you reach the first row of the first page 'Previous' button gets disabled 20. Click on 'Next' button till you reach the last row of the last page CHECK => Only when you reach the last button of the last page 'Next' button gets disabled 21. Check that behaviour for the different types of order are still the same a. For orders that where created through suggestion, check that the suggestion info is present in Info tab. If when suggestion was accepted you set a reason, a dropdown to change the reason shoul display also. b. For orders that where created through subscriptions, check that the Items tab is disabled, and the Receipt history is enabled. On accounting tab you should be able to change quantity ordered. If there were less items received than ordered, the next time you receive this order the child order generated from this one shoul appear in receipt history. c. For orders that don't come from subscription and creates there items on ordering, Receipt history should be disabled, and a table with prefilled items shold appear in the Items tab. You can edit them and the changes should appear in the item's row. d. For orders that don't come from subscription and creates there items on receiving, Receipt history should be disabled, and a form to create the items should appear in Items tab. When you add an item a table should appear. e. For orders that don't come from subscription and creates there ites on cataloguing, Receipt history and Items tabs should be disabled. f. Any changes made in quantity (received or ordered) or funds in the modal should be reflected in the table if you click save from the modal. 22. Once you've done all you checking and verifications click save 23. While saving a progress bar should appear 24. If no error was detected, you should be redirected back to parcel.pl page 25. If an error or warning was detected (like there is an order with 0 items to receive) the save button should be disabled and warnings are dispayed. 26. prove t/db_dependent/Koha/Acquisition/Fund.t t/db_dependent/Koha/Acquisitoin/Order.t t/db_dependent/Koha/Item.t Sponsored-by: Virginia Polytechnic Institute and State University -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8179] Receiving multiple order lines at once
by bugzilla-daemon＠bugs.koha-community.org 15 Mar '23

15 Mar '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179 --- Comment #91 from Agustín Moyano <agustinmoyano(a)theke.io> --- Created attachment 148217 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148217&action=e… Bug 8179: Add AcqReceiveMultipleOrderLines syspref to preference configuration This patch adds AcqReceiveMultipleOrderLines to koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/acquisitions.pref Sponsored-by: Virginia Polytechnic Institute and State University -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8179] Receiving multiple order lines at once
by bugzilla-daemon＠bugs.koha-community.org 15 Mar '23

15 Mar '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179 --- Comment #90 from Agustín Moyano <agustinmoyano(a)theke.io> --- Created attachment 148216 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148216&action=e… Bug 8179: Add syspref to database This patch adds the AcqReceiveMultipleOrderLines syspref by atomicupdate and in sysprefs.sql Sponsored-by: Virginia Polytechnic Institute and State University -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8179] Receiving multiple order lines at once
by bugzilla-daemon＠bugs.koha-community.org 15 Mar '23

15 Mar '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179 Agustín Moyano <agustinmoyano(a)theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120620|0 |1 is obsolete| | Attachment #120621|0 |1 is obsolete| | Attachment #120622|0 |1 is obsolete| | Attachment #120623|0 |1 is obsolete| | --- Comment #89 from Agustín Moyano <agustinmoyano(a)theke.io> --- Created attachment 148215 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148215&action=e… Bug 8179: Add tests This patch adds tests in: * t/db_dependent/Koha/Acquisition/Fund.t * t/db_dependent/Koha/Acquisitoin/Order.t * t/db_dependent/Koha/Item.t Sponsored-by: Virginia Polytechnic Institute and State University -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8179] Receiving multiple order lines at once
by bugzilla-daemon＠bugs.koha-community.org 15 Mar '23

15 Mar '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179 Agustín Moyano <agustinmoyano(a)theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14251] Allow use of CSS in discharge letter
by bugzilla-daemon＠bugs.koha-community.org 15 Mar '23

15 Mar '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14251 --- Comment #34 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Just an FYI, weasyprint is not a very performant application. I recently surveyed most available foss html to pdf options out there. I ended up using wkhtmltopdf to generate 5000 page pdfs in under a minute each. That being said, we are only generating a page or two with weasyprint so that shouldn't matter, and it appears that weasyprint is more actively maintained. Another option would be to use headless chrome (https://developer.chrome.com/blog/headless-chrome/) but I see no compelling reason to use that over weasyprint at this time. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14251] Allow use of CSS in discharge letter
by bugzilla-daemon＠bugs.koha-community.org 15 Mar '23

15 Mar '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14251 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

1 0