March 2023 - Koha-bugs - lists.koha-community.org

[Bug 32922] New: Remove space in shebang
by bugzilla-daemon＠bugs.koha-community.org 01 Mar '23

01 Mar '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32922 Bug ID: 32922 Summary: Remove space in shebang Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: magnus(a)libriotech.no QA Contact: testopia(a)bugs.koha-community.org Some of our scripts have a space in the shebang: $ grep -rn --include=*.pl '#! /usr/' * admin/library_groups.pl:1:#! /usr/bin/perl admin/credit_types.pl:1:#! /usr/bin/perl admin/debit_types.pl:1:#! /usr/bin/perl admin/curbside_pickup.pl:1:#! /usr/bin/perl admin/desks.pl:1:#! /usr/bin/perl admin/cities.pl:1:#! /usr/bin/perl admin/classsources.pl:1:#! /usr/bin/perl admin/matching-rules.pl:1:#! /usr/bin/perl admin/background_jobs.pl:1:#! /usr/bin/perl admin/patron-attr-types.pl:1:#! /usr/bin/perl circ/curbside_pickups.pl:1:#! /usr/bin/perl erm/erm.pl:1:#! /usr/bin/perl misc/cronjobs/delete_items.pl:1:#! /usr/bin/perl misc/maintenance/check_syspref_cache.pl:1:#! /usr/bin/perl misc/maintenance/compare_es_to_db.pl:1:#! /usr/bin/perl misc/add_statistics_borrowers_categorycode.pl:1:#! /usr/bin/perl It looks like this is not illegal (see e.g. https://unix.stackexchange.com/questions/276751/is-space-allowed-between-an…) but it has been argued that we should be consistent (bug 26658) so we might want to fix this. Unless there is some reason for it that I am not aware of? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 18

[Bug 32908] New: Item type icons broken in the bibliographic record details page
by bugzilla-daemon＠bugs.koha-community.org 01 Mar '23

01 Mar '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32908 Bug ID: 32908 Summary: Item type icons broken in the bibliographic record details page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Staff interface Assignee: koha-bugs(a)lists.koha-community.org Reporter: gveranis(a)dataly.gr QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com Created attachment 146386 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146386&action=e… Staff_Interface-Bibliographic_record_details-Item_type_icon_BROKEN In the Staff interface, the details page of a bibliographic record should display the icon associated with the item type of an item ('Item type' column in the 'Holdings' tab). This feature broke in v22.11.00 and is still broken [*] in the current master (539efac9aa), as the <img> tag for the item type icon points to a path that begins with: /opac-tmpl/bootstrap/itemtypeimg instead of the correct path that begins with: /intranet-tmpl/prog/img/itemtypeimg So, instead of fetching the corresponding item type icon you get a 404 in your web server logs and the default 'broken image URL' image in your web browser. I will attach a couple of screenshots to demonstrate the problem. `git bisect` tells me that the relevant commit is b686bd65e19a6688ebda109a156ea31576559e4f from Bug 31321. [*] Please note: the bug outlined above occurs on Debian package installations. Koha instances created using koha-testing-docker or the Koha Sandboxes seem to be unaffected. I believe this has to do with the values of the <intrahtdocs> and <opachtdocs> settings in koha-conf.xml, and the fact that Gitified instances served by Apache use the same DocumentRoot path in their VirtualHost directives for both the OPAC and the Staff interface. However, when trying to reproduce this bug on Koha instances created with methods other than a Debian package install, you can still observe that the item type icon URL is wrong by right-clicking on the icon and selecting 'Inspect' to see its properties. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 23

[Bug 11983] Code to select patrons to purge needs to be centralized (use of filter_by)
by bugzilla-daemon＠bugs.koha-community.org 01 Mar '23

01 Mar '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11983 Lucas Gass <lucas(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_22_05_candidate | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 17699] New: DateTime durations are not correctly subtracted
by bugzilla-daemon＠bugs.koha-community.org 01 Mar '23

01 Mar '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17699 Bug ID: 17699 Summary: DateTime durations are not correctly subtracted Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org Depends on: 16911 >From DateTime::Duration pod: """ For positive durations, the "end_of_month" parameter defaults to wrap. For negative durations, the default is "limit". This should match how most people "intuitively" expect datetime math to work. """ Today we are Nov 30, that means $today->subtract( months => 1 ) will return Oct 31, when we usually expect Oct 30 in tests Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16911 [Bug 16911] Koha::Patrons - Move ExtendMemberSubscriptionTo to ->renew_account -- You are receiving this mail because: You are watching all bug changes.

1 48

[Bug 32159] New: Uncertain prices has 2 level 1 headings
by bugzilla-daemon＠bugs.koha-community.org 01 Mar '23

01 Mar '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32159 Bug ID: 32159 Summary: Uncertain prices has 2 level 1 headings Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Keywords: Academy, accessibility Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: katrin.fischer(a)bsz-bw.de QA Contact: testopia(a)bugs.koha-community.org Instead of h1 - h2 - h2 we have 2 h1 headings with almost the same text on the uncertain prices page in acquisitions. -- You are receiving this mail because: You are watching all bug changes.

1 13