March 2023 - Koha-bugs - lists.koha-community.org

[Bug 3831] Add a warning/hint when FA framework is missing
by bugzilla-daemon＠bugs.koha-community.org 03 Mar '23

03 Mar '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3831 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 14251] Allow use of CSS in discharge letter
by bugzilla-daemon＠bugs.koha-community.org 03 Mar '23

03 Mar '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14251 --- Comment #33 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 147733 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147733&action=e… Bug 14251: Add weasyprint dependency Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> Signed-off-by: David Nind <david(a)davidnind.com> Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14251] Allow use of CSS in discharge letter
by bugzilla-daemon＠bugs.koha-community.org 03 Mar '23

03 Mar '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14251 --- Comment #32 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 147732 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147732&action=e… Bug 14251: Add warning in about.pl for missing weasyprint To test: 1. Have weasyprint installed 2. Go to the About > System information page => SUCCESS: No warning about weasyprint 3. Uninstall weasyprint 4. Repeat 2 => SUCCESS: A warning is displayed and makes sense 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> Signed-off-by: David Nind <david(a)davidnind.com> Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14251] Allow use of CSS in discharge letter
by bugzilla-daemon＠bugs.koha-community.org 03 Mar '23

03 Mar '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14251 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146310|0 |1 is obsolete| | Attachment #146311|0 |1 is obsolete| | Attachment #146312|0 |1 is obsolete| | --- Comment #31 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 147731 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147731&action=e… Bug 14251: Allow use of CSS in discharge letter The discharge feature relies PDF::FromHTML which explicitly doesn't handle CSS [1]. This patch makes it use the `weasyprint` command-line tool to generate the PDF. This tool handles CSS correctly. To test: 1. Install weasyprint: $ apt install weasyprint 2. Add some style to your DISCHARGE letter. I used: <<today>> <h1>Discharge confirmation</h1> <p style="background-color: yellow;"><<branches.branchname>> certifies that the following borrower:<br> <<borrowers.firstname>> <<borrowers.surname>> (cardnumber: <<borrowers.cardnumber>>)<br> has returned all items.</p> 3. Have some non-latin chars on the patron name. I picked 'Henry Acevedo' and added 'Δοκιμή' as picked from bug 23589. Only to check no regressions. 4. Enable the 'UseDischarge' syspref 5. Go to Henry's detail page 6. Choose More > Discharge and Generate the discharge => SUCCESS: - Style is applied to the PDF - Greek characters are displayed correctly 7. Run the tests: $ kshell k$ prove -v t/db_dependent/Patron/Borrower_Discharge.t => SUCCESS: The rewritten tests pass! 8. Remove weasyprint: $ apt remove weasyprint 9. Repeat 7 => SUCCESS: Tests pass, relevant test is skipped because of missing weasyprint 10. Sign off :-D [1] https://metacpan.org/pod/PDF::FromHTML#CAVEATS Signed-off-by: David Nind <david(a)davidnind.com> Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14251] Allow use of CSS in discharge letter
by bugzilla-daemon＠bugs.koha-community.org 03 Mar '23

03 Mar '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14251 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia(a)bugs.koha-communit |kyle(a)bywatersolutions.com |y.org | CC| |kyle(a)bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8290] Replace usage of Greybox modals with Bootstrap modals
by bugzilla-daemon＠bugs.koha-community.org 03 Mar '23

03 Mar '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8290 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|32333 | Depends on| |32333 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32333 [Bug 32333] IdRef system preference revamping -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15326] Add CMS feature
by bugzilla-daemon＠bugs.koha-community.org 03 Mar '23

03 Mar '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 --- Comment #192 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #191) > If I create a new page I see: > > idnew | category | code | location > 5 | pages | staff_and_opac_5 | staff_and_opac > > Why is the code "staff_and_opac_5"? Shouldn't it be "pages_5" instead? It would have been better, yes. But I actually would like to change it to an 'alias' of my choice anyway. There should be several reports in that direction already. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15326] Add CMS feature
by bugzilla-daemon＠bugs.koha-community.org 03 Mar '23

03 Mar '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 --- Comment #191 from Jonathan Druart <jonathan.druart+koha(a)gmail.com> --- If I create a new page I see: idnew | category | code | location 5 | pages | staff_and_opac_5 | staff_and_opac Why is the code "staff_and_opac_5"? Shouldn't it be "pages_5" instead? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 21361] New: Attributes appear in different order on batch patrons modifications
by bugzilla-daemon＠bugs.koha-community.org 02 Mar '23

02 Mar '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21361 Bug ID: 21361 Summary: Attributes appear in different order on batch patrons modifications Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs(a)lists.koha-community.org Reporter: severine.queune(a)bulac.fr QA Contact: testopia(a)bugs.koha-community.org Created attachment 78954 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78954&action=ed… Attribute display for the first batch modification When different patrons attributes exist, their order is different for each new batch modifictation on page /cgi-bin/koha/tools/modborrowers.pl See the 2 screenshots attached. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 3

[Bug 31343] New: DataTables error on waitingreserves.tt
by bugzilla-daemon＠bugs.koha-community.org 02 Mar '23

02 Mar '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31343 Bug ID: 31343 Summary: DataTables error on waitingreserves.tt Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: lucas(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com To recreate: 1. Have some waiting holds 2. Go to waitingreserves.tt 3. The table loads but notice the 'cancel_selected_holds' button is an empty button. 4. Look at the console and notice the "Uncaught TypeError: settings is null" error. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 22