April 2023 - Koha-bugs - lists.koha-community.org

[Bug 33183] New: Error inserting matchpoint_components when creating record matching rules with MariaDB 10.6
by bugzilla-daemon＠bugs.koha-community.org 27 Apr '23

27 Apr '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33183 Bug ID: 33183 Summary: Error inserting matchpoint_components when creating record matching rules with MariaDB 10.6 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: kyle(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org The word "offset" is now a keyword. At the very least we need to escape the fieldname with backticks. It would be nice to switch to Koha::Objects for this module eventually. C4::Matcher::_store_matchpoint(): DBI Exception: DBD::mysql::st execute failed: You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near 'offset, length) VALUES ('27', '1', '999'...' at line 2 at /usr/share/koha/lib/C4/Matcher.pm line 314 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 18

[Bug 33150] New: Add specific message for renewal too_soon situation
by bugzilla-daemon＠bugs.koha-community.org 27 Apr '23

27 Apr '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33150 Bug ID: 33150 Summary: Add specific message for renewal too_soon situation Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Self checkout Assignee: koha-bugs(a)lists.koha-community.org Reporter: andreas.jonsson(a)kreablo.se QA Contact: testopia(a)bugs.koha-community.org The message "No renewals allowed" is incorrect when it is too soon for renewal. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 20

[Bug 32519] New: In Elasticsearch mappings table add search field name
by bugzilla-daemon＠bugs.koha-community.org 27 Apr '23

27 Apr '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32519 Bug ID: 32519 Summary: In Elasticsearch mappings table add search field name Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching - Elasticsearch Assignee: koha-bugs(a)lists.koha-community.org Reporter: fridolin.somers(a)biblibre.com In Elasticsearch mappings table, in tabs for mappings we should add search field name in addition to label ; in order to find them when searching using DataTable search field. This is very useful when debugging. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 18

[Bug 33063] New: Duplicated reports should maintain subgroup of original
by bugzilla-daemon＠bugs.koha-community.org 27 Apr '23

27 Apr '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33063 Bug ID: 33063 Summary: Duplicated reports should maintain subgroup of original Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Reports Assignee: koha-bugs(a)lists.koha-community.org Reporter: andrewfh(a)dubcolib.org QA Contact: testopia(a)bugs.koha-community.org When one duplicates a report that's in a group, the new report defaults to going into the same group as the original. But if the original report also has a subgroup that is not passed on to the duplicate. A duplicated report should default to the same group *and* subgroup as its original. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 18

[Bug 29607] New: addorderiso2709: The stored discount when importing an order from a file is invalid
by bugzilla-daemon＠bugs.koha-community.org 27 Apr '23

27 Apr '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29607 Bug ID: 29607 Summary: addorderiso2709: The stored discount when importing an order from a file is invalid Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Acquisitions Assignee: koha-bugs(a)lists.koha-community.org Reporter: christophe.torin(a)univ-rennes2.fr QA Contact: testopia(a)bugs.koha-community.org In the Acquisitions module : - Create a new vendor with a discount (Or select one that has a discount). Here the discount will be 25% - Create a new basket or select an existing one - Select "Add to basket" => From a staged file - Add an order from one of the file ==> Here, you can use a specific discount for the order, to override the vendor discount. The result should be quite the same if you do, but with this discount - The order is created ==> Modify the order - The discount is 0.25% instead of 25% Note that the prices are initially correctly calculated, but the discount value will appear as false. Plus, if you modify the order and change a price, the wrong discount will be used. In database, the discount is indeed stored as a value between 0 and 1, but only in that case (for the vendor, it is the actual percentage, and when you create an order from anoher source, it is stored correctly) This was reported on Koha 20.11, but is still relevant on master. In the code, this happens because the discount value is first divided by 100 to calculate the price, but it is that divided value that is stored in database, instead of the whole percentage value. On the master branch, in the file Koha/acqui/addorderiso2709.pl, the line where it's done are lines 166, 279 and 340 What I would suggest is : - Remove the division per 100 on those lines (166, 279 and 340) - Divide per 100 only when calculating the price (lines 283, 285, 344, 346) ==> ( 1 - $c/100 ) instead of ( 1 - $c ) - In the template (for importing from file), add a "%" just to be clear that the discount is a percentage, and not a value between 0 and 1 I know there was a kind of security (divide by 100 if the input is > 1), but it could be the other way around (multiply by 100 if the input is < 1). But as it is based on the field that is in the form, with a simple "%" indication it should not be needed. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 19

[Bug 33189] New: Plugin upload should prompt for kpz files
by bugzilla-daemon＠bugs.koha-community.org 27 Apr '23

27 Apr '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33189 Bug ID: 33189 Summary: Plugin upload should prompt for kpz files Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Plugin architecture Assignee: koha-bugs(a)lists.koha-community.org Reporter: dcook(a)prosentient.com.au QA Contact: testopia(a)bugs.koha-community.org At the moment, when you click "Choose file" when uploading a plugin, it looks for "All Files (*.*)", but really we only ever want "*.kpz" files. By changing the HTML we should be able to make it only look for "*.kpz" files which should make uploads a bit more convenient. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 15

[Bug 33173] New: Save and continue button in standard cataloging module broken
by bugzilla-daemon＠bugs.koha-community.org 27 Apr '23

27 Apr '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33173 Bug ID: 33173 Summary: Save and continue button in standard cataloging module broken Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: koha-bugs(a)lists.koha-community.org Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: m.de.rooy(a)rijksmuseum.nl To recreate: 1 - Edit a record in the standard editor 2 - Click on to tab 2 3 - Click 'Save and continue' 4 - Error: tab is not defined -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 15

[Bug 32492] New: Improve mark-up of OPAC messaging table to ease customization
by bugzilla-daemon＠bugs.koha-community.org 27 Apr '23

27 Apr '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32492 Bug ID: 32492 Summary: Improve mark-up of OPAC messaging table to ease customization Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Keywords: Academy Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard(a)myacpl.org Reporter: katrin.fischer(a)bsz-bw.de QA Contact: testopia(a)bugs.koha-community.org When looking at the messaging preferences table in the OPAC, it's really hard to customize. You can only use the row index or the translated descriptions when trying to select the correct line to add things to or when you want to hide unused messages. It would be great if we could add classes with the code for each notice/message, so this is easier. -- You are receiving this mail because: You are watching all bug changes.

1 34

[Bug 32679] New: CSS class article-request-title is doubled up in article requests list in OPAC patron account
by bugzilla-daemon＠bugs.koha-community.org 27 Apr '23

27 Apr '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32679 Bug ID: 32679 Summary: CSS class article-request-title is doubled up in article requests list in OPAC patron account Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Keywords: Academy Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard(a)myacpl.org Reporter: katrin.fischer(a)bsz-bw.de QA Contact: testopia(a)bugs.koha-community.org The CSS class article-request-title is used for the title of the host and also for the column with the article title. So if you are not careful, things will get mixed up. The classes for 2 different things should be differently named. * Activate article requests in system preferences * Make sure article requests are allowed in circulation conditions * Make an article request for a record in the OPAC * Check the display in the patron account for the article request -- You are receiving this mail because: You are watching all bug changes.

1 17

[Bug 33155] New: Category and library filters from header patron search not taken into account
by bugzilla-daemon＠bugs.koha-community.org 27 Apr '23

27 Apr '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33155 Bug ID: 33155 Summary: Category and library filters from header patron search not taken into account Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Patrons Assignee: jonathan.druart+koha(a)gmail.com Reporter: jonathan.druart+koha(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com Depends on: 7380 Caused by commit f1925cf89dbc1039fc48abfabad1472289387148 Bug 7380: Rename filter to avoid confusion [% IF categorycode %] - $("#categorycode_filter").val("[% categorycode %]"); + $("#categorycode_filter").val("[% categorycode_filter %]"); [% END %] [% IF branchcode %] - $("#branchcode_filter").val("[% branchcode %]"); + $("#branchcode_filter").val("[% branchcode_filter %]"); [% END %] Forgot to rename the vars in the IF statements Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7380 [Bug 7380] Can't filter patron search on detail page -- You are receiving this mail because: You are watching all bug changes.

1 12