April 2023 - Koha-bugs - lists.koha-community.org

[Bug 12802] Send notices using several email addresses
by bugzilla-daemon＠bugs.koha-community.org 06 Apr '23

06 Apr '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119016|0 |1 is obsolete| | --- Comment #105 from Julian Maurice <julian.maurice(a)biblibre.com> --- Created attachment 149232 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149232&action=e… Bug 12802: Sent notices using several email addresses Currently it is not possible to select several email addresses to notify a patron. The only place where the mechanism exists is in the overdue_notices.pl script. This patch reuses the AutoEmailPrimaryAddress syspref and changes its type to "multiple". Like that it is now possible to select several email addresses. Note that there is no sense to select OFF and another value for this pref. So if the 'OFF' (first valid) value exist, it takes the priority. It will add the ability to choose the email addresses to use to notify patrons. The option is "email", "emailpro" and "B_email". If "OFF" is selected, the first valid address will be returned (same behavior as before this patch). Note for the QA step: I found a possible regression, but IMO it's not a big deal: Before this patch if a letter did not contain a "to_address", the C4::Letters::_send_message_by_email subroutine retrieve the email from the given borrowernumber. This is now done in the EnqueueMessage subroutine. What it means: If a borrower didn't have an email address when the notice was sent to the queue, the email address won't be check again when the notice will really sent to the patron. This change permits to sent a letter to the queue (EnqueueLetter) without any information (from_address, to_address), only the borrowernumber is mandatory to retrieve them. The _send_message_by_email subroutine should not contain any useful code, only sent the letter we ask it to sent. What this patch does: The Koha::Patron::notice_email_address subroutine has been renamed to Koha::Patron::notice_email_addresses (plural). It only gets the patron emails defined in the AutoEmailPrimaryAddress pref. If no 'to_address' parameter is given to EnqueueMessage, the emails will be retrieved at this moment. In C4::Message: An old form was found. The AutoEmailPrimaryAddress was not check. The smsalertnumber was sent for the to_address param, which is wrong. C4::Reserves: AddReserve and _koha_notify_reserve: The from address is built in the QueueLetter. It is useless to do it here. overdue_notices.pl: The script could be cleaned a little bit if we remove the --email parameter. Indeed it is redundant with this new enhancement. I can propose another patch with a die statement and a message: "you should use the pref AutoEmailPrimaryAddress" if the --email is provided. opac/opac-shareshelf.pl and opac/opac-memberentry.pl: just remove the from and to address. They will be filled on sending to the queue (because of the borrowernumber). Test plan: 1. Apply this patch without updating the pref AutoEmailPrimaryAddress (or fill it with a single value if it is not done yet). 2. Try the different way to sent notices to a patron (check the following letter code: HOLD, CHECKIN, CHECKOUT, PREDUE, RENEW, DUE). 3. Verify the email is correctly sent to the message_queue. 4. Fill the pref with email and emailpro (for instance) 5. Verify that 2 notices are sent to the message_queue: 1 with the email and 1 with the emailpro. 6. You can also verify that only 1 notice is generated if the emailpro is empty. Important note for testers: Pending messages must be removed each time you change the value of AutoEmailPrimaryAddress. When there are already existing pending messages for a borrower, Koha tries to update them rather than enqueuing new ones, but it will not update the recipient's email address, nor add/remove messages depending on the new value of AutoEmailPrimaryAddress; not sure if this is a bug or not. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 3186] invalid or uninstalled SMSSendDriver (or bad number format) causes process_message_queue to fail
by bugzilla-daemon＠bugs.koha-community.org 06 Apr '23

06 Apr '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3186 Fridolin Somers <fridolin.somers(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=33428 | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 3186] invalid or uninstalled SMSSendDriver (or bad number format) causes process_message_queue to fail
by bugzilla-daemon＠bugs.koha-community.org 06 Apr '23

06 Apr '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3186 Fridolin Somers <fridolin.somers(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=33428 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 33376] New: Adding the option to modify/edit searches on the OPAC
by bugzilla-daemon＠bugs.koha-community.org 06 Apr '23

06 Apr '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33376 Bug ID: 33376 Summary: Adding the option to modify/edit searches on the OPAC Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: koha-bugs(a)lists.koha-community.org Reporter: dcook(a)prosentient.com.au QA Contact: testopia(a)bugs.koha-community.org We know have an "edit search" option on the staff interface, but it would be arguably more useful on the OPAC. Locally, I've had an edit search on the OPAC for years. Perhaps I should look at upstreaming that... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 3

[Bug 33378] New: OPAC advanced search limits and OPAC facets no longer correspond
by bugzilla-daemon＠bugs.koha-community.org 06 Apr '23

06 Apr '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33378 Bug ID: 33378 Summary: OPAC advanced search limits and OPAC facets no longer correspond Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard(a)myacpl.org Reporter: dcook(a)prosentient.com.au QA Contact: testopia(a)bugs.koha-community.org If you choose an advanced search limit in the OPAC of the item type "Books", that facet won't be selected in the OPAC search results. This appears to be due to a small change in what search qualifiers are used... -- You are receiving this mail because: You are watching all bug changes.

1 2

[Bug 33420] New: Allow deletion of ILL notices ILL_PICKUP_READY and ILL_REQUEST_UNAVAIL
by bugzilla-daemon＠bugs.koha-community.org 05 Apr '23

05 Apr '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33420 Bug ID: 33420 Summary: Allow deletion of ILL notices ILL_PICKUP_READY and ILL_REQUEST_UNAVAIL Change sponsored?: --- Product: Koha Version: 22.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs(a)lists.koha-community.org Reporter: bwsdonna(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org The notices ILL_PICKUP_READY and ILL_REQUEST_UNAVAIL cannot be deleted by users. Libraries that do not use the ILL module should be able to delete these notices. All the other ILL notices are able to be deleted. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 1

[Bug 33424] New: tags incompatibility across koha versions
by bugzilla-daemon＠bugs.koha-community.org 05 Apr '23

05 Apr '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33424 Bug ID: 33424 Summary: tags incompatibility across koha versions Change sponsored?: --- Product: Project Infrastructure Version: unspecified Hardware: PC OS: Linux Status: NEW Severity: critical Priority: P5 - low Component: Bugzilla Assignee: jonathan.druart+koha(a)gmail.com Reporter: kohasupport(a)nlj.gov.jm We store a backup of koha on version 21.05 and use a live version on 21.11. The database on the backup displays data in fields, whereas those same fields show up empty in the live version. For example 040$c shows data in version 21.05, but the same version of the database does not show data in version 21.11. Thank you for your assistance -- You are receiving this mail because: You are watching all bug changes.

1 2

[Bug 12029] Patrons should be able to delete their patron messages
by bugzilla-daemon＠bugs.koha-community.org 05 Apr '23

05 Apr '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029 AspenCat Team <aspencatteam(a)clicweb.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aspencatteam(a)clicweb.org -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 32728] New: ERM - Search header should change to match the section you are in
by bugzilla-daemon＠bugs.koha-community.org 05 Apr '23

05 Apr '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32728 Bug ID: 32728 Summary: ERM - Search header should change to match the section you are in Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: ERM Assignee: jonathan.druart+koha(a)gmail.com Reporter: david(a)davidnind.com CC: jonathan.druart+koha(a)gmail.com, jonathan.field(a)ptfs-europe.com, martin.renvoize(a)ptfs-europe.com, pedro.amorim(a)ptfs-europe.com The ERM module search header has three options: Search agreements, Search packages, and Search titles. If you click through the sidebar options (Agreements, Packages, and Titles) the search header doesn't change to reflect the area you are in. If you change the header to another option, for example 'Search titles', then perform a search, the header goes back to 'Agreement search'. To replicate: 1. Enable the ERM module: ERMModule system preference. 2. Go to the ERM module: Home > E-resource management. 3. Select the options from the sidebar menu (Agreements, Packages and Titles), and note that the ERM search header options don't change. 4. Add a minimal agreement, package and title. 5. Change the search header to another option, for example 'Search titles', then perform a search. Note that: - the appropriate sidebar menu option is highlighted, for example: 'Titles' - the search header changes back to 'Agreement search' This was noted as a potential issue when testing bug 32683 - Convert header search tabs to Bootstrap. -- You are receiving this mail because: You are watching all bug changes.

1 21

[Bug 28609] New: Popularity sort is broken
by bugzilla-daemon＠bugs.koha-community.org 05 Apr '23

05 Apr '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28609 Bug ID: 28609 Summary: Popularity sort is broken Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Searching - Zebra Assignee: koha-bugs(a)lists.koha-community.org Reporter: katrin.fischer(a)bsz-bw.de Bug 13976 reported that the sort by popularity was only alphabetic and not numeric. I cannot confirm that... because now it's broken. When sorting by popularity the result list is sorted by biblionumber instead, which is the usual fallback when values are identical. When searching issues:74 or popluarity:74 records where the items have this number of issues are found correctly. So it appears the index is there and filled, but somehow not working when used for sorting? Verified in 18.11 and 20.11. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 4