July 2023 - Koha-bugs - lists.koha-community.org

[Bug 30342] New: Incorrect check for outstanding holds on order receive page
by bugzilla-daemon＠bugs.koha-community.org 08 Jul '23

08 Jul '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30342 Bug ID: 30342 Summary: Incorrect check for outstanding holds on order receive page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs(a)lists.koha-community.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org Depends on: 20212 On the "Receive orders" page (acqui/parcel.pl?invoiceid=X) there is a check for outstanding holds which is supposed to be used to disable cancellation if there are any holds. This isn't working: Holds to not block cancellation. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 [Bug 20212] Improve performance of acquisitions receive page -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 2

[Bug 14797] Cancelling orders with no alert to existing holds
by bugzilla-daemon＠bugs.koha-community.org 08 Jul '23

08 Jul '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14797 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard(a)myacpl.org --- Comment #9 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- *** Bug 30342 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0

[Bug 10627] History of reports run and their results
by bugzilla-daemon＠bugs.koha-community.org 08 Jul '23

08 Jul '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10627 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|history of reports |History of reports run and |run/results |their results -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10518] Add sorting for Cyrillic characters
by bugzilla-daemon＠bugs.koha-community.org 08 Jul '23

08 Jul '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10518 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10518] Add sorting for Cyrillic characters
by bugzilla-daemon＠bugs.koha-community.org 08 Jul '23

08 Jul '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10518 --- Comment #8 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- I believe this was fixed by the addition of sort files for ru and ua: https://git.koha-community.org/Koha-community/Koha/src/branch/master/etc/ze… But it might still be worth thinking about a combined file for multi-language libraries? The approach of having them all in separate files and having to decide on just one appears to be flawed. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10477] Allow to select MARC fields to merge on staged MARC import
by bugzilla-daemon＠bugs.koha-community.org 08 Jul '23

08 Jul '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10477 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Increased flexibility for |Allow to select MARC fields |upload of Staged MARC |to merge on staged MARC |records |import --- Comment #20 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- The idea of this is still quite interesting. While we can use overlay rules to protect fields, the idea here is to define what is being merged. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10471] Global search input box and button geometry not always consistent (browsers, translations)
by bugzilla-daemon＠bugs.koha-community.org 08 Jul '23

08 Jul '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10471 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |RESOLVED Resolution|--- |INVALID --- Comment #6 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- I believe that this is no longer valid with the staff interface redesign. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10454] Duplicate card numbers may be generated
by bugzilla-daemon＠bugs.koha-community.org 08 Jul '23

08 Jul '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10454 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |RESOLVED Resolution|--- |FIXED --- Comment #25 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- I feel like this was mostly resolved by generating the card numbers on saving (not displaying them at the form while adding the user). Please reopen if you disagree. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10417] Add table to keep deleted authorities
by bugzilla-daemon＠bugs.koha-community.org 08 Jul '23

08 Jul '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10417 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #2 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- *** This bug has been marked as a duplicate of bug 30888 *** -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10400] Text::CSV_XS error-checking should be standardized
by bugzilla-daemon＠bugs.koha-community.org 08 Jul '23

08 Jul '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10400 --- Comment #3 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- (In reply to Galen Charlton from comment #0) > As reported by Doug Kingston on koha-devel on 2013-06-02, if version 0.97 of > Text::CSV_XS is installed, it can segfault. From Doug's email: > > "The error from t/Labels.t is a segmentation fault when calling > $csv->error_input() in Labels/Label.pm. > > sub _get_text_fields { > my $format_string = shift; > my $csv = Text::CSV_XS->new({allow_whitespace => 1}); > my $status = $csv->parse($format_string); > my @sorted_fields = map {{ 'code' => $_, desc => $_ }} > map { $_ eq 'callnumber' ? 'itemcallnumber' : $_ } > # see bug 5653 > $csv->fields(); > my $error = $csv->error_input(); > warn sprintf('Text field sort failed with this error: %s', $error) if > $error; > return \@sorted_fields; > }" > > A ticket was opened with the maintainer of Text::CSV_XS > (https://rt.cpan.org/Ticket/Display.html?id=85810) and he fixed the > segfault bug in version 0.98 of the module. koha-testing-docker shows the version installed as: Text::CSV_XS (0.32 ) 1.45 So I guess we could assume that most installations have this fix by now. > > Nonetheless, Koha code that uses Text::CSV_XS should follow the module's > documentation more closely; in particular, it looks like the correct thing > to do is the check the value of the $status returned by $csv->parse() before > deciding whether to invoke error_input(). It looks like we do the status check on patron import: my $status = $self->text_csv->parse($borrowerline); my @columns = $self->text_csv->fields(); if ( !$status ) { push @missing_criticals, { badparse => 1, line => $line_number, lineraw => decode_utf8($borrowerline) }; } But there has not been any change in Labels: sub _get_text_fields { my $format_string = shift; my $csv = Text::CSV_XS->new({allow_whitespace => 1}); my $status = $csv->parse($format_string); my @sorted_fields = map {{ 'code' => $_, desc => $_ }} map { $_ && $_ eq 'callnumber' ? 'itemcallnumber' : $_ } # see bug 5653 $csv->fields(); my $error = $csv->error_input(); warn sprintf('Text field sort failed with this error: %s', $error) if $error; return \@sorted_fields; -- You are receiving this mail because: You are watching all bug changes.

1 0