July 2023 - Koha-bugs - lists.koha-community.org

[Bug 12133] Guarantor requirements when registering a patron
by bugzilla-daemon＠bugs.koha-community.org 06 Jul '23

06 Jul '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12133 Emmi Takkinen <emmi.takkinen(a)koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #35 from Emmi Takkinen <emmi.takkinen(a)koha-suomi.fi> --- I'm setting status back to "Needs Signoff" since Im' unable to repeat Sams problem with tests. However if it recurs then I'll look again. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12133] Guarantor requirements when registering a patron
by bugzilla-daemon＠bugs.koha-community.org 06 Jul '23

06 Jul '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12133 Emmi Takkinen <emmi.takkinen(a)koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #152706|0 |1 is obsolete| | --- Comment #34 from Emmi Takkinen <emmi.takkinen(a)koha-suomi.fi> --- Created attachment 153082 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153082&action=e… Bug 12133: Add requirements for guarantor and guarantee Add two requirements when registering a new patron: - A child patron must have a guarantor. This is controlled by a new syspref ChildNeedsGuarantor. - A guarantor cannot be a guarantee. Test plan: 1. Add a child patron without guarantor or child patron with guarantee as guarantor succesfully. 2. Apply this patch. 3. Add a child patron as a guarantor. => Error is raised. 4. Turn syspref "ChildNeedsGuarantor" ON. 5. Add a child patron without a guarantor and error "Child needs a guarantor" is raised. 6. Add guarantor. Guarantor can either be existing patron or added with "Contact" section. => Save without errors. Also prove t/db_dependent/Koha/Patron.t Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12133] Guarantor requirements when registering a patron
by bugzilla-daemon＠bugs.koha-community.org 06 Jul '23

06 Jul '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12133 --- Comment #33 from Emmi Takkinen <emmi.takkinen(a)koha-suomi.fi> --- (In reply to Sam Lau from comment #32) > Everything in test plan worked fine for me, just failing > t/db_dependent/Koha/Patron.t. > > # Subtest: guarantor requirements tests > 1..6 > ok 1 - Child patron can be stored without guarantor when > ChildNeedsGuarantor is off. > ok 2 - Exception thrown when guarantor is required but not provided. > ok 3 - Exception thrown when child patron is added as guarantor. > DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st > execute failed: Incorrect datetime value: 'SCALAR(0xaaab1c4b5b58)' for > column `koha_kohadev`.`borrowers`.`updated_on` at row 1 at > /kohadevbox/koha/Koha/Object.pm line 170 > # Looks like you planned 6 tests but ran 3. > not ok 25 - guarantor requirements tests > > # Failed test 'guarantor requirements tests' > # at t/db_dependent/Koha/Patron.t line 1588. > Invalid value passed, borrowers.updated_on=SCALAR(0xaaab1c4b5b58) expected > type is datetime# Looks like your test exited with 255 just after 25. > Dubious, test returned 255 (wstat 65280, 0xff00) > Failed 1/25 subtests Hmm, I'm unable to repeat this. Did you test this with current master? However for some reason 'guarantor requirements tests' fail for me randomly with error "Child patron cannot be a guarantor." This probably happens because $child2 is first attempted to be stored with child as guarantor and then without it..? Adding $child2->discard_changes after first store seems to help. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13600] XSLT: 8xx not showing if there is no 4xx
by bugzilla-daemon＠bugs.koha-community.org 06 Jul '23

06 Jul '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13600 Phil Ringnalda <phil(a)chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |1joynelson(a)gmail.com --- Comment #50 from Phil Ringnalda <phil(a)chetcolibrary.org> --- *** Bug 22820 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 32339] New: [Elasticsearch] Provide record when cataloguing biblios
by bugzilla-daemon＠bugs.koha-community.org 05 Jul '23

05 Jul '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32339 Bug ID: 32339 Summary: [Elasticsearch] Provide record when cataloguing biblios Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs(a)lists.koha-community.org Reporter: aleisha(a)catalyst.net.nz QA Contact: testopia(a)bugs.koha-community.org CC: m.de.rooy(a)rijksmuseum.nl When reindexing with elasticsearch, the record is passed for authorities but not for biblios. This means that authorities are indexed as they are, while biblios are pushed to a background job. These processes should be consistent. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 6

[Bug 14367] History for MARC records. Roll back changes on a timeline or per field.
by bugzilla-daemon＠bugs.koha-community.org 05 Jul '23

05 Jul '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14367 Phil Ringnalda <phil(a)chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 26635] New: Expand authorised values in REST API call
by bugzilla-daemon＠bugs.koha-community.org 05 Jul '23

05 Jul '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26635 Bug ID: 26635 Summary: Expand authorised values in REST API call Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: REST API Assignee: agustinmoyano(a)theke.io Reporter: agustinmoyano(a)theke.io We need a way to embed expanded authorised values in a REST API call. It's specially needed when you have to show authorised values descriptions in tables that are fetched through api. The proposed solution adds to object's api definition (even embedded content) the following key: _authorised_values For each column that contains an authorised value, it will be reflected inside this property, with the authorised value expanded. So for example if we embed the authorised values of an item, the result from the API call could look like this: GET /api/v1/items/1 { "_authorised_values": { "location": { "authorised_value": "GEN", "category": "LOC", "id": 27, "imageurl": null, "lib": "General Stacks", "lib_opac": null } }, "acquisition_date": "2014-05-07", "acquisition_source": null, "biblio_id": 1, "item_id": 1, ... "location": "GEN", ... "uri": null, "withdrawn": 0, "withdrawn_date": null } -- You are receiving this mail because: You are watching all bug changes.

1 155

[Bug 24284] New: Canelling of holds and order should allow for different translation then cancel as options in dialogs
by bugzilla-daemon＠bugs.koha-community.org 05 Jul '23

05 Jul '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24284 Bug ID: 24284 Summary: Canelling of holds and order should allow for different translation then cancel as options in dialogs Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Keywords: Academy Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs(a)lists.koha-community.org Reporter: katrin.fischer(a)bsz-bw.de QA Contact: testopia(a)bugs.koha-community.org CC: frederic(a)tamil.fr At least in German the verb used for cancelling orders/holds is different than the verb used for cancelling a process/cancelling a dialog. It would be nice if Koha allowed for different translations in this case. Maybe the new I18N features could be helpful here? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 5

[Bug 14797] Cancelling orders with no alert to existing holds
by bugzilla-daemon＠bugs.koha-community.org 05 Jul '23

05 Jul '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14797 Caroline Cyr La Rose <caroline.cyr-la-rose(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com --- Comment #8 from Caroline Cyr La Rose <caroline.cyr-la-rose(a)inlibro.com> --- I don't know if this is the same bug as the one I just ran into. I was looking to recreate the context for this string "Can't cancel order, (%s) holds are linked with this order. Cancel holds first" (I was wondering if (%s) was a number or not) However, if my ordered item has a hold, it says Cancel order Can't cancel order and delete catalog record And if I hover over the "Can't cancel order and delete catalog record" there is a tooltip indicating that the record cannot be deleted for reasons listed below. But there are no reasons. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0

[Bug 12133] Guarantor requirements when registering a patron
by bugzilla-daemon＠bugs.koha-community.org 05 Jul '23

05 Jul '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12133 Sam Lau <samalau(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |samalau(a)gmail.com Status|Needs Signoff |Failed QA --- Comment #32 from Sam Lau <samalau(a)gmail.com> --- Everything in test plan worked fine for me, just failing t/db_dependent/Koha/Patron.t. # Subtest: guarantor requirements tests 1..6 ok 1 - Child patron can be stored without guarantor when ChildNeedsGuarantor is off. ok 2 - Exception thrown when guarantor is required but not provided. ok 3 - Exception thrown when child patron is added as guarantor. DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st execute failed: Incorrect datetime value: 'SCALAR(0xaaab1c4b5b58)' for column `koha_kohadev`.`borrowers`.`updated_on` at row 1 at /kohadevbox/koha/Koha/Object.pm line 170 # Looks like you planned 6 tests but ran 3. not ok 25 - guarantor requirements tests # Failed test 'guarantor requirements tests' # at t/db_dependent/Koha/Patron.t line 1588. Invalid value passed, borrowers.updated_on=SCALAR(0xaaab1c4b5b58) expected type is datetime# Looks like your test exited with 255 just after 25. Dubious, test returned 255 (wstat 65280, 0xff00) Failed 1/25 subtests -- You are receiving this mail because: You are watching all bug changes.

1 0