September 2023 - Koha-bugs - lists.koha-community.org

[Bug 12532] Redirect guarantee email to guarantor
by bugzilla-daemon＠bugs.koha-community.org 18 Sep '23

18 Sep '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 --- Comment #133 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 155834 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155834&action=e… Bug 12532: (QA follow-up) Add tests for SendQueuedMessages This patch adds unit tests for the changes made to _send_message_by_email for Guarantor CC -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12532] Redirect guarantee email to guarantor
by bugzilla-daemon＠bugs.koha-community.org 18 Sep '23

18 Sep '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 --- Comment #132 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 155833 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155833&action=e… Bug 12532: (QA follow-up) Remove defunkt test Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12532] Redirect guarantee email to guarantor
by bugzilla-daemon＠bugs.koha-community.org 18 Sep '23

18 Sep '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 --- Comment #131 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 155832 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155832&action=e… Bug 12532: (QA follow-up) More cleanup Minor QA cleanup, perltidy, remove Data::Dumper and clarify warn Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12532] Redirect guarantee email to guarantor
by bugzilla-daemon＠bugs.koha-community.org 18 Sep '23

18 Sep '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154857|0 |1 is obsolete| | --- Comment #130 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 155831 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155831&action=e… Bug 12532: (follow-up) Send email to guarantor using the CC field In This patch the CC field is used to send the message to the guarantors. If the «to» field is empty (the guarantee has no address) we send the message «to» the garantors. Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12532] Redirect guarantee email to guarantor
by bugzilla-daemon＠bugs.koha-community.org 18 Sep '23

18 Sep '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154856|0 |1 is obsolete| | --- Comment #129 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 155830 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155830&action=e… Bug 12532: (QA follow-up) Clean up notice_email_address Reduce some of the code duplication Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12532] Redirect guarantee email to guarantor
by bugzilla-daemon＠bugs.koha-community.org 18 Sep '23

18 Sep '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154855|0 |1 is obsolete| | --- Comment #128 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 155829 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155829&action=e… Bug 12532: (QA follow-up) Undo changes to Koha::Email The changes here aren't required (Email::Address already deals with lists of addresses internally) Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12532] Redirect guarantee email to guarantor
by bugzilla-daemon＠bugs.koha-community.org 18 Sep '23

18 Sep '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154854|0 |1 is obsolete| | --- Comment #127 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 155828 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155828&action=e… Bug 12532: Send email to guarantee and guarantor This patch allows guarantors to receive emails sended to their guarentees. This patch is a rebase of the previous patches. I took all the content of previous commit and put it in one commit. TO TEST: Before applying: 1) Search, or create, a patron with guarantor. 2) For both guarantors and guarantees: - Add an email address - Update the 'Patron messaging preferences' section so that an email is sent for item checkouts 3) Checkout an item. An email should be sent only to the guarantee. 4) Apply the patch. 5) Run updatedatabase.pl 6) Run prove t/db_dependent/Members.t and prove t/db_dependent/Letters.t 7) Enable 'RedirectGuaranteeEmail' 8) Run misc/cronjobs/process_message_queue.pl 9) Notice that the email should be sended to both the guarantee AND the guarantor. Signed-off-by: David Nind <david(a)davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 26045] New: Search/History.t is failing randomly
by bugzilla-daemon＠bugs.koha-community.org 18 Sep '23

18 Sep '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26045 Bug ID: 26045 Summary: Search/History.t is failing randomly Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: chris(a)bigballofwax.co.nz Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org Blocks: 25551 Master_D10 #302 16:14:22 koha_1 | # Failed test 'There are 9 searches in all' 16:14:22 koha_1 | # at t/db_dependent/Search/History.t line 48. 16:14:22 koha_1 | # got: '10' 16:14:22 koha_1 | # expected: '9' 16:14:22 koha_1 | 16:14:22 koha_1 | # Failed test 'There are 4 searches for previous sessions' 16:14:22 koha_1 | # at t/db_dependent/Search/History.t line 61. 16:14:22 koha_1 | # got: '5' 16:14:22 koha_1 | # expected: '4' 16:14:22 koha_1 | 16:14:22 koha_1 | # Failed test 'There are 5 searches for the current session' 16:14:22 koha_1 | # at t/db_dependent/Search/History.t line 82. 16:14:22 koha_1 | # got: '5' 16:14:22 koha_1 | # expected: '4' 16:14:22 koha_1 | # Looks like you failed 3 tests of 27. 16:14:22 koha_1 | [14:14:22] t/db_dependent/Search/History.t Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25551 [Bug 25551] [OMNIBUS] Some tests are failing randomly -- You are receiving this mail because: You are watching all bug changes.

1 3

[Bug 26056] New: `dbic` generates changes to EDI related schema files with latest MariaDB
by bugzilla-daemon＠bugs.koha-community.org 18 Sep '23

18 Sep '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26056 Bug ID: 26056 Summary: `dbic` generates changes to EDI related schema files with latest MariaDB Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org Maybe a bug in latest MariaDB (10.5.4) modified: Koha/Schema/Result/Aqbasket.pm modified: Koha/Schema/Result/Aqbookseller.pm modified: Koha/Schema/Result/Aqbudget.pm modified: Koha/Schema/Result/Branch.pm modified: Koha/Schema/Result/EdifactEan.pm modified: Koha/Schema/Result/EdifactMessage.pm modified: Koha/Schema/Result/VendorEdiAccount.pm Stuffs like: +__PACKAGE__->has_many( + "edifact_messages_2s", + "Koha::Schema::Result::EdifactMessage", + { "foreign.basketno" => "self.basketno" }, + { cascade_copy => 0, cascade_delete => 0 }, +); +__PACKAGE__->has_many( + "edifact_messages_2s", + "Koha::Schema::Result::EdifactMessage", + { "foreign.vendor_id" => "self.id" }, + { cascade_copy => 0, cascade_delete => 0 }, +); +__PACKAGE__->has_many( + "vendor_edi_accounts_2s", + "Koha::Schema::Result::VendorEdiAccount", + { "foreign.vendor_id" => "self.id" }, + { cascade_copy => 0, cascade_delete => 0 }, +); and more... -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 3

[Bug 6419] Add customizable areas to intranet home pages
by bugzilla-daemon＠bugs.koha-community.org 18 Sep '23

18 Sep '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6419 --- Comment #63 from Owen Leonard <oleonard(a)myacpl.org> --- Rebased. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0