September 2023 - Koha-bugs - lists.koha-community.org

[Bug 12532] Redirect guarantee email to guarantor
by bugzilla-daemon＠bugs.koha-community.org 19 Sep '23

19 Sep '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 --- Comment #150 from Jonathan Druart <jonathan.druart+koha(a)gmail.com> --- Created attachment 155886 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155886&action=e… Bug 12532: Fix test The mock was working. The problem was that the to_address of the notice was set from the previous send. A fix would be to update the message, but it seems better to simply re-enqueue it. This patch also use Koha::Notice::Messages. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12532] Redirect guarantee email to guarantor
by bugzilla-daemon＠bugs.koha-community.org 19 Sep '23

19 Sep '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 --- Comment #149 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- I think we're pretty much there now.. however I can't get that darn test to pass.. for some reason the second mock of the new preference doesn't want to take effect in this case so testing for what should happen when the feature is disabled is currently failing. Hopeing another set of QA eyes can spot my test issue and resolve it to get us over the finish line. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12532] Redirect guarantee email to guarantor
by bugzilla-daemon＠bugs.koha-community.org 19 Sep '23

19 Sep '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155837|0 |1 is obsolete| | --- Comment #148 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 155883 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155883&action=e… Bug 12532: (QA follow-up) Fix issues highlighted by unit tests * YesNo preferences yield '1' or '0' not 'yes' and 'no'. * Set message_cc address so we can report later that the message went to a cc address. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12532] Redirect guarantee email to guarantor
by bugzilla-daemon＠bugs.koha-community.org 19 Sep '23

19 Sep '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155836|0 |1 is obsolete| | --- Comment #147 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 155882 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155882&action=e… Bug 12532: DBIC Schema -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12532] Redirect guarantee email to guarantor
by bugzilla-daemon＠bugs.koha-community.org 19 Sep '23

19 Sep '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 --- Comment #146 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 155881 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155881&action=e… Bug 12532: Expose CC address in patron notices display Add the CC address into the patrons notices on the staff client to highlight that the message was copied to another user. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12532] Redirect guarantee email to guarantor
by bugzilla-daemon＠bugs.koha-community.org 19 Sep '23

19 Sep '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155835|0 |1 is obsolete| | --- Comment #145 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 155880 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155880&action=e… Bug 12532: (QA follow-up) Add cc_address to message_queue Add the cc_address field to the message_queue so we may report back that an email was copied to the guarantor email addresses. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12532] Redirect guarantee email to guarantor
by bugzilla-daemon＠bugs.koha-community.org 19 Sep '23

19 Sep '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155834|0 |1 is obsolete| | --- Comment #144 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 155879 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155879&action=e… Bug 12532: (QA follow-up) Add tests for SendQueuedMessages This patch adds unit tests for the changes made to _send_message_by_email for Guarantor CC -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12532] Redirect guarantee email to guarantor
by bugzilla-daemon＠bugs.koha-community.org 19 Sep '23

19 Sep '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155833|0 |1 is obsolete| | --- Comment #143 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 155878 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155878&action=e… Bug 12532: (QA follow-up) Remove defunkt test Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12532] Redirect guarantee email to guarantor
by bugzilla-daemon＠bugs.koha-community.org 19 Sep '23

19 Sep '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155832|0 |1 is obsolete| | --- Comment #142 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 155877 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155877&action=e… Bug 12532: (QA follow-up) More cleanup Minor QA cleanup, perltidy, remove Data::Dumper and clarify warn Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12532] Redirect guarantee email to guarantor
by bugzilla-daemon＠bugs.koha-community.org 19 Sep '23

19 Sep '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155831|0 |1 is obsolete| | --- Comment #141 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 155876 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155876&action=e… Bug 12532: (follow-up) Send email to guarantor using the CC field In This patch the CC field is used to send the message to the guarantors. If the «to» field is empty (the guarantee has no address) we send the message «to» the garantors. Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0