September 2023 - Koha-bugs - lists.koha-community.org

[Bug 18559] New: Koha:: Clubs - methods should not get the return type in parameter
by bugzilla-daemon＠bugs.koha-community.org 18 Sep '23

18 Sep '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18559 Bug ID: 18559 Summary: Koha::Clubs - methods should not get the return type in parameter Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: kyle(a)bywatersolutions.com Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org Depends on: 12461, 18553 Koha::Clubs->get_club_enrollments and Koha::Clubs->get_enrollable_clubs take a $return_scalar parameter. The return value type should not be a parameter. We should return _new_from_dbic or Koha::Objects->search in any cases. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461 [Bug 12461] Add patron clubs feature https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18553 [Bug 18553] Incorrect "Loading..." tag on moremember.tt when no clubs defined -- You are receiving this mail because: You are watching all bug changes.

1 10

[Bug 14092] Order search doesn't allow to search for 'all statuses'
by bugzilla-daemon＠bugs.koha-community.org 18 Sep '23

18 Sep '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14092 --- Comment #4 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- I tried to find a good way of making this change, while meeting some requirements: * I wanted "Any status" to be an additional entry in the status pull down, not a checkbox or similar on the form * We need to make sure that the right status is always selected, especially after completing the search, so it shows correctly in the filters on the right -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14092] Order search doesn't allow to search for 'all statuses'
by bugzilla-daemon＠bugs.koha-community.org 18 Sep '23

18 Sep '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14092 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155851|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 155853 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155853&action=e… Bug 14092: Add 'any status' option to acq order search form Sometimes it's really helpful to see all orders for a basket, a vendor or a standing order, including the cancelled ones. Currently this is not possible, as we have search options for every single status and one for "any except cancelled", but no "Any status" option. This patch adds the "Any status" option. The sometimes appearing empty entry is updated to "Any status except cancelled" as this is what it does. Testing data: * Requires multiple order lines with different order status * Must include at least one order line with status 'cancelled' To test: * Go to acquisitions * Open the advanced search page from the top search options: Order search > config icon > Advanced search link * Verify the status pull down looks as described above * Apply patch * Verify there is now an "Any status" option in the pull down * Try searches for different status, including "Any status" * Verify the results are as expected * Create a new basket * Create an order line by 'From an existing order (copy)' * Verify the search form there also works as expected -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14092] Order search doesn't allow to search for 'all statuses'
by bugzilla-daemon＠bugs.koha-community.org 18 Sep '23

18 Sep '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14092 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14092] Order search doesn't allow to search for 'all statuses'
by bugzilla-daemon＠bugs.koha-community.org 18 Sep '23

18 Sep '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14092 Jonathan Druart <jonathan.druart+koha(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 6419] Add customizable areas to intranet home pages
by bugzilla-daemon＠bugs.koha-community.org 18 Sep '23

18 Sep '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6419 --- Comment #74 from Jonathan Druart <jonathan.druart+koha(a)gmail.com> --- (In reply to Lucas Gass from comment #64) > This is looking good. DB updates look good, each of the new HTML areas works > nice and produces valid HTML. QA script is happy. Great enhancement. What about comment 53? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14092] Order search doesn't allow to search for 'all statuses'
by bugzilla-daemon＠bugs.koha-community.org 18 Sep '23

18 Sep '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14092 --- Comment #2 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 155851 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155851&action=e… Bug 14092: Add 'any status' option to acq order search form Sometimes it's really helpful to see all orders for a basket, a vendor or a standing order, including the cancelled ones. Currently this is not possible, as we have search options for every single status and one for "any except cancelled", but no "Any status" option. This patch adds the "Any status" option. The sometimes appearing empty entry is updated to "Any status except cancelled" as this is what it does. Testing data: * Requires multiple order lines with different order status * Must include at least one order line with status 'cancelled' To test: * Go to acquisitions * Open the advanced search page from the top search options: Order search > config icon > Advanced search link * Verify the status pull down looks as described above * Apply patch * Verify there is now an "Any status" option in the pull down * Try searches for different status, including "Any status" * Verify the results are as expected * Create a new basket * Create an order line by 'From an existing order (copy)' * Verify the search form there also works as expected -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14730] Let patrons upload their own images
by bugzilla-daemon＠bugs.koha-community.org 18 Sep '23

18 Sep '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14730 Christopher Brannon <cbrannon(a)cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cbrannon(a)cdalibrary.org --- Comment #3 from Christopher Brannon <cbrannon(a)cdalibrary.org> --- (In reply to jessedhammu from comment #2) > Koha now offers the functionality to the patrons to add/edit their profile > information from the opac screen. Also, librarians are given privileges to > moderate the user's profile change requests. This is a wonderful feature. > But Can it also be done with a profile Picture, because, now only a staff > member can upload the patron picture? It will be great if that functionality > is allowed on the OPAC's profile section so that users can set/change their > own profile photo. Hopefully this could be something that could be turned on/off independent of other patron info. For those of us wanting to use pictures for identity, I could see how this might be abused by patrons by just uploading a favorite icon or image, rather than their own picture. Some of them are might also be glamorized, making it more difficult to identify the patron. Not all libraries would want the patron uploading pictures of their choice. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 6419] Add customizable areas to intranet home pages
by bugzilla-daemon＠bugs.koha-community.org 18 Sep '23

18 Sep '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6419 Lucas Gass <lucas(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155816|0 |1 is obsolete| | --- Comment #73 from Lucas Gass <lucas(a)bywatersolutions.com> --- Created attachment 155847 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155847&action=e… Bug 6419: (follow-up) Use Select2 with optgroups This patch divides the OPAC and staff options into separate optgroups and adds Select2 for styling and filtering. THe patch also corrects a few missed instances of "Intranet" in the list of location options on the entry form. Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose(a)inlibro.com> Signed-off-by: Lucas Gass <lucas(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 6419] Add customizable areas to intranet home pages
by bugzilla-daemon＠bugs.koha-community.org 18 Sep '23

18 Sep '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6419 Lucas Gass <lucas(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155815|0 |1 is obsolete| | --- Comment #72 from Lucas Gass <lucas(a)bywatersolutions.com> --- Created attachment 155846 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155846&action=e… Bug 6419: Add StaffSerialsHome block to additional contents This patch adds a new `StaffSerialsHome` block to the HTML Customisations options. This allows for the addition of a block of content in a page-section at the bottom of the point of sale page. NOTE: This patch also removes the now defunct database update introduced in the first patch of the series. Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose(a)inlibro.com> Signed-off-by: Lucas Gass <lucas(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0