January 2024 - Koha-bugs - lists.koha-community.org

[Bug 7387] Add Template::Toolkit plugin to allow caching of includes
by bugzilla-daemon＠bugs.koha-community.org 12 Jan '24

12 Jan '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7387 Jonathan Druart <jonathan.druart+koha(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35793 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35793 [Bug 35793] Remove Koha::Template::Plugin::Cache -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 35791] New: Remove deprecated TT methods
by bugzilla-daemon＠bugs.koha-community.org 12 Jan '24

12 Jan '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35791 Bug ID: 35791 Summary: Remove deprecated TT methods Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: jonathan.druart+koha(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org Depends on: 35781 We should remove in 24.11 the TT methods we have marked as deprecated in bug 35781 (and friends). Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35781 [Bug 35781] [omnibus] Remove unneeded Koha::Template::Plugin methods -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 1

[Bug 34866] New: Use template wrapper for breadcrumbs: OPAC part 4
by bugzilla-daemon＠bugs.koha-community.org 12 Jan '24

12 Jan '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34866 Bug ID: 34866 Summary: Use template wrapper for breadcrumbs: OPAC part 4 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: OPAC Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org CC: testopia(a)bugs.koha-community.org Depends on: 34849 To continue the process started by Bug 32507, this patch will update several templates in the OPAC so that they use the template wrapper for breadcrumbs. - opac-registration-confirmation.tt - opac-registration-email-sent.tt - opac-registration-invalid.tt - opac-request-article.tt - opac-reserve.tt - opac-results.tt - opac-serial-issues.tt - opac-shareshelf.tt - opac-showreviews.tt - opac-suggestions.tt - opac-tags_subject.tt - opac-topissues.tt - svc/suggestion.tt Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34849 [Bug 34849] Use template wrapper for breadcrumbs: OPAC part 1 -- You are receiving this mail because: You are watching all bug changes.

1 18

[Bug 35730] New: No translation is required
by bugzilla-daemon＠bugs.koha-community.org 12 Jan '24

12 Jan '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35730 Bug ID: 35730 Summary: No translation is required Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: translate.koha-community.org Assignee: koha-bugs(a)lists.koha-community.org Reporter: Igor.A.Sychev(a)mail.ru QA Contact: testopia(a)bugs.koha-community.org %s%sISBN: %s%s%s; %s%s%s%s -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 1

[Bug 35786] New: Payment type "0" can be added but can not be archived/restored
by bugzilla-daemon＠bugs.koha-community.org 12 Jan '24

12 Jan '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35786 Bug ID: 35786 Summary: Payment type "0" can be added but can not be archived/restored Change sponsored?: --- Product: Koha Version: 23.11 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Fines and fees Assignee: koha-bugs(a)lists.koha-community.org Reporter: lmstrand(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org The value "0" as a payment type code prevents it from getting archived/restored. The staff interface gives you a yellow warning box with the text "error_on_archive/restore". Creation of the payment type works fine. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0

[Bug 35731] New: No translation is required
by bugzilla-daemon＠bugs.koha-community.org 12 Jan '24

12 Jan '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35731 Bug ID: 35731 Summary: No translation is required Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: translate.koha-community.org Assignee: koha-bugs(a)lists.koha-community.org Reporter: Igor.A.Sychev(a)mail.ru QA Contact: testopia(a)bugs.koha-community.org %sLCCN: %s%s%s -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 1

[Bug 13345] Choose the format for the attached file when sending a basket/list by email
by bugzilla-daemon＠bugs.koha-community.org 12 Jan '24

12 Jan '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13345 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Choose the format when |Choose the format for the |sending a basket/list by |attached file when sending |email |a basket/list by email -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14293] Error in the calculation of the suspension of users per day
by bugzilla-daemon＠bugs.koha-community.org 12 Jan '24

12 Jan '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14293 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion --- Comment #58 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- QA Comment: Code changes look good to me. Fixed test in a follow-up. The only thing remaining is the discussion about the rounding (changing from floor to ceil). I will pass QA if we change it back for current behavior. If we do not want to change it, please provide evidence for community consensus about that change. You could do so by mailing the lists or putting on the dev meeting agenda, etc. Putting on ID for now. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14293] Error in the calculation of the suspension of users per day
by bugzilla-daemon＠bugs.koha-community.org 12 Jan '24

12 Jan '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14293 --- Comment #57 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 160925 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160925&action=e… Bug 14293: (QA follow-up) Remove copy and paste test The comment is in contradiction with the code. The test has been copied. Not needed to repeat it. Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14293] Error in the calculation of the suspension of users per day
by bugzilla-daemon＠bugs.koha-community.org 12 Jan '24

12 Jan '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14293 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159504|0 |1 is obsolete| | --- Comment #56 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 160924 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160924&action=e… Bug 14293: The suspension should be calculated in days There was a mismatch between bug 13909 and bug 5549. The get_chargeable_units call from _debar_user_on_return should specify that we want a suspension in days. However I don't understand the comment let by the author of bug 5549 f61a9617184ec4b24100c1d99150bfd4ebf13336 1/ > finedays is in days, so hourly loans must multiply by 24 Yes but the suspension is in days, so no need to * 24 2/ And we should have a look on this one too: > grace period is measured in the same units as the loan But the grace period is always in days. On the circ rules the column is "Fine grace period (day)". I think we should replace DateTime::Duration->new( $unit => $issuingrule->{firstremind} ); with DateTime::Duration->new( days => $issuingrule->{firstremind} ); Anyway, we definitelly need more tests in this area! Test plan: 1/ Define an issuing rule with a unit=hour 2/ Set a suspension in days 3/ Check an item out and specify a past due date. 4/ Check the item in 5/ The patron should be debarred correctly Signed-off-by: David Nind <david(a)davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0