March 2024 - Koha-bugs - lists.koha-community.org

[Bug 24494] New: 00-valid-xml.t shouldn't check node_modules
by bugzilla-daemon＠bugs.koha-community.org 25 Jul '24

25 Jul '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24494 Bug ID: 24494 Summary: 00-valid-xml.t shouldn't check node_modules Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: chris(a)bigballofwax.co.nz Reporter: victor(a)tuxayo.net QA Contact: testopia(a)bugs.koha-community.org node_modules exists when generating the CSS from the SCSS with yarn. And it contains invalid XML file. Which shouldn't be validated by Koha's test suite. ./node_modules/json-schema/draft-zyp-json-schema-03.xml ./node_modules/json-schema/draft-zyp-json-schema-04.xml -- You are receiving this mail because: You are watching all bug changes.

1 19

[Bug 36044] New: Purchase suggestions on OPAC should show ISBN number
by bugzilla-daemon＠bugs.koha-community.org 25 Jul '24

25 Jul '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36044 Bug ID: 36044 Summary: Purchase suggestions on OPAC should show ISBN number Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: OPAC Assignee: oleonard(a)myacpl.org Reporter: mirjam.vantieghem(a)etf.edu QA Contact: testopia(a)bugs.koha-community.org The list of submitted purchase suggestions in the OPAC patron account should also show the ISBN if this was filled in on the suggestion form. -- You are receiving this mail because: You are watching all bug changes.

1 13

[Bug 27631] New: Accessibility: Staff Client - <h1> on each page is Logo but should be page description/title
by bugzilla-daemon＠bugs.koha-community.org 25 Jul '24

25 Jul '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 Bug ID: 27631 Summary: Accessibility: Staff Client - <h1> on each page is Logo but should be page description/title Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs(a)lists.koha-community.org Reporter: wainuiwitikapark(a)catalyst.net.nz QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com The main heading <h1> of each page in Koha should describe the topic or purpose of the page. At the moment, the <h1> of each page looks like: <h1 id="logo"> <a class="navbar-brand" href="/cgi-bin/koha/opac-main.pl"> Library Name</a> </h1> It makes more sense and would be more helpful to ensure the heading has a descriptor of the page that they're on, rather than no description surrounding a link containing the name of the library. The following WCAG2.1 page explains this further: https://www.w3.org/WAI/WCAG21/Techniques/general/G130 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25155#c12 raises a question of what navigation items should be if h1 is move to the main content, and here is a page which shows that it is acceptable to have h2 that come before the h1 in the content, see example 2: https://www.w3.org/WAI/tutorials/page-structure/headings/ First, let's remove the <h1> tag from around the Logo link This bug will depend on correcting the headings on each page of the Staff Client -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 165

[Bug 27740] New: Accessibility: OPAC - Headings should have correct tags and hierarchy
by bugzilla-daemon＠bugs.koha-community.org 25 Jul '24

25 Jul '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27740 Bug ID: 27740 Summary: Accessibility: OPAC - Headings should have correct tags and hierarchy Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard(a)myacpl.org Reporter: wainuiwitikapark(a)catalyst.net.nz QA Contact: testopia(a)bugs.koha-community.org Each page of the OPAC should contain correct headings with correct heading tags and hierarchy. Please see https://www.w3.org/WAI/tutorials/page-structure/headings/ for more information. https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27610 dealt with changing the logo on each page to be a <div> instead of an <h1> and then ensuring each page has one <h1> that tells users what the page is about. This bug will deal with ensuring the rest of the headings in each page follow the correct heading hierarchy, and headings don't skip a level. -- You are receiving this mail because: You are watching all bug changes.

1 62

[Bug 27742] New: Accessibility: OPAC - Page titles should have unique information first
by bugzilla-daemon＠bugs.koha-community.org 25 Jul '24

25 Jul '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27742 Bug ID: 27742 Summary: Accessibility: OPAC - Page titles should have unique information first Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard(a)myacpl.org Reporter: wainuiwitikapark(a)catalyst.net.nz QA Contact: testopia(a)bugs.koha-community.org Koha has good and descriptive page titles, but according to https://www.w3.org/WAI/tips/writing/ the unique information should be first, before the name of the website (Koha). -- You are receiving this mail because: You are watching all bug changes.

1 21

[Bug 22576] New: OPAC password change text changes
by bugzilla-daemon＠bugs.koha-community.org 25 Jul '24

25 Jul '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22576 Bug ID: 22576 Summary: OPAC password change text changes Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard(a)myacpl.org Reporter: wizzyrea(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org Target Milestone: --- A borrower changing their password from the logged in password change functionality might see some awkward text messages, specifically: - "Return to your record" after changing the password, I propose "Return to my account" (since that's what the borrower probably wants to do). - "Submit changes" to change the password should be "Change password" just to be really clear about what is going to happen when the button is clicked. -- You are receiving this mail because: You are watching all bug changes.

1 10

[Bug 20623] New: PDF export of a basket group fails when an item as an itemtype is not in the itemtype table
by bugzilla-daemon＠bugs.koha-community.org 25 Jul '24

25 Jul '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20623 Bug ID: 20623 Summary: PDF export of a basket group fails when an item as an itemtype is not in the itemtype table Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Acquisitions Assignee: koha-bugs(a)lists.koha-community.org Reporter: victor.grousset(a)biblibre.com QA Contact: testopia(a)bugs.koha-community.org Does it matter? Yes, using authorized values like ccode to populate the itemtypes of the biblioitems (instead of the itemtype table) can lead to such data. Or importing records with invalid itemtype codes. Koha doesn't do enough checks to at least warn about these issues. == Reproduce == 1. have/create a budget 2. have/create a fund 3. have/create a vendor with minimal info 4. create a basket with minimal info 5. add a item to the basket 6. go to the basket. URL should be /cgi-bin/koha/acqui/basket.pl?basketno=XXXXX 7. close this basket 8. create a basket group with the basket - your vendor page => Basket groups - create basket group - (tick the "close this basket group" check box) 9. go to the basket group your vendor page => Basket groups => Closed 10. export as PDF, it should work, keep the page opened 11. find the itemtype code of item in the basket 12. delete it with the following SQL[1] (directly or use sql reports) replace with the relevant type code DELETE from itemtypes where itemtype = "BOOK"; 13. reexport the basket as PDF 14. It should fail (internal server error) [1] Or you can find a more realistic way to have a biblioitem whose itemtype is not in the itemtype table -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 31

[Bug 20084] New: Patron card creator: layout: Industrial2of5 broken with "Invalid Characters" error
by bugzilla-daemon＠bugs.koha-community.org 25 Jul '24

25 Jul '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20084 Bug ID: 20084 Summary: Patron card creator: layout: Industrial2of5 broken with "Invalid Characters" error Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Tools Assignee: koha-bugs(a)lists.koha-community.org Reporter: victor.grousset(a)biblibre.com QA Contact: testopia(a)bugs.koha-community.org ## Reproduction ## This is an oversimplification of a full patron card setup used in production. 1. Create a batch with 1 patron 2. Create a layout and set the name "Print card number as barcode" "Barcode type:" to "Code 39" 3. Create a card template without filling anything 4. Export the batch using the layout and template 5. You should have a white page with a barcode This show that this setup isn't completely bogus (although Code 39 is the only type working) 6. Export the batch 7. You should have a white page with a barcode And no errors in the relevant log file 8. Layout: set "Barcode type:" to Industrial2of5 9. Export the batch 10. You should have a white page with no barcode And errors in the relevant log file "Invalid Characters" ## Going further ## COOP2of5 fails also with the same error TODO: Fix at the same time or open another bug -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 25

[Bug 27610] New: Accessibility: OPAC - <h1> on each page is Logo but should be page description/title
by bugzilla-daemon＠bugs.koha-community.org 25 Jul '24

25 Jul '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27610 Bug ID: 27610 Summary: Accessibility: OPAC - <h1> on each page is Logo but should be page description/title Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard(a)myacpl.org Reporter: wainuiwitikapark(a)catalyst.net.nz QA Contact: testopia(a)bugs.koha-community.org The main heading <h1> of each page in Koha should describe the topic or purpose of the page. At the moment, the <h1> of each page looks like: <h1 id="logo"> <a class="navbar-brand" href="/cgi-bin/koha/opac-main.pl"> Library Name</a> </h1> It makes more sense and would be more helpful to ensure the heading has a descriptor of the page that they're on, rather than no description surrounding a link containing the name of the library. The following WCAG2.1 page explains this further: https://www.w3.org/WAI/WCAG21/Techniques/general/G130 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25155#c12 raises a question of what navigation items should be if h1 is move to the main content, and here is a page which shows that it is acceptable to have h2 that come before the h1 in the content, see example 2: https://www.w3.org/WAI/tutorials/page-structure/headings/ First, let's remove the <h1> tag from around the Logo link This bug will depend on correcting the headings on each page of the OPAC -- You are receiving this mail because: You are watching all bug changes.

1 59

[Bug 22616] New: updating error text messages
by bugzilla-daemon＠bugs.koha-community.org 25 Jul '24

25 Jul '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22616 Bug ID: 22616 Summary: updating error text messages Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs(a)lists.koha-community.org Reporter: wizzyrea(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com Target Milestone: --- There were multiple error messages in the staff client that had slightly awkward text, for example: "This patron does not exist" should be "Patron not found." "This $thing does not exist" should be "$thing not found." "Find another $thing?" should be "Return to search." "You are not allowed to see the information of this patron" should be "This account cannot view requested patron information" - this change makes it less personal, and might remind a person to check another account or to ask a supervisor if access is really required. I say this because it's not always the *person* who can't see a patron record, but the account that is currently logged in. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 10