March 2024 - Koha-bugs - lists.koha-community.org

[Bug 15565] Place multiple item-level holds at once for the same record
by bugzilla-daemon＠bugs.koha-community.org 12 Mar '24

12 Mar '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 --- Comment #295 from Lisette Scheer <lisette.scheer(a)bywatersolutions.com> --- Created attachment 163093 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163093&action=e… Bug 15565: Place multiple holds on one record on staff interface Signed-off-by: Lisette Scheer <lisette(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15565] Place multiple item-level holds at once for the same record
by bugzilla-daemon＠bugs.koha-community.org 12 Mar '24

12 Mar '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 Lisette Scheer <lisette.scheer(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163052|0 |1 is obsolete| | --- Comment #294 from Lisette Scheer <lisette.scheer(a)bywatersolutions.com> --- Created attachment 163092 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163092&action=e… Attachment to Bug 15565 - Place multiple item-level holds at once for the same record Bug 15565: Place multiple holds on one record on staff interface Signed-off-by: Lisette Scheer <lisette(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15565] Place multiple item-level holds at once for the same record
by bugzilla-daemon＠bugs.koha-community.org 12 Mar '24

12 Mar '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 Lisette Scheer <lisette.scheer(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 35955] New CSRF token generated everytime we need one
by bugzilla-daemon＠bugs.koha-community.org 12 Mar '24

12 Mar '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35955 Fridolin Somers <fridolin.somers(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|24.05.00 |24.05.00,23.11.04 released in| | --- Comment #15 from Fridolin Somers <fridolin.somers(a)biblibre.com> --- Pushed to 23.11.x for 23.11.04 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 35955] New CSRF token generated everytime we need one
by bugzilla-daemon＠bugs.koha-community.org 12 Mar '24

12 Mar '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35955 --- Comment #14 from Fridolin Somers <fridolin.somers(a)biblibre.com> --- OK thanks, will do -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 34478] Full CSRF protection
by bugzilla-daemon＠bugs.koha-community.org 12 Mar '24

12 Mar '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34478 --- Comment #186 from Fridolin Somers <fridolin.somers(a)biblibre.com> --- OK thanks for your comments. For the moment no backport -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15516] Allow to place a hold on first available item from a group of titles
by bugzilla-daemon＠bugs.koha-community.org 12 Mar '24

12 Mar '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #471 from David Cook <dcook(a)prosentient.com.au> --- As I've noted before, trying to count multiple hold group members as part of the same hold has some fundamental problems. We'd need to pass the hold group to CanBookBeReserved/CanItemBeReserved to handle this better... It's tempting to spin out a new report just for refactoring those functions to take $args instead. I want to make an API endpoint at some point too for whether or not a reserve can be placed. I think National Library of Finland have done work on this, although it's more discovery interface specific so might not quite meet what I'd want it for... -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15516] Allow to place a hold on first available item from a group of titles
by bugzilla-daemon＠bugs.koha-community.org 12 Mar '24

12 Mar '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 David Cook <dcook(a)prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Failed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15516] Allow to place a hold on first available item from a group of titles
by bugzilla-daemon＠bugs.koha-community.org 12 Mar '24

12 Mar '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #470 from David Cook <dcook(a)prosentient.com.au> --- Comment on attachment 162078 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162078 Bug 15516: Relevant controller changes and tests Review of attachment 162078: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=155…) ----------------------------------------------------------------- ::: Koha/Holds.pm @@ +213,5 @@ > + > +sub count_holds { > + my ( $self, $search_params ) = @_; > + > + $search_params = { These $search_params lines redefine the variable instead of updating the variable. This means that you end up selecting all holds and not just the holds for particular criteria (like an individual patron). -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15516] Allow to place a hold on first available item from a group of titles
by bugzilla-daemon＠bugs.koha-community.org 12 Mar '24

12 Mar '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #469 from David Cook <dcook(a)prosentient.com.au> --- Found a nasty bug in Koha::Holds->count_holds(). I'm going to need to review this code in-depth again... -- You are receiving this mail because: You are watching all bug changes.

1 0