June 2024 - Koha-bugs - lists.koha-community.org

[Bug 32900] New: Curbside pickups - "Please fill in this field" tip is untranslatable
by bugzilla-daemon＠bugs.koha-community.org 11 Sep '24

11 Sep '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32900 Bug ID: 32900 Summary: Curbside pickups - "Please fill in this field" tip is untranslatable Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs(a)lists.koha-community.org Reporter: caroline.cyr-la-rose(a)inlibro.com QA Contact: testopia(a)bugs.koha-community.org CC: frederic(a)tamil.fr When scheduling a pickup, there is a tip when you hover the cursor on the date field that says "Please fill in this field". I could not find this string anywhere in the .po files, even after an update. To get this string: 1. Enable the CurbsidePickup system preference 2. Set up curbside pickup for a library (e.g. Centerville) 2.1. Go to Administration > Curbside pickup 2.2. Click the tab for the library 2.3. Fill out the form: - Enable: Check - Pickup interval: 10 (or other) - Maximum patrons per interval: 3 (or other) - Patron-scheduled pickup: leave unchecked - Enable for waiting holds only: leave unchecked 2.4. Enter a couple of time periods (e.g. - Day: Sunday - From: 10:00 - To: 12:00 2.5. Click 'Add' 2.6. Click 'Save configuration' 3. Schedule a pickup, hover over the date field 3.1. Go to Circulation > Curbside pickups 3.2. Click 'Schedule pickup' 3.3. Search for a patron name (e.g. Henry) 3.4. Hover the cursor on the date field --> The tip says "Please fill in this field." To translate : cd misc/translator ./translate update xx-XX git grep "Please fill in this field" --> No result -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 3

[Bug 25621] New: Some tests in t/DateUtils.t fail when timezone is not UTC
by bugzilla-daemon＠bugs.koha-community.org 11 Sep '24

11 Sep '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25621 Bug ID: 25621 Summary: Some tests in t/DateUtils.t fail when timezone is not UTC Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Test Suite Assignee: julian.maurice(a)biblibre.com Reporter: julian.maurice(a)biblibre.com QA Contact: testopia(a)bugs.koha-community.org To reproduce: 1. Verify that TZ environment variable is not defined 2. Verify that $KOHA_CONF does not contain <timezone> 3. Run `date` to verify that you have a local time different than UTC 4. prove t/DateUtils.t Expected output: % prove t/DateUtils.t t/DateUtils.t .. 1/76 # Failed test 'dt_from_string handles seconds with 1 decimal place' # at t/DateUtils.t line 130. # got: '1325447940' # expected: '1325462340' # Failed test 'dt_from_string handles seconds with 2 decimal places' # at t/DateUtils.t line 133. # got: '1325447940' # expected: '1325462340' # Failed test 'dt_from_string handles seconds with 3 decimal places' # at t/DateUtils.t line 136. # got: '1325447999' # expected: '1325462399' # Failed test 'dt_from_string handles seconds with 3 decimal places and a timezone' # at t/DateUtils.t line 139. # got: '1325447999' # expected: '1325462399' # Looks like you failed 4 tests of 76. -- You are receiving this mail because: You are watching all bug changes.

1 7

[Bug 30540] New: Double processing invalid dates can lead to ISE
by bugzilla-daemon＠bugs.koha-community.org 11 Sep '24

11 Sep '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30540 Bug ID: 30540 Summary: Double processing invalid dates can lead to ISE Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: martin.renvoize(a)ptfs-europe.com QA Contact: testopia(a)bugs.koha-community.org In the KohaDates filter we process our passed date using dt_from_string before passing it to output_pref. dt_from_string handles bad dates in an eval block, falling back to assigning a floating timezone. However, in the subsequent call to output_pref we try to set the timezone a second time and this time it is not in an eval and so will throw an internal server error for such dates. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 29

[Bug 35666] New: Make it possible to cancel the transfer of the item
by bugzilla-daemon＠bugs.koha-community.org 11 Sep '24

11 Sep '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35666 Bug ID: 35666 Summary: Make it possible to cancel the transfer of the item Change sponsored?: --- Product: Koha Version: 22.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: kati.sillgren(a)porvoo.fi QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com Record information page (catalogue/detail.pl): make it possible to cancel the transfer of the item when it is not in transit due to reservation. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 5

[Bug 21559] New: Rules for automatic framework codes
by bugzilla-daemon＠bugs.koha-community.org 11 Sep '24

11 Sep '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21559 Bug ID: 21559 Summary: Rules for automatic framework codes Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: new feature Priority: P5 - low Component: Cataloging Assignee: koha-bugs(a)lists.koha-community.org Reporter: pasi.kallinen(a)joensuu.fi QA Contact: testopia(a)bugs.koha-community.org CC: m.de.rooy(a)rijksmuseum.nl Allow setting rules in a system preference, what framework code should be automatically set for biblio, based on the MARC record fields. Does not affect anything if the MarcToFrameworkcodeAutoconvert system preference rules aren't used. The "Default" framework is always overridden, if the rules match, but some other framework chosen by you is always used. Explanation of the rule format: ------------------------------- The syspref is YAML, with a specific format: - <field> <value>: <frameworkcode> If the <field> in the record contains <value>, the <frameworkcode> is used for the record. <field> is one of: "xxx" (field xxx in the MARC record) "xxx/yy" (field xxx, character location yy) "xxx/yy-zz" (field xxx, character locations yy-zz) "xxx$v" (field xxx, subfield v) Fields can be combined with plus-sign, then the field values have plus-sign between them. The field-rules are checked in order from top to bottom, and the first rule with a matching value is used. If the (sub)field has been repeated in the MARC record, only the first matching (sub)field is checked. If none of the rules match, the framework code is not changed. Example: - 008/35-37 + 000/06: fin+a: BKSFIN - 000/06: a: BKS c: MU e: MP This would make record with 000/06 = "a" AND 008/35-37 = "fin" use the BKSFIN framework, and any other record with 000/06 = "a" use BKS, 000/06 = "c" would be MU, and 000/06 = "e" would give MP -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 22

[Bug 37161] New: After deleting a tag in a MARC framework, template doesn't do the [% IF ( delete_confirmed ) %] stuff
by bugzilla-daemon＠bugs.koha-community.org 11 Sep '24

11 Sep '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37161 Bug ID: 37161 Summary: After deleting a tag in a MARC framework, template doesn't do the [% IF ( delete_confirmed ) %] stuff Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: phil(a)chetcolibrary.org QA Contact: testopia(a)bugs.koha-community.org CC: emily.lamancusa(a)montgomerycountymd.gov In older versions (I tested in 23.05.11 since I had it handy), when you edit a MARC framework and delete a tag, you get a page saying "Tag deleted" with an OK button, and clicking the button reloads the framework you were in (though not exactly the way it was originally inteded to, since it's supposed to reload with a search for the tagnumber, so you wind up in the same place you were). In main, you don't get the "Tag deleted", which is inside an [% IF ( delete_confirmed ) %]. I don't see what magic was ever setting delete_confirmed, unless it was set by that being the name of the $op back before it became cud-delete_confirmed. https://git.koha-community.org/Koha-community/Koha/src/commit/582d6916c9a4e… explicitly sets it, but I don't see where anything else does, and if the magic was coming from the $op, then there's a whole bunch more things that need to be fixed to set it. -- You are receiving this mail because: You are watching all bug changes.

1 24

[Bug 37127] New: Authorized value select not working on authority forms.
by bugzilla-daemon＠bugs.koha-community.org 11 Sep '24

11 Sep '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37127 Bug ID: 37127 Summary: Authorized value select not working on authority forms. Change sponsored?: --- Product: Koha Version: 24.05 Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Cataloging Assignee: koha-bugs(a)lists.koha-community.org Reporter: kdask(a)altsol.gr QA Contact: testopia(a)bugs.koha-community.org CC: m.de.rooy(a)rijksmuseum.nl When connecting an authorized value on a subfield on Authority Type framework configuration (Example: 040$b - Authorized value: LANG) the Select widget (Select2?) on the cataloging form (Edit/New) is not working. This seems to happen for any connection on any authorized values/subfields only on authorities cataloging. Tried creating new authorized value category etc, but the behavior is the same. Thanks -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 14

[Bug 37165] New: Can't edit frequencies due to stray cud- in modify op
by bugzilla-daemon＠bugs.koha-community.org 11 Sep '24

11 Sep '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37165 Bug ID: 37165 Summary: Can't edit frequencies due to stray cud- in modify op Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Serials Assignee: phil(a)chetcolibrary.org Reporter: phil(a)chetcolibrary.org QA Contact: testopia(a)bugs.koha-community.org Blocks: 36192 serials/subscription-frequencies.pl has two modify ops: a POST with cud-savemod changes the frequency, and a GET with modify loads the editing form, except that was changed to cud-modify when it shouldn't have been. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36192 [Bug 36192] [OMNIBUS] CSRF Protection for Koha -- You are receiving this mail because: You are watching all bug changes.

1 13

[Bug 37152] New: Delete-confirm should not start with 'cud-'
by bugzilla-daemon＠bugs.koha-community.org 10 Sep '24

10 Sep '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37152 Bug ID: 37152 Summary: Delete-confirm should not start with 'cud-' Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: emily.lamancusa(a)montgomerycountymd.gov QA Contact: testopia(a)bugs.koha-community.org Blocks: 36192 There are a number of pages that use the op delete_confirm to display a confirmation page before deleting an object, followed by the op cud-delete_confirm*ed* to actually perform the delete operation. A few pages slipped through that are expecting an op of cud-delete_confirm, which should not start with 'cud-': - acqui/basket.pl and basket.tt - opac/opac-suggestions.pl and opac-suggestions.tt - admin/auth-tag-structure.pl - admin/categories.pl - admin/aqcontract.pl - admin/marctagstructure.pl None of these broke functionality for me when I tested them - the first two because at least the .pl and .tt files align, and I'm not sure why the last four didn't break. Either way, they should still be brought in line with the coding guideline. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36192 [Bug 36192] [OMNIBUS] CSRF Protection for Koha -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 29

[Bug 37190] New: form-submit.js data- attributes should use lowercase attribute names
by bugzilla-daemon＠bugs.koha-community.org 10 Sep '24

10 Sep '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37190 Bug ID: 37190 Summary: form-submit.js data- attributes should use lowercase attribute names Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: lucas(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org If I try to add a link as a form ( see Bug 36246 ) I cannot pass the data-confirmationMsg attribute with $('.submit-form-link').data(); This is because data attribute names always get read in lowercase. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 9