June 2024 - Koha-bugs - lists.koha-community.org

[Bug 32928] New: Filters missing in SQL builder on Orders::filter_by_active
by bugzilla-daemon＠bugs.koha-community.org 20 Aug '26

20 Aug '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32928 Bug ID: 32928 Summary: Filters missing in SQL builder on Orders::filter_by_active Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs(a)lists.koha-community.org Reporter: thibaud.guillot(a)biblibre.com QA Contact: testopia(a)bugs.koha-community.org Since version 21.xx.xx there has been a change in the way to retrieve the data of the orders to receive. The table is built from a call to the API and then the data can be filtered. Bug_20212 has integrated this change. This is a good thing but two filters are missing on the query construction in the Koha::Acquisition::Orders::filter_by_active function Here is the query in version 20.11 : <pre> SELECT aqbasket.basketno, borrowers.surname, borrowers.firstname, biblio.*, biblioitems.isbn, biblioitems.biblioitemnumber, biblioitems.publishercode, biblioitems.publicationyear, aqbasket.authorisedby, aqbasket.booksellerid, aqbasket.closedate, aqbasket.creationdate, aqbasket.basketname, aqbasketgroups.id as basketgroupid, aqbasketgroups.name as basketgroupname, aqorders.* FROM aqorders LEFT JOIN aqbasket ON aqorders.basketno = aqbasket.basketno LEFT JOIN aqbasketgroups ON aqbasket.basketgroupid = aqbasketgroups.id LEFT JOIN borrowers ON aqbasket.authorisedby=borrowers.borrowernumber LEFT JOIN biblio ON aqorders.biblionumber=biblio.biblionumber LEFT JOIN biblioitems ON biblioitems.biblionumber=biblio.biblionumber WHERE (datecancellationprinted is NULL) AND ( ( aqbasket.is_standing AND aqorders.orderstatus IN ( "new", "ordered", "partial" ) ) OR ( ( quantity > quantityreceived OR quantityreceived is NULL ) AND aqorders.orderstatus IN ( "ordered", "partial" ) ) ) AND aqbasket.booksellerid = ? ORDER BY aqbasket.basketno'; </pre> The condition "datecancellationprinted is NULL" is missing as well as the quantity control to display the results only if there are still quantities to receive. And so the result on the same database between the different versions can be very different! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 15

[Bug 19938] New: Refactor C4::Overdues::checkoverdues
by bugzilla-daemon＠bugs.koha-community.org 19 Aug '26

19 Aug '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19938 Bug ID: 19938 Summary: Refactor C4::Overdues::checkoverdues Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: mtompset(a)hotmail.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com While retesting a bug, I ran a prove -r -v t, which generated a lot of log noise. One such entry was: [Tue Jan 9 03:54:58 2018] starman: Use of uninitialized value $overdues_count in numeric gt (>) at /home/vagrant/kohaclone/opac/opac-main.pl line 76. The $overdues_count was set by a call to checkoverdues. Reading the code I noticed someone actually commented: # returning the count and the results is silly So, this is a refactor of the function and all the calls. It was surprisingly small. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 41

[Bug 34907] New: Load datatables on CMS pages
by bugzilla-daemon＠bugs.koha-community.org 19 Aug '26

19 Aug '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34907 Bug ID: 34907 Summary: Load datatables on CMS pages Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs(a)lists.koha-community.org Reporter: lisette.scheer(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org It would be nice we loaded/could optionally load datatables on custom pages for table consistency. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 8

[Bug 24403] New: [OMNIBUS] OpacHiddenItems should hide items everywhere in the OPAC
by bugzilla-daemon＠bugs.koha-community.org 19 Aug '26

19 Aug '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24403 Bug ID: 24403 Summary: [OMNIBUS] OpacHiddenItems should hide items everywhere in the OPAC Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard(a)myacpl.org Reporter: katrin.fischer(a)bsz-bw.de QA Contact: testopia(a)bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes.

1 50

[Bug 31011] New: Make hold reminders respect patron's language
by bugzilla-daemon＠bugs.koha-community.org 19 Aug '26

19 Aug '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31011 Bug ID: 31011 Summary: Make hold reminders respect patron's language Change sponsored?: --- Product: Koha Version: 20.11 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Hold requests Assignee: koha-bugs(a)lists.koha-community.org Reporter: magnus(a)libriotech.no QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com When running misc/cronjobs/holds/holds_reminder.pl it looks like borrowers.lang is not respected. The only code I can see that relates to language is this: # FIXME What if we don't want to default if the translated template does not exist? my $template_exists = Koha::Notice::Templates->find_effective_template( { module => 'reserves', code => $lettercode, branchcode => $branchcode, lang => 'default', } ); As far as I can see, the "default" template is always used? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 4

[Bug 23756] New: Appendix for workflows
by bugzilla-daemon＠bugs.koha-community.org 19 Aug '26

19 Aug '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23756 Bug ID: 23756 Summary: Appendix for workflows Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Documentation Assignee: koha-bugs(a)lists.koha-community.org Reporter: cbrannon(a)cdalibrary.org QA Contact: testopia(a)bugs.koha-community.org Wondering if the documentation should include workflow examples for different tasks. I know how different each library can be with their workflows, but workflows seem to be a common topic, and there are multiple ways to approach different tasks. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 8

[Bug 36369] New: Make APIClient be more useful
by bugzilla-daemon＠bugs.koha-community.org 18 Aug '26

18 Aug '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36369 Bug ID: 36369 Summary: Make APIClient be more useful Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: tomascohen(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org I file this report for discussion. In my opinion, there's too much duplicated code on the API client libraries. And the APIClient "class" is just a shortcut to avoid instantiating the module-specific API clients: ```javascript import ERMAPIClient from "./erm-api-client"; ... export const APIClient = { erm: new ERMAPIClient(), ``` Then used everywhere like this: ```javascript import { APIClient } from "../../fetch/api-client.js" ... const client = APIClient.erm await client.agreements.count().then( ``` IMHO, we need a real APIClient class that would implement generic methods like: ```javascript create: params => this.post({ endpoint: params.endpoint ? params.endpoint : "/", body: params.resource, headers: params.headers }), ... getAll: params => this.get({ endpoint: params.endpoint ? params.endpoint : "/", params.query, headers: params.headers, }), ... count: params => this.count({ endpoint: params.endpoint ? params.endpoint : "/", "?" + new URLSearchParams({ _page: 1, _per_page: 1, ...(params.query && { q: JSON.stringify(params.query) }), }), }), ``` and the API Client classes (like ERMAPIClient) should inherit from it, somehow. For doing so, we will face another design roadblock: While I uderstand that ERMAPIClient is a single place to have all the ERM module-needed API actions, it still feels weird from an OOP perspective how things are organized. I feel like we should have individual classes, like: ```javascript export RecordSourcesAPIClient extends APIClient ``` and then have a new type of class along this lines: ```javascript import CitiesAPIClient from "./cities-api-client"; import RecordSourcesAPIClient from "./record-sources-api-client"; ... export const AdminAPIClient = { cities: new CitiesAPIClient(), record_sources: new RecordSourcesAPIClient(), ... }; ``` this way, we will avoid repeating ourselves (less bugs!) and the code is (I expect) more reusable. I also think the `embed` handling should just be a list for the different methods, like: embed: [ 'patron', 'patron.category' ] and generically handled by APIClient. No need to build the headers manually everywhere. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 59

[Bug 23258] New: Batch holding
by bugzilla-daemon＠bugs.koha-community.org 18 Aug '26

18 Aug '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23258 Bug ID: 23258 Summary: Batch holding Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs(a)lists.koha-community.org Reporter: matthias.meusburger(a)biblibre.com QA Contact: testopia(a)bugs.koha-community.org Add a "batch holding" tool (just like batch item modification, batch patron deletion...) This tool would allow to place or cancel holds in batch. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 53

[Bug 28085] New: Add "Forget" link for search to hold feature to detail page
by bugzilla-daemon＠bugs.koha-community.org 17 Aug '26

17 Aug '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28085 Bug ID: 28085 Summary: Add "Forget" link for search to hold feature to detail page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs(a)lists.koha-community.org Reporter: katrin.fischer(a)bsz-bw.de QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com When using the "Search to hold" feature from the patron account, there is an option on the result page to "forget" the current selected user. We should also have this link on the hold pull down on the catalog detail page. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 3

[Bug 32980] New: Checkouts for guarantees are not shown if patron also has a guarantor
by bugzilla-daemon＠bugs.koha-community.org 17 Aug '26

17 Aug '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32980 Bug ID: 32980 Summary: Checkouts for guarantees are not shown if patron also has a guarantor Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Circulation Assignee: julian.maurice(a)biblibre.com Reporter: julian.maurice(a)biblibre.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com Steps to reproduce: 1. Create a patron category of type 'Professional' (or any type that allows guarantors) 2. Create 3 patrons in this category. Let's call them A, B, and C 3. Do at least one checkout for A and at least one for C 4. Make B the guarantor of C 5. Go to B details page. You should see the checkouts of C in the "Relatives' checkouts" tab 6. Go to B checkout page. You should see the checkouts of C in the "Relatives' checkouts" tab 7. Make A the guarantor of B 8. Go to B details page. Now you should see the checkouts of A in the "Relatives' checkouts" tab but not the checkouts of C (KO) 9. Go to B checkout page. Now you should only the checkouts of A in the "Relatives' checkouts" tab but not the checkouts of C (KO) -- You are receiving this mail because: You are watching all bug changes.

1 29