September 2024 - Koha-bugs - lists.koha-community.org

[Bug 19306] New: Adding hooks to the plugin system
by bugzilla-daemon＠bugs.koha-community.org 01 Nov '24

01 Nov '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19306 Bug ID: 19306 Summary: Adding hooks to the plugin system Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: stefan.berndtsson(a)ub.gu.se QA Contact: testopia(a)bugs.koha-community.org We've been working on adding hook functionality to the existing plugin system. This is very much proof-of-concept code at the moment, but here is how it works. 1. Somewhere in the code you add a hook-call with a name for that hook, and pass in some data relevant to that hook. 2. Each plugin with a method matching the hook name is called in sequence, with the data as input and returning data of similar form, which is then passed on to the next matching plugin. 3. The end result is returned back from the hook-call, is put back in place, and code execution is resumed. The PoC code adds a Koha::Plugins::Handler->run_matching() method that looks up the relevant loaded plugins (using GetPlugins) and calls Koha::Plugins::Handler->run() on each of them. If plugins are not enabled, or if there is no plugin matching the hook, the input data is returned back, resulting in unaffected operation. One hook is added in Koha::SearchEngine::Elasticsearch::QueryBuilder.pm, in build_query_compat with the name "build_query_before", which is simply run before the query parsing takes place. A very simple example plugin is available at: https://github.com/ub-digit/koha-plugin-build-query-example/releases This plugin edits a query beginning with "Provider:" to do "publisher:" instead. A simple example that when using Elasticsearch makes publisher links in the bibliographic detail view clickable. The current XSLT uses the Zebra based links, that result in an unusable search. This is not meant to be the solution to the Zebra/Elasticsearch conflict in the XSLT, but it's a simple demonstration of the hook feature. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 15

[Bug 34662] New: Allow configuration of search type in main search bar
by bugzilla-daemon＠bugs.koha-community.org 31 Oct '24

31 Oct '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34662 Bug ID: 34662 Summary: Allow configuration of search type in main search bar Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff interface Assignee: koha-bugs(a)lists.koha-community.org Reporter: andrewfh(a)dubcolib.org QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com The top search bar defaults to different types of search depending on the page one is on. It would be helpful to make this configurable to allow for local preference. For example, when one is looking at a Normal view of a bib record (/cgi-bin/koha/catalogue/detail.pl?biblionumber=X), the top search bar defaults to Search the Catalog. But if one clicks to Holds on the same record (/cgi-bin/koha/reserve/request.pl?biblionumber=X), then the top search bar switches to Check Out. Our staff find this disruptive, but I don't expect a strong consensus across the community for how this should behave. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 2

[Bug 33480] New: Improve display of the vendor aliases in the ERM module
by bugzilla-daemon＠bugs.koha-community.org 31 Oct '24

31 Oct '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33480 Bug ID: 33480 Summary: Improve display of the vendor aliases in the ERM module Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: ERM Assignee: jonathan.druart+koha(a)gmail.com Reporter: jonathan.druart+koha(a)gmail.com CC: jonathan.druart+koha(a)gmail.com, jonathan.field(a)ptfs-europe.com, martin.renvoize(a)ptfs-europe.com, pedro.amorim(a)ptfs-europe.com Depends on: 33103 Coming from bug 33103 comment 34 """ I am not persuaded by the display tbh, I believe it will get messy very soon as often those aliases will be quite long and we might even want to record a slight name change. Could it be an option to show the aliases in the list as "second level" entries, kind of a hiearchical display, like we have it for funds? """ Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33103 [Bug 33103] Add vendor aliases -- You are receiving this mail because: You are watching all bug changes.

1 29

[Bug 37441] New: Sometimes images don't upload in Uploads Tool
by bugzilla-daemon＠bugs.koha-community.org 31 Oct '24

31 Oct '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37441 Bug ID: 37441 Summary: Sometimes images don't upload in Uploads Tool Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs(a)lists.koha-community.org Reporter: alexandre.noel(a)inlibro.com QA Contact: testopia(a)bugs.koha-community.org The file upload tool intermittently fails, causing the selected file to disappear without uploading. The second time we want to upload, it will work. Replicate: 1. Go to Tools > Uploads 2. Click "Choose file" and select any file (png, jpeg, pdf...) 3. Click "Upload" -> The file uploads successfully 4. Click "Delete" to remove the uploaded file. -> The page returns to the upload screen. Repeat steps 2 and 3. -> The selected file is deleted, and is not uploaded, requiring the process to be restarted. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 12

[Bug 26790] New: Refactor Koha configuration (koha-conf.xml)
by bugzilla-daemon＠bugs.koha-community.org 31 Oct '24

31 Oct '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26790 Bug ID: 26790 Summary: Refactor Koha configuration (koha-conf.xml) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: dcook(a)prosentient.com.au QA Contact: testopia(a)bugs.koha-community.org I propose moving /yazgfs/config out of koha-conf.xml and into koha-conf.yml (or even several different *-conf.yml files). The majority of the /yazgfs child nodes are actually configuration values for zebrasrv (ie Zebra). We should respect /yazgfs as Zebra configuration and leave it alone. I also propose we move from XML to YAML, as it's more human-friendly and it's easier to parse into the data structure that we need. XML::Simple, which is an obsolete module according to its creator, is currently used to parse koha-conf.xml and it's behaviour can be unpredictable. We should ideally eliminate our usage of it. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 29

[Bug 37303] New: Fuzzy translations displayed on the UI
by bugzilla-daemon＠bugs.koha-community.org 30 Oct '24

30 Oct '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37303 Bug ID: 37303 Summary: Fuzzy translations displayed on the UI Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: major Priority: P5 - low Component: I18N/L10N Assignee: jonathan.druart(a)gmail.com Reporter: jonathan.druart(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org CC: f.demians(a)tamil.fr, jonathan.druart(a)gmail.com When using __() (ie. Gettext.js) we are seeing the translations that are marked as fuzzy. This is definitely not the expected behaviour. It happens because (our version of) po2json are old and no longer maintained, and just embed them. -- You are receiving this mail because: You are watching all bug changes.

1 50

[Bug 38031] New: po2json not found
by bugzilla-daemon＠bugs.koha-community.org 30 Oct '24

30 Oct '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38031 Bug ID: 38031 Summary: po2json not found Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: major Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart(a)gmail.com Reporter: jonathan.druart(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org Depends on: 37303 If you run `yarn run po2json` from /kohadevbox/koha and no local node_modules directory exists, you will get: error Command "po2json" not found. See the different outputs: root@kohadevbox:koha$ pwd /kohadevbox/koha root@kohadevbox:koha$ yarn run --env yarn run v1.22.22 error There are no binary scripts available. root@kohadevbox:kohadevbox$ pwd /kohadevbox root@kohadevbox:kohadevbox$ yarn run --env yarn run v1.22.22 info Commands available from binary scripts: JSONStream, acorn, ansi-html, atob, autoprefixer, boast, browser-pack, browserify, browserslist, browserslist-lint, color-support, cssesc, cypress, deps-sort, detective, envinfo, eslint-config-prettier, esparse, esvalidate, extract-zip, findup, gulp, handlebars, he, highlight, html-minifier-terser, import-local-fixture, insert-module-globals, is-ci, is-docker, is-inside-container, js-yaml, jsesc, json5, loose-envify, marked, miller-rabin, mime, mkdirp, module-deps, multicast-dns, nanoid, node-which, oas-validate, openapi, opener, parser, po2json, prettier, redocly, regjsparser, resolve, rimraf, rspack, rtlcss, sass, semver, sha.js, sshpk-conv, sshpk-sign, sshpk-verify, stylelint, svgo, swagger-cli, swagger2openapi, terser, tsc, tsserver, uglifyjs, umd, undeclared-identifiers, uuid, vue-cli-service, vue-demi-fix, vue-demi-switch, watchify, webpack, webpack-bundle-analyzer, webpack-cli, webpack-dev-server I didn't find a cause of a possible regression. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37303 [Bug 37303] Fuzzy translations displayed on the UI -- You are receiving this mail because: You are watching all bug changes.

1 14

[Bug 23678] New: Cancel Holds in bulk
by bugzilla-daemon＠bugs.koha-community.org 30 Oct '24

30 Oct '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23678 Bug ID: 23678 Summary: Cancel Holds in bulk Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs(a)lists.koha-community.org Reporter: joy(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com Allow staff a way to cancel more than one hold at a time. Provide checkboxes on holds waiting over tab and allow staff to select multiple holds and cancel those selected holds. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 71

[Bug 25078] New: Stop updatedatabase.pl when a database change cannot be applied
by bugzilla-daemon＠bugs.koha-community.org 30 Oct '24

30 Oct '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25078 Bug ID: 25078 Summary: Stop updatedatabase.pl when a database change cannot be applied Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Installation and upgrade (web-based installer) Assignee: koha-bugs(a)lists.koha-community.org Reporter: lari.taskula(a)hypernova.fi QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com In order to maintain database schema consistency between installations running the same Koha version, we must not either conditionally apply or skip a schema alteration. See previous discussion https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22887#c15 Discuss how updatedatabase.pl and the GUI (and install.pl) should work when we want to stop a problematic database update and leave room for sysadmin to fix it. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 145

[Bug 20352] New: Add ability of currency/price to have a symbol after amount
by bugzilla-daemon＠bugs.koha-community.org 30 Oct '24

30 Oct '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20352 Bug ID: 20352 Summary: Add ability of currency/price to have a symbol after amount Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: josef.moravec(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 50