November 2025 - Koha-bugs - lists.koha-community.org

[Bug 39110] New: Auto-rebase script is slow
by bugzilla-daemon＠bugs.koha-community.org 13 Nov '25

13 Nov '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39110 Bug ID: 39110 Summary: Auto-rebase script is slow Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: jonathan.druart(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org Depends on: 38664 It loops over the files and call tidy.pl on each of them. tidy.pl can take a list of files in parameters, then tidy is run in parallel. It would be more effective, but not sure it is worth to spend too much time on this script. Only logging the issue, I don't plan to work on this. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38664 [Bug 38664] Tidy the whole codebase -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 1

[Bug 39111] New: Tidying template files is ineffective
by bugzilla-daemon＠bugs.koha-community.org 13 Nov '25

13 Nov '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39111 Bug ID: 39111 Summary: Tidying template files is ineffective Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: jonathan.druart(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org Depends on: 38664 There are 2 pass, we call the prettier plugin twice because there was an idempotent problem: I had to pretty the script at least twice to make it tidy and to make the script returning the same output. We could try to remove those 2 passes and see if it fixes the problem (ie. the xt/tt_tidy.t does not fail) for new changes. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38664 [Bug 38664] Tidy the whole codebase -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 1

[Bug 39151] New: xt/verify-yarnlock.t creates a lot of warnings
by bugzilla-daemon＠bugs.koha-community.org 13 Nov '25

13 Nov '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39151 Bug ID: 39151 Summary: xt/verify-yarnlock.t creates a lot of warnings Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: chris(a)bigballofwax.co.nz Reporter: katrin.fischer(a)bsz-bw.de QA Contact: testopia(a)bugs.koha-community.org Depends on: 38664 xt/verify-yarnlock.t ............. warning "@babel/code-frame##js-tokens@^4.0.0" could be deduped from "4.0.0" to "js-tokens(a)4.0.0" warning "@babel/code-frame##picocolors@^1.0.0" could be deduped from "1.0.0" to "picocolors(a)1.0.0" warning "@babel/parser##@babel/types@^7.26.8" could be deduped from "7.26.8" to "@babel/types@7.26.8" warning "@jridgewell/gen-mapping##@jridgewell/set-array@^1.2.1" could be deduped from "1.2.1" to "@jridgewell/set-array@1.2.1" warning "@jridgewell/gen-mapping##@jridgewell/sourcemap-codec@^1.4.10" could be deduped from "1.4.14" to "@jridgewell/sourcemap-codec@1.4.14" warning "@jridgewell/gen-mapping##@jridgewell/trace-mapping@^0.3.24" could be deduped from "0.3.25" to "@jridgewell/trace-mapping@0.3.25" warning "@jridgewell/trace-mapping##@jridgewell/resolve-uri@^3.1.0" could be deduped from "3.1.2" to "@jridgewell/resolve-uri@3.1.2" warning "@types/express##@types/body-parser@*" could be deduped from "1.19.2" to "@types/body-parser@1.19.2" warning "@types/express##@types/express-serve-static-core@^4.17.18" could be deduped from "4.17.31" to "@types/express-serve-static-core@4.17.31" warning "@types/express##@types/qs@*" could be deduped from "6.9.7" to "@types/qs@6.9.7" warning "@types/express##@types/serve-static@*" could be deduped from "1.15.0" to "@types/serve-static@1.15.0" warning "@types/express-serve-static-core##@types/node@*" could be deduped from "18.11.2" to "@types/node@18.11.2" warning "@types/express-serve-static-core##@types/qs@*" could be deduped from "6.9.7" to "@types/qs@6.9.7" warning "@types/express-serve-static-core##@types/range-parser@*" could be deduped from "1.2.4" to "@types/range-parser@1.2.4" warning "@types/serve-static##@types/mime@*" could be deduped from "3.0.1" to "@types/mime@3.0.1" warning "@types/serve-static##@types/node@*" could be deduped from "18.11.2" to "@types/node@18.11.2" warning "ajv##fast-deep-equal(a)^3.1.1" could be deduped from "3.1.3" to "fast-deep-equal(a)3.1.3" warning "ajv##fast-json-stable-stringify(a)^2.0.0" could be deduped from "2.1.0" to "fast-json-stable-stringify(a)2.1.0" ... Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38664 [Bug 38664] Tidy the whole codebase -- You are receiving this mail because: You are watching all bug changes.

1 8

[Bug 39152] New: Variables defined as `our` not tidied
by bugzilla-daemon＠bugs.koha-community.org 13 Nov '25

13 Nov '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39152 Bug ID: 39152 Summary: Variables defined as `our` not tidied Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: tomascohen(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org If you look at `tools/newHolidays` you will notice the file is not tidy. To reproduce: 1. Look at `tools/newHolidays` which is clearly not tidy 2. Run: $ ktd --shell k$ perl misc/devel/tidy.pl tools/newHolidays.pl k$ git diff => FAIL: No changes! 3. Replace `our` for `my` on the variable definitions 4. Repeat 2 => SUCCESS: The file is correctly tidied now! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 7

[Bug 39087] New: Some files are uglier when tidy
by bugzilla-daemon＠bugs.koha-community.org 13 Nov '25

13 Nov '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39087 Bug ID: 39087 Summary: Some files are uglier when tidy Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: jonathan.druart(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org Depends on: 38664 koha-tmpl/intranet-tmpl/prog/en/includes/catalogue/itemsearch_item.csv.inc koha-tmpl/intranet-tmpl/prog/en/includes/catalogue/itemsearch_item.json.inc a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/csv/* Not a big deal IMO as those files are wrong anyway (we should not build json or csv using TT) Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38664 [Bug 38664] Tidy the whole codebase -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 6

[Bug 39084] New: Unnecessary spaces added by the tidy all work
by bugzilla-daemon＠bugs.koha-community.org 13 Nov '25

13 Nov '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39084 Bug ID: 39084 Summary: Unnecessary spaces added by the tidy all work Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: jonathan.druart(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org Depends on: 38664 Should not hurt but those can be removed: - <button class="btn btn-default dropdown-toggle" data-bs-toggle="dropdown" aria-expanded="false"> - <i class="fa fa-plus"></i> New authority - </button> + <button class="btn btn-default dropdown-toggle" data-bs-toggle="dropdown" aria-expanded="false"> <i class="fa fa-plus"></i> New authority </button> We don't need the space before the i tag. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38664 [Bug 38664] Tidy the whole codebase -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 6

[Bug 39085] New: No space preserved incorrecly after END
by bugzilla-daemon＠bugs.koha-community.org 13 Nov '25

13 Nov '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39085 Bug ID: 39085 Summary: No space preserved incorrecly after END Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: jonathan.druart(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org Depends on: 38664 The prettier plugin cannot guess if the absence of space was needed, so it got preserved. However in some cases it's not needed. Eg. koha-tmpl/intranet-tmpl/prog/en/modules/acqui/supplier.tt + [% END %]</li + > We could move the closing li on a separate line for better indentation and readability. Also the closing title almost everywhere: -[% END %]</title> If we don't want spaces we need to CHOMP List the candidates with `git grep -P 'END %][^\s|>|;|)|"|[]' **/*.tt` Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38664 [Bug 38664] Tidy the whole codebase -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 4

[Bug 39086] New: Lines incorrectly split
by bugzilla-daemon＠bugs.koha-community.org 13 Nov '25

13 Nov '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39086 Bug ID: 39086 Summary: Lines incorrectly split Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: jonathan.druart(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org Depends on: 38664 This is weird: koha-tmpl/intranet-tmpl/prog/en/includes/filter-orders.inc - <li><label for="from">From: </label> + <li + ><label for="from">From: </label> <input type="text" size="10" id="from" name="from" value="[% filters.from_placed_on | html %]" class="flatpickr" data-date_to="to" /> <div class="hint">[% INCLUDE 'date-format.inc' %]</div> </li> - <li><label for="to">To: </label> + <li + ><label for="to">To: </label> Why aren't they kept on the same line? I didn't find many occurrences. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38664 [Bug 38664] Tidy the whole codebase -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 2

[Bug 38952] New: JS function messenger not used in acq.js
by bugzilla-daemon＠bugs.koha-community.org 13 Nov '25

13 Nov '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38952 Bug ID: 38952 Summary: JS function messenger not used in acq.js Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart(a)gmail.com Reporter: jonathan.druart(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org koha-tmpl/intranet-tmpl/prog/js/acq.js 166 function messenger(X,Y,etc){ // FIXME: unused? 167 win=window.open("","mess","height="+X+",width="+Y+",screenX=150,screenY=0"); 168 win.focus(); 169 win.document.close(); 170 win.document.write("<body link='#333333' bgcolor='#ffffff' text='#000000'><font size='2'><p><br />"); 171 win.document.write(etc); 172 win.document.write("<center><form><input type=button onclick='self.close()' value='Close'></form></center>"); 173 win.document.write("</font></body></html>"); 174 } % git grep -l messenger koha-tmpl/intranet-tmpl/lib/fontawesome/css/brands.min.css koha-tmpl/intranet-tmpl/lib/fontawesome/webfonts/fa-brands-400.ttf koha-tmpl/intranet-tmpl/prog/js/acq.js koha-tmpl/opac-tmpl/lib/fontawesome/css/brands.min.css koha-tmpl/opac-tmpl/lib/fontawesome/webfonts/fa-brands-400.ttf -- You are receiving this mail because: You are watching all bug changes.

1 11

[Bug 39149] New: .PL files not tidy
by bugzilla-daemon＠bugs.koha-community.org 13 Nov '25

13 Nov '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39149 Bug ID: 39149 Summary: .PL files not tidy Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: tomascohen(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org Somehow we missed we have `.PL` files in the codebase. They are not considered in `tidy.pl` and remain untidy. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 20