April 2025 - Koha-bugs - lists.koha-community.org

[Bug 29440] New: Refactor/clean up bulkmarcimport.pl
by bugzilla-daemon＠bugs.koha-community.org 23 Jun '25

23 Jun '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29440 Bug ID: 29440 Summary: Refactor/clean up bulkmarcimport.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs(a)lists.koha-community.org Reporter: glasklas(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org In order to address various issues with and add some new features to bulkmarcimport.pl I found it necessary to first clean up the script. At our library we run a modified version of bulkmarcimport.pl that for practical reasons was squashed into one commit. I have split this commit into various feature branches, all which depends on the clean up version of the script. So in the first commit of this issue I tried to isolate all the changes that should not affect current script behavior and are mostly related to code formatting, structure and optimizations. The next commits (for this issue) will contain changes that do affect script behavior, but that I would argue should be the default behavior and where the current could be considered confusing and/or buggy. I will later create new related issues for the newly added features mentioned above (and it's possible there is stuff in this patch that should have been broken out and I have overlooked). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 132

[Bug 35962] New: t/db_dependent/Koha/BackgroundJob.t failing on D10
by bugzilla-daemon＠bugs.koha-community.org 23 Jun '25

23 Jun '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35962 Bug ID: 35962 Summary: t/db_dependent/Koha/BackgroundJob.t failing on D10 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: chris(a)bigballofwax.co.nz Reporter: katrin.fischer(a)bsz-bw.de QA Contact: testopia(a)bugs.koha-community.org Not failing locally, but on D10: koha_1 | koha_1 | # Failed test 'Enqueue MARCImportCommitBatch with mock throws exception' koha_1 | # at t/db_dependent/Koha/BackgroundJob.t line 85. koha_1 | # expecting: Koha::Exceptions::BackgroundJob koha_1 | # found: normal exit koha_1 | # Looks like you planned 10 tests but ran 2. koha_1 | # Looks like you failed 1 test of 2 run. koha_1 | koha_1 | # Failed test 'enqueue() tests' koha_1 | # at t/db_dependent/Koha/BackgroundJob.t line 128. koha_1 | Can't locate object method "unmock" via package "0" (perhaps you forgot to load "0"?) at t/db_dependent/Koha/BackgroundJob.t line 87. koha_1 | # Looks like your test exited with 255 just after 2. koha_1 | [14:12:00] t/db_dependent/Koha/BackgroundJob.t ......................................... koha_1 | Dubious, test returned 255 (wstat 65280, 0xff00) koha_1 | Failed 4/5 subtests Coudl this be related to bug 35507 or bug 30734? -- You are receiving this mail because: You are watching all bug changes.

1 17

[Bug 35843] New: No such thing as Koha::Exceptions::Exception
by bugzilla-daemon＠bugs.koha-community.org 23 Jun '25

23 Jun '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35843 Bug ID: 35843 Summary: No such thing as Koha::Exceptions::Exception Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: magnus(a)libriotech.no QA Contact: testopia(a)bugs.koha-community.org On Koha 22.11.04-1 installed with the Debian packages I have some background jobs that are failing, and I see this in the logs: ==> /var/log/koha/mykoha/plack-intranet-error.log <== [2024/01/19 08:47:02] [WARN] The job has not been sent to the message broker: (Can't locate object method "throw" via package "Koha::Exceptions::Exception" (perhaps you forgot to load "Koha::Exceptions::Exception"?) at /usr/share/koha/lib/Koha/BackgroundJob.pm line 141. ) at /usr/share/koha/lib/Koha/BackgroundJob.pm line 148. The relevant code looks like this: 134 try { 135 # This namespace is wrong, it must be a vhost instead. 136 # But to do so it needs to be created on the server => much more work when a new Koha instance is created. 137 # Also, here we just want the Koha instance's name, but it's not in the config... 138 # Picking a random id (memcached_namespace) from the config 139 my $namespace = C4::Context->config('memcached_namespace'); 140 my $encoded_args = Encode::encode_utf8( $json_args ); # FIXME We should better leave this to Net::Stomp? 141 $conn->send_with_receipt( { destination => sprintf("/queue/%s-%s", $namespace, $job_queue), body => $encoded_args } ) 142 or Koha::Exceptions::Exception->throw('Job has not been enqueued'); 143 } catch { 144 $self->status('failed')->store; 145 if ( ref($_) eq 'Koha::Exceptions::Exception' ) { 146 $_->rethrow; 147 } else { 148 warn sprintf "The job has not been sent to the message broker: (%s)", $_; 149 } 150 }; This code is the only place Koha::Exceptions::Exception is mentioned in the code: $ sudo grep -rn "Koha::Exceptions::Exception" /usr/share/koha/ /usr/share/koha/lib/Koha/BackgroundJob.pm:142: or Koha::Exceptions::Exception->throw('Job has not been enqueued'); /usr/share/koha/lib/Koha/BackgroundJob.pm:145: if ( ref($_) eq 'Koha::Exceptions::Exception' ) { -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 17

[Bug 29510] New: objects.find should call search_limited if present
by bugzilla-daemon＠bugs.koha-community.org 23 Jun '25

23 Jun '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29510 Bug ID: 29510 Summary: objects.find should call search_limited if present Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: REST API Assignee: koha-bugs(a)lists.koha-community.org Reporter: tomascohen(a)gmail.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 19

[Bug 34479] New: Clear saved patron search selections after certain actions
by bugzilla-daemon＠bugs.koha-community.org 23 Jun '25

23 Jun '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34479 Bug ID: 34479 Summary: Clear saved patron search selections after certain actions Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Patrons Assignee: koha-bugs(a)lists.koha-community.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org CC: cslone(a)camdencountylibrary.org, gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com, testopia(a)bugs.koha-community.org Depends on: 29971 +++ This bug was initially created as a clone of Bug #29971 +++ (In reply to Chris Slone from comment #17) > I think this is a problematic implementation, as it seems to be retaining > the selected patrons even after you perform a function (merge patrons, > create a list, do a batch edit) and do a completely new search. This means > that the previously selected patrons remain selected even when it doesn't > really make logical sense. It's great to be able to select multiple patrons > across different searches, but doing something like merging accounts should > absolutely clear out that selection. > > It seems to already be causing some issues, see this ticket: > > https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34262 > > We've also had some errors at our library from this (before we realized what > was happening). I'm moving this issue into a new bug report because we don't re-open bugs for features which have been pushed. This will let us have a discussion about refining the behavior. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29971 [Bug 29971] Remember selections across patron search pages -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 49

[Bug 35341] New: Circulation rule dates are being overwritten
by bugzilla-daemon＠bugs.koha-community.org 23 Jun '25

23 Jun '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35341 Bug ID: 35341 Summary: Circulation rule dates are being overwritten Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: matt.blenkinsop(a)ptfs-europe.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com When setting either the "Hard due date" or the "No automatic renewal after (hard limit)" columns - if only one is amended then the other will be overwritten with the value of the last rule that was in the editor -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 68

[Bug 35322] New: AllowItemsOnHoldCheckoutSCO and AllowItemsOnHoldCheckoutSIP do not work
by bugzilla-daemon＠bugs.koha-community.org 23 Jun '25

23 Jun '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35322 Bug ID: 35322 Summary: AllowItemsOnHoldCheckoutSCO and AllowItemsOnHoldCheckoutSIP do not work Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs(a)lists.koha-community.org Reporter: kyle(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com We are having reports that AllowItemsOnHoldCheckoutSCO and AllowItemsOnHoldCheckoutSIP no longer work. It appreas that in CanBookBeIssued, the ignore reserves check was changed from "check reserves unless the ignore reserves flag was passed" to "check reserves unless the ignore reserves flag was passed *and* we have a recall". I think this was a logic mistake and we want to check reserves unless we have an ignore flag *or* there is a recall. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 26

[Bug 38999] New: Remove webpack config file
by bugzilla-daemon＠bugs.koha-community.org 23 Jun '25

23 Jun '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38999 Bug ID: 38999 Summary: Remove webpack config file Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: jonathan.druart(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org Depends on: 37824 Now that we use rspack we should not keep both config files. >From bug 37824: """ I left the webpack.config.js as well as the devDependencies in place for now. We can remove them in a follow-up patch on this bug after testing it out. """ Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37824 [Bug 37824] Replace webpack with rspack for fun and profit -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 2

[Bug 37824] New: Replace webpack with rspack for fun and profit
by bugzilla-daemon＠bugs.koha-community.org 23 Jun '25

23 Jun '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37824 Bug ID: 37824 Summary: Replace webpack with rspack for fun and profit Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: paul.derscheid(a)lmscloud.de QA Contact: testopia(a)bugs.koha-community.org Webpack is slow and nobody likes it. It gives us a lot of flexibility, though (for example in comparison to rollup, which is pretty great). Let's replace it with what's just reached v1 and is advertised as more or less a drop-in-replacement. Full Disclosure: rspack is a ByteDance project (MIT licensed, though). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 45

[Bug 37558] New: Statistics table does not have an id
by bugzilla-daemon＠bugs.koha-community.org 23 Jun '25

23 Jun '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37558 Bug ID: 37558 Summary: Statistics table does not have an id Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org See bug 37540 - we have to manually stringify dates in the statistics objects when unblessing because we cannot refetch a fresh object from the DB as we have no id. Should we add an update to add a primary key to the statistics table? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 5