April 2025 - Koha-bugs - lists.koha-community.org

[Bug 14250] Don't allow to generate discharges for patrons with fines
by bugzilla-daemon＠bugs.koha-community.org 18 Apr '25

18 Apr '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14250 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14250] Don't allow to generate discharges for patrons with fines
by bugzilla-daemon＠bugs.koha-community.org 18 Apr '25

18 Apr '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14250 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia(a)bugs.koha-communit |m.de.rooy(a)rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14250] Don't allow to generate discharges for patrons with fines
by bugzilla-daemon＠bugs.koha-community.org 18 Apr '25

18 Apr '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14250 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #52 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Comment49 needs feedback. opac/opac-discharge.pl +my $has_pending_checkouts = $patron->checkouts->count; This line is a remnant of older code, I guess? Not used anymore. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14250] Don't allow to generate discharges for patrons with fines
by bugzilla-daemon＠bugs.koha-community.org 18 Apr '25

18 Apr '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14250 --- Comment #51 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- (In reply to Baptiste Wojtkowski (bwoj) from comment #47) > Note for QA/RM, there are a lot of little commits here, feel free to squash > every patch I'm authoring Done -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14250] Don't allow to generate discharges for patrons with fines
by bugzilla-daemon＠bugs.koha-community.org 18 Apr '25

18 Apr '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14250 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179618|0 |1 is obsolete| | Attachment #179619|0 |1 is obsolete| | Attachment #179620|0 |1 is obsolete| | Attachment #179621|0 |1 is obsolete| | Attachment #179622|0 |1 is obsolete| | Attachment #181149|0 |1 is obsolete| | --- Comment #50 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 181150 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181150&action=e… Bug 14250: Patron with fines cannot be discharged anymore TEST PLAN: 1 - In the intranet add fines to a client and ensure they have no checkout 2 - Set syspref useDischarge to 'Allow' 3 - On client profile click on "Discharge", see it is possible 4 - On the opac, go to the tab "Ask for discharge", see it is possible 5 - Apply patch 6 - Click on the button "Ask for discharge" -> it will not be possible and you will be propperly messaged 7 - Return to the tab "Ask for a discharge", there will be no button anymore 8 - On the intranet page, there will be no button anymore 9 - Check out a book 10 - Repeat 7 and 8 and see the message include issue with checkout 11 - Remove fine and repeat 7 & 8 Bug 14250: (QA follow-up) Deduplicate checks Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> Bug 14250: (follow-up) Update messages Update the text for the reasons the patron cannot be discharged. Bug 14250: (follow-up) Refacto the algorithm for discharge messages TEST PLAN: 1 - In the intranet add fines to a client and ensure they have no checkout 2 - Set syspref useDischarge to 'Allow' 3 - On client profile click on "Discharge", see it is possible 4 - On the opac, go to the tab "Ask for discharge", see it is possible 5 - Apply patch 6 - Click on the button "Ask for discharge" -> it will not be possible and you will be propperly messaged 7 - Return to the tab "Ask for a discharge", there will be no button anymore 8 - On the intranet page, there will be no button anymore 9 - Check out a book 10 - Repeat 7 and 8 and see the message include issue with checkout 11 - Remove fine and repeat 7 & 8 Note: removing the useless has_checkout and has_debt Bug 14250: (follow-up) Refacto discharge messages display The script that determines if one should display messages to the user, informing him whether they are allowed or not to ask for a discharge is quite hard to understand. For sake of readability, transforming the unless to an if since the error behaviour was in the unless and the success in the else. Changing to success behaviour in the if and failure in the else. Bug 14250: Tidy -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14250] Don't allow to generate discharges for patrons with fines
by bugzilla-daemon＠bugs.koha-community.org 18 Apr '25

18 Apr '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14250 --- Comment #49 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- + <p>A discharge cannot be generated for this patron because:</p> + <ul> + [% IF discharge_problems.checkouts %] + <li>The patron has [% discharge_problems.checkouts | html %] item(s) checked out</li> + [% END %] + + [% IF discharge_problems.debt %] + <li>The patron has unpaid charges of [% discharge_problems.debt | $Price %]</li> + [% END %] + </ul> I would recommend to rearrange the text here. Ending with because: looks a bit strange? In the ELSE following this, I see: + [% IF discharge_problems.debt %] + <li>The patron has unpaid charges of [% discharge_problems.debt | $Price %]</li> This c/should not be there? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14250] Don't allow to generate discharges for patrons with fines
by bugzilla-daemon＠bugs.koha-community.org 18 Apr '25

18 Apr '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14250 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179617|0 |1 is obsolete| | --- Comment #48 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 181149 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181149&action=e… Bug 14250: Patron with fines cannot be discharged anymore TEST PLAN: 1 - In the intranet add fines to a client and ensure they have no checkout 2 - Set syspref useDischarge to 'Allow' 3 - On client profile click on "Discharge", see it is possible 4 - On the opac, go to the tab "Ask for discharge", see it is possible 5 - Apply patch 6 - Click on the button "Ask for discharge" -> it will not be possible and you will be propperly messaged 7 - Return to the tab "Ask for a discharge", there will be no button anymore 8 - On the intranet page, there will be no button anymore 9 - Check out a book 10 - Repeat 7 and 8 and see the message include issue with checkout 11 - Remove fine and repeat 7 & 8 Bug 14250: (QA follow-up) Deduplicate checks Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> Bug 14250: (follow-up) Update messages Update the text for the reasons the patron cannot be discharged. Bug 14250: (follow-up) Refacto the algorithm for discharge messages TEST PLAN: 1 - In the intranet add fines to a client and ensure they have no checkout 2 - Set syspref useDischarge to 'Allow' 3 - On client profile click on "Discharge", see it is possible 4 - On the opac, go to the tab "Ask for discharge", see it is possible 5 - Apply patch 6 - Click on the button "Ask for discharge" -> it will not be possible and you will be propperly messaged 7 - Return to the tab "Ask for a discharge", there will be no button anymore 8 - On the intranet page, there will be no button anymore 9 - Check out a book 10 - Repeat 7 and 8 and see the message include issue with checkout 11 - Remove fine and repeat 7 & 8 Note: removing the useless has_checkout and has_debt Bug 14250: (follow-up) Refacto discharge messages display The script that determines if one should display messages to the user, informing him whether they are allowed or not to ask for a discharge is quite hard to understand. For sake of readability, transforming the unless to an if since the error behaviour was in the unless and the success in the else. Changing to success behaviour in the if and failure in the else. Bug 14250: Tidy -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14250] Don't allow to generate discharges for patrons with fines
by bugzilla-daemon＠bugs.koha-community.org 18 Apr '25

18 Apr '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14250 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171273|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 39672] New: Keep focus on text boxes
by bugzilla-daemon＠bugs.koha-community.org 17 Apr '25

17 Apr '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39672 Bug ID: 39672 Summary: Keep focus on text boxes Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Self checkout Assignee: koha-bugs(a)lists.koha-community.org Reporter: cbrannon(a)cdalibrary.org QA Contact: testopia(a)bugs.koha-community.org I would like to request that SCO be tweaked to maintain focus on the search boxes for login and check out. It is too easy for the focus to be lost on the text box when checking out that people don't pay attention if something isn't getting scanned. On login, it isn't as critical, but it keeps it consistent. It is also easy enough to tap or click elsewhere on the screen making scanning the card ineffective unless you know to click back on the text box. I've managed to setup jquery to accomplish this, but I think it is an easy enough tweak without causing any side effects that it is something that should be considered. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0

[Bug 39671] New: Let patron check their notifications
by bugzilla-daemon＠bugs.koha-community.org 17 Apr '25

17 Apr '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39671 Bug ID: 39671 Summary: Let patron check their notifications Change sponsored?: --- Product: Koha Version: 24.05 Hardware: All OS: All Status: NEW Severity: new feature Priority: P5 - low Component: Notices Assignee: koha-bugs(a)lists.koha-community.org Reporter: cornejo.alvaro(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org Created attachment 181139 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181139&action=e… Main access to new notices inbox Currently Patrons does not have a way to check the notifications they have received from the notification system. This new feature will allow them, once logged into their account, to see their notices. this very basic code -I´m not a programmer at all- provide a basic "read-only inbox" Two files are needed: /usr/share/koha/opac/cgi-bin/opac/opac-acc-notices.pl /usr/share/koha/opac/htdocs/opac-tmpl/bootstrap/en/modules/opac-acc-notices.tt And the following JS /* OPAC-NOTICES */ if ($('#usermenu').length) { var myLang = $('html').attr('lang'); let eborrowernumber = $('.loggedinusername').attr('data-borrowernumber'); if (myLang == "en") { // SIN borrower si plantilla opac-xxx.pl // $('#menu ul').prepend('<li><a href="/cgi-bin/koha/opac-notices.pl?borrowernumber=' + eborrowernumber + '">Notifications PREP</a></li>'); $('#menu ul').append('<li><a href="/cgi-bin/koha/opac-acc-notices.pl">Notifications</a></li>'); } /*END IF mylang==en*/ if (myLang == "es-ES") { // $('#menu ul').prepend('<li><a href="/cgi-bin/koha/opac-notices.pl?borrowernumber=' + eborrowernumber + '">Notificaciones PREP</a></li>'); $('#menu ul').append('<li><a href="/cgi-bin/koha/opac-acc-notices.pl">Notificaciones</a></li>'); } /*END IF mylang==es-ES*/ } /*END IF $#usermenu...*/ /* end OPAC-NOTICES */ URL that will be called: https://MYLIBRARY.COM/cgi-bin/koha/opac-account-notices.pl -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 2