April 2025 - Koha-bugs - lists.koha-community.org

[Bug 7376] Transfer limits should be checked at check-in
by bugzilla-daemon＠bugs.koha-community.org 17 Apr '25

17 Apr '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376 Mathieu Saby <mathsabypro(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181055|0 |1 is obsolete| | --- Comment #171 from Mathieu Saby <mathsabypro(a)gmail.com> --- Created attachment 181064 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181064&action=e… Bug 7376: Transfer limits should be checked at check-in Test case: * UseBranchTransferLimits must be set * define your branch transfer limit. Refuse transfers from libraryA to libraryB * checkout a book owned by libraryB, from libraryB, with a librarian located at libraryB * move the librarian to libraryA ("Set Library" link top/right) * check-in the book => it's possible whatever your setup After the patch, the behaviour respect the branch transfer limit parameter: you can check-in if you accept transfers, you can't if you refuse them. (Note: IndependantBranches must be OFF, otherwise it's not possible to do the checkin whatever the branch transfer limits) TEST PLAN: Note: older signoffs did not validate this test plan Considering you use a ktd-like database. Log in at centerville Allow transfers between centerville, Midway and Franklin, don't allow transfers between Fairfield, Liberty and all other libraries. In addition, allow the transfer between Liberty and Midway Transfer as much books as you can from Centerville to Midway. Log in as Midway, check out as many books from Centerville as you can to Henry Acevedo. If you don't have enough books during the test plan, feel free to check out books again. During the whole test, without further precision, items checkout out in such conditions should be checked in. You will also need 6 checked out floating books at midway Note: '-> ok' means the checkin is allowed '-> not ok' means the checkin is not allowed Apply patch I - Test AllowReturnToBranch During this part of the test plan, you want to have all following configuration : 'CircControlReturnsBranch' -> 'The library the item is checked in at' In CIRC rules: 'Default holds policy and return policy' -> 'Item returns home' (make sure you have no other holds policy on any library) 'AllowReturnToBranch' -> as follows 1 - Set to "Either at the library the item is from or at the library the item was checked out from" X a - Check in to Centerville -> ok X b - Check in to Midway -> ok X c - Check in to Franklin -> not ok X d - Check in to Fairfield -> not ok 2 - Set to "Only at the library the item was checked out from" X a - Check in to Centerville -> not ok X b - Check in to Midway -> ok X c - Check in to Franklin -> not ok X d - Check in to Fairfield -> not ok 3 - Set to "Only at the library the item is from" X a - Check in to Centerville -> ok X b - Check in to Midway -> not ok X c - Check in to Franklin -> not ok X d - Check in to Fairfield -> not ok 4 - Set to "Any library" X a - Check in to Centerville -> ok X b - Check in to Midway -> ok X c - Check in to Franklin -> ok X d - Check in to Fairfield -> not ok II - Transfer and check out 6 floating items at midway. 1 - X a - Check in to Centerville -> ok X b - Check in to Midway -> ok X c - Check in to Franklin -> ok X d - Check in to Fairfield -> ok 2 - Set 'AllowReturnToBranch' to 'home library' X a - Check in to Centerville -> ok X b - Check in to Midway -> not ok III - Pathological & asymetrical cases. During this part of the test plan, you want to have all following configuration : 'CircControlReturnsBranch' -> 'The library the item is checked in at' 'Default holds policy and return policy' -> 'Item returns home' (make sure you have no other holds policy on any library) 'AllowReturnToBranch' -> 'Any library' FOR THIS PART OF THE TESTS ONLY (until IV): Don't allow tranfers from midway to centerville, but allow from centerville to midway X 1 - Check in a book at midway -> not ok Set 'Default holds policy and return policy' -> 'Item returns to issuing library' X 2 - Check in a book at centerville -> ok FOR THIS PART OF THE TESTS ONLY (until IV): Don't allow tranfers from centerville to midway X 3 - Check in a book at centerville -> not ok X 4 - Set 'AllowReturnToBranch' to "Only at the library the item was checked out from" X a - check in to Centerville -> not ok X b - check in to Midway -> not ok IV - Test 'CircControlReturnsBranch' (remove the precedent transfer restriction) During this part of the test plan, you want to have all following configuration : 'Default holds policy and return policy' -> 'Item returns home' (unchanged) 'Default checkout, hold and return policy for Midway' -> 'Item returns to issuing library' 'Default checkout, hold and return policy for Franklin' -> 'Item floats' 'Default checkout, hold and return policy for Fairfield' -> 'Item returns to issuing library' 'Default checkout, hold and return policy for Liberty' -> 'Item returns home' 'AllowReturnToBranch' -> "Any library" (unchanged) 'CircControlReturnsBranch' -> as follows 1 - 'The library the item is checked in at' X a - Check in to Centerville -> ok X b - Check in to Midway -> ok X c - Check in to Franklin -> ok X d - Check in to Fairfield -> not ok X e - Check in to Liberty -> not ok 2 - 'The library the current item is held by X a - Check in to Centerville -> ok X b - Check in to Midway -> ok X c - Check in to Franklin -> ok X d - Check in to Fairfield -> not ok X e - Check in to Liberty -> ok 3 - 'the library the item is owned by' X a - Check in to Centerville -> ok X b - Check in to Midway -> ok X c - Check in to Franklin -> ok X d - Check in to Fairfield -> not ok X e - Check in to Liberty -> not ok Sponsored-by: National Library of Finland Signed-off-by: Arthur Suzuki <arthur.suzuki(a)biblibre.com> Signed-off-by: Julian Maurice <julian.maurice(a)biblibre.com> Signed-off-by: Baptiste Wojtkowski <baptiste.wojtkowski(a)biblibre.com> Signed-off-by: Mathieu Saby <mathsabypro(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7376] Transfer limits should be checked at check-in
by bugzilla-daemon＠bugs.koha-community.org 17 Apr '25

17 Apr '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376 Mathieu Saby <mathsabypro(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180597|0 |1 is obsolete| | --- Comment #170 from Mathieu Saby <mathsabypro(a)gmail.com> --- Created attachment 181062 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181062&action=e… Bug 7376: (follow-up) Add tests on no_return Note: tests have to be performed on addReturn and have therefore been added in a separate test Signed-off-by: Baptiste Wojtkowski <baptiste.wojtkowski(a)biblibre.com> Signed-off-by: Mathieu Saby <mathsabypro(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7376] Transfer limits should be checked at check-in
by bugzilla-daemon＠bugs.koha-community.org 17 Apr '25

17 Apr '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376 Mathieu Saby <mathsabypro(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180596|0 |1 is obsolete| | --- Comment #169 from Mathieu Saby <mathsabypro(a)gmail.com> --- Created attachment 181061 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181061&action=e… Bug 7376: Allow passing 'transferbranch' to CanBookBeReturned This patch adds the optional 'tranferbranch' parameter to the CanBookBeReturned routine. This allows for passing the correct 'ReturnToX' transfer to be tested at return time for transfer limit restrictions. Signed-off-by: Julian Maurice <julian.maurice(a)biblibre.com> Signed-off-by: Baptiste Wojtkowski <baptiste.wojtkowski(a)biblibre.com> Signed-off-by: Mathieu Saby <mathsabypro(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7376] Transfer limits should be checked at check-in
by bugzilla-daemon＠bugs.koha-community.org 17 Apr '25

17 Apr '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376 Mathieu Saby <mathsabypro(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180595|0 |1 is obsolete| | --- Comment #168 from Mathieu Saby <mathsabypro(a)gmail.com> --- Created attachment 181060 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181060&action=e… Bug 7376: Clarify tests further We want to prevent returns where the item cannot be transfered 'back to where it came from (be that Homebranch or Holdingbranch as defined respectively in the circulation rules). This patch clarifies the tests further by testing this transfer functionality distinctly from the 'AllowReturnToBranch' preference functionality. Signed-off-by: Julian Maurice <julian.maurice(a)biblibre.com> Signed-off-by: Baptiste Wojtkowski <baptiste.wojtkowski(a)biblibre.com> Signed-off-by: Mathieu Saby <mathsabypro(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7376] Transfer limits should be checked at check-in
by bugzilla-daemon＠bugs.koha-community.org 17 Apr '25

17 Apr '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376 Mathieu Saby <mathsabypro(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180594|0 |1 is obsolete| | --- Comment #167 from Mathieu Saby <mathsabypro(a)gmail.com> --- Created attachment 181059 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181059&action=e… Bug 7376: (follow-up) Fix C4/Circulation.pm This follow-up patch actually fixes the issue. This patch forbids a patron to return a book to a library from where the book may not return to its home or holding library. Signed-off-by: Julian Maurice <julian.maurice(a)biblibre.com> Signed-off-by: Baptiste Wojtkowski <baptiste.wojtkowski(a)biblibre.com> Signed-off-by: Mathieu Saby <mathsabypro(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7376] Transfer limits should be checked at check-in
by bugzilla-daemon＠bugs.koha-community.org 17 Apr '25

17 Apr '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376 Mathieu Saby <mathsabypro(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180593|0 |1 is obsolete| | --- Comment #166 from Mathieu Saby <mathsabypro(a)gmail.com> --- Created attachment 181058 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181058&action=e… Bug 7376: (follow-up) Make extended tests mock the actual desired behaviour Signed-off-by: Julian Maurice <julian.maurice(a)biblibre.com> Signed-off-by: Baptiste Wojtkowski <baptiste.wojtkowski(a)biblibre.com> Signed-off-by: Mathieu Saby <mathsabypro(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7376] Transfer limits should be checked at check-in
by bugzilla-daemon＠bugs.koha-community.org 17 Apr '25

17 Apr '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376 Mathieu Saby <mathsabypro(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180592|0 |1 is obsolete| | --- Comment #165 from Mathieu Saby <mathsabypro(a)gmail.com> --- Created attachment 181057 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181057&action=e… Bug 7376: (follow-up) Extend test coverage and document I'm not sure about the requirements for this bug. This patch extends the tests to cover the new combinations introduced and highlights exactly what changes in the logic.. which appears to be fairly little. Signed-off-by: Julian Maurice <julian.maurice(a)biblibre.com> Signed-off-by: Baptiste Wojtkowski <baptiste.wojtkowski(a)biblibre.com> Signed-off-by: Mathieu Saby <mathsabypro(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7376] Transfer limits should be checked at check-in
by bugzilla-daemon＠bugs.koha-community.org 17 Apr '25

17 Apr '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376 Mathieu Saby <mathsabypro(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180591|0 |1 is obsolete| | --- Comment #164 from Mathieu Saby <mathsabypro(a)gmail.com> --- Created attachment 181056 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181056&action=e… Bug 7376: Unit test Signed-off-by: Julian Maurice <julian.maurice(a)biblibre.com> Signed-off-by: Baptiste Wojtkowski <baptiste.wojtkowski(a)biblibre.com> Signed-off-by: Mathieu Saby <mathsabypro(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7376] Transfer limits should be checked at check-in
by bugzilla-daemon＠bugs.koha-community.org 17 Apr '25

17 Apr '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376 Mathieu Saby <mathsabypro(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180590|0 |1 is obsolete| | --- Comment #163 from Mathieu Saby <mathsabypro(a)gmail.com> --- Created attachment 181055 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181055&action=e… Bug 7376: Transfer limits should be checked at check-in Test case: * UseBranchTransferLimits must be set * define your branch transfer limit. Refuse transfers from libraryA to libraryB * checkout a book owned by libraryB, from libraryB, with a librarian located at libraryB * move the librarian to libraryA ("Set Library" link top/right) * check-in the book => it's possible whatever your setup After the patch, the behaviour respect the branch transfer limit parameter: you can check-in if you accept transfers, you can't if you refuse them. (Note: IndependantBranches must be OFF, otherwise it's not possible to do the checkin whatever the branch transfer limits) TEST PLAN: Note: older signoffs did not validate this test plan Considering you use a ktd-like database. Log in at centerville Allow transfers between centerville, Midway and Franklin, don't allow transfers between Fairfield, Liberty and all other libraries. In addition, allow the transfer between Liberty and Midway Transfer as much books as you can from Centerville to Midway. Log in as Midway, check out as many books from Centerville as you can to Henry Acevedo. If you don't have enough books during the test plan, feel free to check out books again. During the whole test, without further precision, items checkout out in such conditions should be checked in. You will also need 6 checked out floating books at midway Note: '-> ok' means the checkin is allowed '-> not ok' means the checkin is not allowed Apply patch I - Test AllowReturnToBranch During this part of the test plan, you want to have all following configuration : 'CircControlReturnsBranch' -> 'The library the item is checked in at' In CIRC rules: 'Default holds policy and return policy' -> 'Item returns home' (make sure you have no other holds policy on any library) 'AllowReturnToBranch' -> as follows 1 - Set to "Either at the library the item is from or at the library the item was checked out from" X a - Check in to Centerville -> ok X b - Check in to Midway -> ok X c - Check in to Franklin -> not ok X d - Check in to Fairfield -> not ok 2 - Set to "Only at the library the item was checked out from" X a - Check in to Centerville -> not ok X b - Check in to Midway -> ok X c - Check in to Franklin -> not ok X d - Check in to Fairfield -> not ok 3 - Set to "Only at the library the item is from" X a - Check in to Centerville -> ok X b - Check in to Midway -> not ok X c - Check in to Franklin -> not ok X d - Check in to Fairfield -> not ok 4 - Set to "Any library" X a - Check in to Centerville -> ok X b - Check in to Midway -> ok X c - Check in to Franklin -> ok X d - Check in to Fairfield -> not ok II - Transfer and check out 6 floating items at midway. 1 - X a - Check in to Centerville -> ok X b - Check in to Midway -> ok X c - Check in to Franklin -> ok X d - Check in to Fairfield -> ok 2 - Set 'AllowReturnToBranch' to 'home library' X a - Check in to Centerville -> ok X b - Check in to Midway -> not ok III - Pathological & asymetrical cases. During this part of the test plan, you want to have all following configuration : 'CircControlReturnsBranch' -> 'The library the item is checked in at' 'Default holds policy and return policy' -> 'Item returns home' (make sure you have no other holds policy on any library) 'AllowReturnToBranch' -> 'Any library' FOR THIS PART OF THE TESTS ONLY (until IV): Don't allow tranfers from midway to centerville, but allow from centerville to midway X 1 - Check in a book at midway -> not ok Set 'Default holds policy and return policy' -> 'Item returns to issuing library' X 2 - Check in a book at centerville -> ok FOR THIS PART OF THE TESTS ONLY (until IV): Don't allow tranfers from centerville to midway X 3 - Check in a book at centerville -> not ok X 4 - Set 'AllowReturnToBranch' to "Only at the library the item was checked out from" X a - check in to Centerville -> not ok X b - check in to Midway -> not ok IV - Test 'CircControlReturnsBranch' (remove the precedent transfer restriction) During this part of the test plan, you want to have all following configuration : 'Default holds policy and return policy' -> 'Item returns home' (unchanged) 'Default checkout, hold and return policy for Midway' -> 'Item returns to issuing library' 'Default checkout, hold and return policy for Franklin' -> 'Item floats' 'Default checkout, hold and return policy for Fairfield' -> 'Item returns to issuing library' 'Default checkout, hold and return policy for Liberty' -> 'Item returns home' 'AllowReturnToBranch' -> "Any library" (unchanged) 'CircControlReturnsBranch' -> as follows 1 - 'The library the item is checked in at' X a - Check in to Centerville -> ok X b - Check in to Midway -> ok X c - Check in to Franklin -> ok X d - Check in to Fairfield -> not ok X e - Check in to Liberty -> not ok 2 - 'The library the current item is held by X a - Check in to Centerville -> ok X b - Check in to Midway -> ok X c - Check in to Franklin -> ok X d - Check in to Fairfield -> not ok X e - Check in to Liberty -> ok 3 - 'the library the item is owned by' X a - Check in to Centerville -> ok X b - Check in to Midway -> ok X c - Check in to Franklin -> ok X d - Check in to Fairfield -> not ok X e - Check in to Liberty -> not ok Sponsored-by: National Library of Finland Signed-off-by: Arthur Suzuki <arthur.suzuki(a)biblibre.com> Signed-off-by: Julian Maurice <julian.maurice(a)biblibre.com> Signed-off-by: Baptiste Wojtkowski <baptiste.wojtkowski(a)biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7376] Transfer limits should be checked at check-in
by bugzilla-daemon＠bugs.koha-community.org 17 Apr '25

17 Apr '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376 --- Comment #162 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski(a)biblibre.com> --- Yep that makes sense to me. Concerning your second point, I tested it and it is the same. I did not add this to the test plan to keep it """simple""" III.1, III.2, III.3 were just requiring their specific part of the tests but do not need specific concerns -- You are receiving this mail because: You are watching all bug changes.

1 0