July 2025 - Koha-bugs - lists.koha-community.org

[Bug 39096] New: Add "tidy all" commits to a git blame ignore file
by bugzilla-daemon＠bugs.koha-community.org 13 Nov '25

13 Nov '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39096 Bug ID: 39096 Summary: Add "tidy all" commits to a git blame ignore file Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: jonathan.druart(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org Depends on: 38664 To get a relevant blame we want to exclude some commits from bug 38664. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38664 [Bug 38664] Tidy the whole codebase -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 26

[Bug 39106] New: Improve the auto-rebase script to retrieve patches from bugzilla
by bugzilla-daemon＠bugs.koha-community.org 13 Nov '25

13 Nov '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39106 Bug ID: 39106 Summary: Improve the auto-rebase script to retrieve patches from bugzilla Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart(a)gmail.com Reporter: jonathan.druart(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org Depends on: 38664 Julian wrote a script a while ago to retrieve patches from bugzilla and checkout the good commit to make sure the patches will apply cleanly. We could reuse the same logic for the auto-rebase script. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38664 [Bug 38664] Tidy the whole codebase -- You are receiving this mail because: You are watching all bug changes.

1 22

[Bug 39101] New: warning: "sort (...) interpreted as function" when running updatedatabase
by bugzilla-daemon＠bugs.koha-community.org 13 Nov '25

13 Nov '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39101 Bug ID: 39101 Summary: warning: "sort (...) interpreted as function" when running updatedatabase Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Installation and upgrade (command-line installer) Assignee: koha-bugs(a)lists.koha-community.org Reporter: victor(a)tuxayo.net QA Contact: testopia(a)bugs.koha-community.org CC: tomascohen(a)gmail.com sort (...) interpreted as function at /kohadevbox/koha/installer/data/mysql/updatedatabase.pl line 25950. It starts happening after that commit: d659526b5a Bug 38664: Tidy the whole codebase A more minimal example can be reproduced: ``` my $var_with_long_name_1 = "2019-10-30"; my $var_with_long_name_2 = "2005-01-10"; my $var_with_long_name_3 = "2010-02-01"; # no warning my ($max_value1) = sort ( $var_with_long_name_1, $var_with_long_name_2, $var_with_long_name_3 ); warn $max_value1; # sort (...) interpreted as function my ($max_value2) = sort ( $var_with_long_name_1, $var_with_long_name_2, $var_with_long_name_3 ); # sort (...) interpreted as function my ($max_value3) = sort ( $var_with_long_name_1, $var_with_long_name_2, $var_with_long_name_3 ); # sort (...) interpreted as function my ($max_value4) = sort ( $var_with_long_name_1, $var_with_long_name_2, $var_with_long_name_3 ); ``` perl -w test.pl sort (...) interpreted as function at test.pl line 11. sort (...) interpreted as function at test.pl line 15. sort (...) interpreted as function at test.pl line 20. 2005-01-10 at test.pl line 8. So somehow perl doesn't like when here the args aren't in the same line. And the sorting is ascending so it gets the min value when it seems the intent was to get the max value! https://gitlab.com/koha-community/Koha/-/blob/93eda45a9e6d492161096a0536a19… > my ($max_date) = sort ( $suggestion->{manageddate} || (), $suggestion->{accepteddate} || (), > $suggestion->{rejecteddate} || () ); -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 6

[Bug 39112] New: Item search returns error
by bugzilla-daemon＠bugs.koha-community.org 13 Nov '25

13 Nov '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39112 Bug ID: 39112 Summary: Item search returns error Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: blocker Priority: P5 - low Component: Staff interface Assignee: koha-bugs(a)lists.koha-community.org Reporter: caroline.cyr-la-rose(a)inlibro.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com To recreate : 1. Go to Item search 2. Click 'Search' --> Something went wrong when loading the table. 200: OK. --> No results I also tried with homebranch = Centerville and it's the same. If there are no results (e.g. homebranch = Fairfield), there is no message. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 17

[Bug 39395] New: sco login form not correctly placed
by bugzilla-daemon＠bugs.koha-community.org 13 Nov '25

13 Nov '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39395 Bug ID: 39395 Summary: sco login form not correctly placed Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: OPAC Assignee: jonathan.druart(a)gmail.com Reporter: jonathan.druart(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org Depends on: 38664 It is at the bottom of the screen. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38664 [Bug 38664] Tidy the whole codebase -- You are receiving this mail because: You are watching all bug changes.

1 16

[Bug 40319] New: Fix spacing in address display include
by bugzilla-daemon＠bugs.koha-community.org 13 Nov '25

13 Nov '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40319 Bug ID: 40319 Summary: Fix spacing in address display include Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org Depends on: 38664 Bug 38664 introduced indentation and spacing changes which affected the way addresses are displayed in member-display-address-style.inc. This caused spaces to disappear between address parts, for example between city and state in the US layout. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38664 [Bug 38664] Tidy the whole codebase -- You are receiving this mail because: You are watching all bug changes.

1 16

[Bug 39110] New: Auto-rebase script is slow
by bugzilla-daemon＠bugs.koha-community.org 13 Nov '25

13 Nov '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39110 Bug ID: 39110 Summary: Auto-rebase script is slow Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: jonathan.druart(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org Depends on: 38664 It loops over the files and call tidy.pl on each of them. tidy.pl can take a list of files in parameters, then tidy is run in parallel. It would be more effective, but not sure it is worth to spend too much time on this script. Only logging the issue, I don't plan to work on this. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38664 [Bug 38664] Tidy the whole codebase -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 1

[Bug 39111] New: Tidying template files is ineffective
by bugzilla-daemon＠bugs.koha-community.org 13 Nov '25

13 Nov '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39111 Bug ID: 39111 Summary: Tidying template files is ineffective Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: jonathan.druart(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org Depends on: 38664 There are 2 pass, we call the prettier plugin twice because there was an idempotent problem: I had to pretty the script at least twice to make it tidy and to make the script returning the same output. We could try to remove those 2 passes and see if it fixes the problem (ie. the xt/tt_tidy.t does not fail) for new changes. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38664 [Bug 38664] Tidy the whole codebase -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 1

[Bug 39151] New: xt/verify-yarnlock.t creates a lot of warnings
by bugzilla-daemon＠bugs.koha-community.org 13 Nov '25

13 Nov '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39151 Bug ID: 39151 Summary: xt/verify-yarnlock.t creates a lot of warnings Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: chris(a)bigballofwax.co.nz Reporter: katrin.fischer(a)bsz-bw.de QA Contact: testopia(a)bugs.koha-community.org Depends on: 38664 xt/verify-yarnlock.t ............. warning "@babel/code-frame##js-tokens@^4.0.0" could be deduped from "4.0.0" to "js-tokens(a)4.0.0" warning "@babel/code-frame##picocolors@^1.0.0" could be deduped from "1.0.0" to "picocolors(a)1.0.0" warning "@babel/parser##@babel/types@^7.26.8" could be deduped from "7.26.8" to "@babel/types@7.26.8" warning "@jridgewell/gen-mapping##@jridgewell/set-array@^1.2.1" could be deduped from "1.2.1" to "@jridgewell/set-array@1.2.1" warning "@jridgewell/gen-mapping##@jridgewell/sourcemap-codec@^1.4.10" could be deduped from "1.4.14" to "@jridgewell/sourcemap-codec@1.4.14" warning "@jridgewell/gen-mapping##@jridgewell/trace-mapping@^0.3.24" could be deduped from "0.3.25" to "@jridgewell/trace-mapping@0.3.25" warning "@jridgewell/trace-mapping##@jridgewell/resolve-uri@^3.1.0" could be deduped from "3.1.2" to "@jridgewell/resolve-uri@3.1.2" warning "@types/express##@types/body-parser@*" could be deduped from "1.19.2" to "@types/body-parser@1.19.2" warning "@types/express##@types/express-serve-static-core@^4.17.18" could be deduped from "4.17.31" to "@types/express-serve-static-core@4.17.31" warning "@types/express##@types/qs@*" could be deduped from "6.9.7" to "@types/qs@6.9.7" warning "@types/express##@types/serve-static@*" could be deduped from "1.15.0" to "@types/serve-static@1.15.0" warning "@types/express-serve-static-core##@types/node@*" could be deduped from "18.11.2" to "@types/node@18.11.2" warning "@types/express-serve-static-core##@types/qs@*" could be deduped from "6.9.7" to "@types/qs@6.9.7" warning "@types/express-serve-static-core##@types/range-parser@*" could be deduped from "1.2.4" to "@types/range-parser@1.2.4" warning "@types/serve-static##@types/mime@*" could be deduped from "3.0.1" to "@types/mime@3.0.1" warning "@types/serve-static##@types/node@*" could be deduped from "18.11.2" to "@types/node@18.11.2" warning "ajv##fast-deep-equal(a)^3.1.1" could be deduped from "3.1.3" to "fast-deep-equal(a)3.1.3" warning "ajv##fast-json-stable-stringify(a)^2.0.0" could be deduped from "2.1.0" to "fast-json-stable-stringify(a)2.1.0" ... Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38664 [Bug 38664] Tidy the whole codebase -- You are receiving this mail because: You are watching all bug changes.

1 8

[Bug 39152] New: Variables defined as `our` not tidied
by bugzilla-daemon＠bugs.koha-community.org 13 Nov '25

13 Nov '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39152 Bug ID: 39152 Summary: Variables defined as `our` not tidied Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: tomascohen(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org If you look at `tools/newHolidays` you will notice the file is not tidy. To reproduce: 1. Look at `tools/newHolidays` which is clearly not tidy 2. Run: $ ktd --shell k$ perl misc/devel/tidy.pl tools/newHolidays.pl k$ git diff => FAIL: No changes! 3. Replace `our` for `my` on the variable definitions 4. Repeat 2 => SUCCESS: The file is correctly tidied now! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 7