July 2025 - Koha-bugs - lists.koha-community.org

[Bug 15516] Allow to place a hold on first available item from a group of titles
by bugzilla-daemon＠bugs.koha-community.org 09 Jul '25

09 Jul '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #485 from David Cook <dcook(a)prosentient.com.au> --- I've rebased the patches, fixed some obvious typos and bugs, and in "My upstream Koha test plan" I make a note of some things that are broken in the rebased version. Overall, the test plans seems to be working (although I think there are also some subtle bugs with hold limits from circ rules). As noted in the test plan, I have additional code that I run locally, so I still have work to do... -- In theory, locally (NOT with the attached above patches), I should be able to do the following with 15516+15565: OPAC: 15565 - Detail page: can place multiple item holds - Results page: can place multiple item holds for multiple records 15516 - Detail page: can place "group hold" using multiple items from 1 bib - Result page: you can place "treat as hold group" group holds across multiple bibs at bib-level or item-level - User page: See "(part of a hold group)", clicking text shows list of barcodes or bib numbers (if bib-level hold) with links to bib records Staff Interface: 15565 - Detail page: can place multiple item holds - Results page: you can't place multiple item holds across different bibs 15516 - Detail page: you can tick multiple specific items and click "Treat as hold group" - Results page: you can place "next available" bib-level group holds across multiple bibs -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15516] Allow to place a hold on first available item from a group of titles
by bugzilla-daemon＠bugs.koha-community.org 09 Jul '25

09 Jul '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #484 from David Cook <dcook(a)prosentient.com.au> --- My upstream Koha test plan: __Setup__ 0. koha-upgrade-schema kohadev 1. koha-plack --restart kohadev 2. prove t/db_dependent/Koha/Holds.t t/db_dependent/Reserves/HoldGroup.t 3. Enable "DisplayAddHoldGroups" system preference __OPAC results__ 1. Go to http://localhost:8080/cgi-bin/koha/opac-search.pl?idx=&q=test&weight_search… 2. Checkbox results "Gairm" and "Clean code" 3. Click "Place hold" at the top of the search results 4. Checkbox "Treat as hold group (next available item fulfills all holds)" 5. Click "Confirm hold" 6. Go to http://localhost:8080/cgi-bin/koha/opac-user.pl 7. Click "Holds" 8. Confirm the two holds appear with the text "part of a hold group", and when you click on that text it shows you both hold group titles 9. Note the "Holds" tab shows 1 hold signifying the 2 holds in the hold group count as 1 hold total NOTE: Currently, within the table it says "Holds (2 total)" as there are 2 hold rows... 10. In the staff interface, check in "39999000001310" 11. Click "Confirm hold (Y)" 12. Go to http://localhost:8081/cgi-bin/koha/circ/circulation.pl?borrowernumber=51 13. Note only 1 hold appears, and when you click on "part of a hold group" it only shows 1 hold title FIXME: The modal close buttons are currently broken FIXME: The modal also doesn't look quite right... 12. In the OPAC, go to http://localhost:8080/cgi-bin/koha/opac-user.pl 13. Note that only 1 hold appears now 14. Go to http://localhost:8081/cgi-bin/koha/circ/circulation.pl?borrowernumber=51 15. Cancel the hold __Staff interface results__ 1. Go to http://localhost:8081/cgi-bin/koha/catalogue/search.pl?q=test 2. Checkbox results "Gairm" and "Clean code" 3. Click "Place hold" at the top of the search results 4. Search for patron "koha" and choose the one with card 42 5. Check box "Treat as hold group" 6. Choose "Centerville" as "Pickup location" NOTE: Trying to choose "Pickup at" doesn't seem to work. You have to specify individual "Pickup location" 7. Click "Place holds" 8. Click on "part of a hold group" on the each hold and note the modal with "Hold group" appears showing the 2 titles FIXME: The modal close buttons are currently broken FIXME: The modal also doesn't look quite right... 9. Check in "39999000001310" 10. Click "Confirm hold (Y)" 11. Go to http://localhost:8081/cgi-bin/koha/circ/circulation.pl?borrowernumber=51 12. Cancel the hold __OPAC detail__ TODO: Now that bug 15565 is pushed we can revisit this (using syspref DisplayMultiItemHolds) NOTE: I have local code for this that I'll upstream... __Staff interface detail__ TODO: Now that bug 15565 is pushed we can revisit this (using syspref DisplayMultiItemHolds) NOTE: I have local code for this that I'll upstream... __Staff interface (OTHER)__ 1. Go to http://localhost:8081/cgi-bin/koha/circ/view_holdsqueue.pl?branchlimit=CPL&… FIXME: This returns a 500 error NOTE: I have this working locally... -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15516] Allow to place a hold on first available item from a group of titles
by bugzilla-daemon＠bugs.koha-community.org 09 Jul '25

09 Jul '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 David Cook <dcook(a)prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162084|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15516] Allow to place a hold on first available item from a group of titles
by bugzilla-daemon＠bugs.koha-community.org 09 Jul '25

09 Jul '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 David Cook <dcook(a)prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162083|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15516] Allow to place a hold on first available item from a group of titles
by bugzilla-daemon＠bugs.koha-community.org 09 Jul '25

09 Jul '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 David Cook <dcook(a)prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162082|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15516] Allow to place a hold on first available item from a group of titles
by bugzilla-daemon＠bugs.koha-community.org 09 Jul '25

09 Jul '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 David Cook <dcook(a)prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162081|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15516] Allow to place a hold on first available item from a group of titles
by bugzilla-daemon＠bugs.koha-community.org 09 Jul '25

09 Jul '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 David Cook <dcook(a)prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162080|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15516] Allow to place a hold on first available item from a group of titles
by bugzilla-daemon＠bugs.koha-community.org 09 Jul '25

09 Jul '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #483 from David Cook <dcook(a)prosentient.com.au> --- Created attachment 183880 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183880&action=e… Bug 15516: (follow-up) Tweaks to new feature Bug 15516: Add ability to create and view hold groups from OPAC This patch adds a "Treat as hold group" to opac-reserve.pl, which lets OPAC users create a hold group which can include 1+ bibs and either bib-level holds, or item-level holds, or both. This patch shows the item-level and bib-level holds in a hold group for the user's holds in the OPAC. This includes both the opac-user.pl page and the self-checkout hold display. Bug 15516: (follow-up) Only show hold groups for multi hold in OPAC Bug 15516: (follow-up) Only show hold groups for multi hold in staff interface Bug 15516: Add 'DisplayAddHoldGroups' system preference to toggle ability to add titles to hold groups These patches add the ability to create hold groups across multiple bibs in the staff interface or OPAC. These hold groups are fulfilled by the first item checked in across the hold group. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15516] Allow to place a hold on first available item from a group of titles
by bugzilla-daemon＠bugs.koha-community.org 09 Jul '25

09 Jul '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 David Cook <dcook(a)prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162079|0 |1 is obsolete| | --- Comment #482 from David Cook <dcook(a)prosentient.com.au> --- Created attachment 183879 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183879&action=e… Bug 15516: Allow to reserve first available item from a group of titles It can be useful, for instance, if a library has the same title from different publishers (so 1 title but several biblio records) but the user only wants a copy of the book, regardless of the publisher. Test plan: 0. Run updatedatabase.pl and misc/devel/update_dbix_class_files.pl 1. Go to intranet search, display some results, click on some checkboxes and click on 'Place hold' button at the top of the results. 2. Search for a patron 3. Check the 'Treat as hold group' checkbox 4. Click on 'Place hold' 5. In the next screen you should see all the holds you placed with the additional text '(part of a hold group)' in Details column. 6. Click on the "hold group" link. A modal window should appear with the content of the hold group (a list of holds) 7. Check in an item of one of the reserved biblios and confirm the hold 8. The hold status is changed to Waiting, and all other holds are deleted. The other holds will also be removed from the holds queue. 9. Confirm tests pass - t/db_dependent/Koha/Holds.t - t/db_dependent/Reserves/HoldGroup.t Note: the "hold group" link is displayed in the following pages: - reserve/request.pl - circ/circulation.pl - members/moremember.pl - circ/pendingreserves.pl - circ/view_holdsqueue.pl Note: A hold group is counted as only one hold Sponsored-by: Catalyst IT Signed-off-by: Michal Denar <black23(a)gmail.com> Signed-off-by: Victor Grousset/tuxayo <victor(a)tuxayo.net> Signed-off-by: Michal Denar <black23(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15516] Allow to place a hold on first available item from a group of titles
by bugzilla-daemon＠bugs.koha-community.org 09 Jul '25

09 Jul '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 David Cook <dcook(a)prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162078|0 |1 is obsolete| | --- Comment #481 from David Cook <dcook(a)prosentient.com.au> --- Created attachment 183878 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183878&action=e… Bug 15516: Relevant controller changes and tests Signed-off-by: Michal Denar <black23(a)gmail.com> Signed-off-by: Victor Grousset/tuxayo <victor(a)tuxayo.net> Signed-off-by: Michal Denar <black23(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0