- Koha-bugs - lists.koha-community.org

[Bug 7132] Check for duplicates when creating a new record in acquisitions
by bugzilla-daemon＠bugs.koha-community.org 29 Aug '25

29 Aug '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7132 Michelle Spinney <mspinney(a)clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mspinney(a)clamsnet.org -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15516] Allow to place a hold on first available item from a group of titles
by bugzilla-daemon＠bugs.koha-community.org 29 Aug '25

29 Aug '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Andrew Fuerste-Henry <andrew(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185946|0 |1 is obsolete| | --- Comment #549 from Andrew Fuerste-Henry <andrew(a)bywatersolutions.com> --- Created attachment 185959 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185959&action=e… Bug 15516: Add new system preference to atomicupdate Signed-off-by: Andrew Fuerste Henry <andrew(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15516] Allow to place a hold on first available item from a group of titles
by bugzilla-daemon＠bugs.koha-community.org 29 Aug '25

29 Aug '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Andrew Fuerste-Henry <andrew(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185509|0 |1 is obsolete| | --- Comment #548 from Andrew Fuerste-Henry <andrew(a)bywatersolutions.com> --- Created attachment 185958 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185958&action=e… Bug 15516: Add missing Test::NoWarnings Signed-off-by: Andrew Fuerste Henry <andrew(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 30526] New: The pagination in the REST API does not work if $c->objects->search is called multiple times.
by bugzilla-daemon＠bugs.koha-community.org 29 Aug '25

29 Aug '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30526 Bug ID: 30526 Summary: The pagination in the REST API does not work if $c->objects->search is called multiple times. Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: REST API Assignee: koha-bugs(a)lists.koha-community.org Reporter: andreas.jonsson(a)kreablo.se CC: tomascohen(a)gmail.com The REST-plugin Koha::REST::Plugin::Pagination defines two methods: dbic_merge_pagination and add_pagination_headers. The method add_pagination_headers use the helper subroutine _build_link. The last call in add_pagination_headers looks like this: push @links, _build_link( $c, { page => $pages, per_page => $per_page, rel => 'last', params => $args->{params} } ); Here is _build_link: sub _build_link { my ( $c, $args ) = @_; my $params = $args->{params}; $params->{_page} = $args->{page}; $params->{_per_page} = $args->{per_page}; Note that the original parameters _page and _per_page is overwritten here. This means that _page will be $pages. Subsequent calls to $c->objects->search will, thus, always return the last page. At least REST::V1::Holds::pickup_locations is affected by this (because a redundant call to $c->objects->search is made if AllowHoldPolicyOverride is activated). This causes the dropdown menu with pickup locations in the holds view to only contain the last page of libraries if there are more than 20 pickup libraries and AllowHoldPolicyOverride is activated. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 7

[Bug 15516] Allow to place a hold on first available item from a group of titles
by bugzilla-daemon＠bugs.koha-community.org 29 Aug '25

29 Aug '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Andrew Fuerste-Henry <andrew(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185466|0 |1 is obsolete| | --- Comment #547 from Andrew Fuerste-Henry <andrew(a)bywatersolutions.com> --- Created attachment 185957 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185957&action=e… Bug 15516: (follow-up) fix count_holds() for CanBookBeReserved() This patch adds search_attrs to count_holds() since these get used with CanBookBeReserved. Test plan: 0. Apply the patch 1. prove t/db_dependent/Koha/Holds.t t/db_dependent/Reserves/HoldGroup.t t/db_dependent/Reserves.t Signed-off-by: Andrew Fuerste Henry <andrew(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15516] Allow to place a hold on first available item from a group of titles
by bugzilla-daemon＠bugs.koha-community.org 29 Aug '25

29 Aug '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Andrew Fuerste-Henry <andrew(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185465|0 |1 is obsolete| | --- Comment #546 from Andrew Fuerste-Henry <andrew(a)bywatersolutions.com> --- Created attachment 185956 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185956&action=e… Bug 15516: (follow-up) explicitly define indexes for foreign keys This patch explicitly defines indexes for foreign keys. This isn't really needed for the atomic update, but we've included it for consistency. It is needed in kohastructure.sql, because MySQL/MariaDB silently/implicitly adds these indexes for foreign keys, which means that the database audit tool will show a discrepancy between kohastructure.sql and the installed DB schema. Also fix a discrepancy between atomic update and kohastructure.sql Test plan: 0. Apply the patch 1. Use both methods to update the DB schema 2. Go to http://localhost:8081/cgi-bin/koha/about.pl?tab=database 3. Note that about.pl isn't telling you to drop the indexes for reserves_ibfk_hg and old_reserves_ibfk_hg now Signed-off-by: Andrew Fuerste Henry <andrew(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15516] Allow to place a hold on first available item from a group of titles
by bugzilla-daemon＠bugs.koha-community.org 29 Aug '25

29 Aug '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Andrew Fuerste-Henry <andrew(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185464|0 |1 is obsolete| | --- Comment #545 from Andrew Fuerste-Henry <andrew(a)bywatersolutions.com> --- Created attachment 185955 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185955&action=e… Bug 15516: (follow-up) Add hold_group_id to hold REST API definition Brought to light by accessing the following page with the feature enabled: http://localhost:8081/cgi-bin/koha/members/holdshistory.pl?borrowernumber=51 Also by running the following tests file before this patch: t/db_dependent/api/v1/holds.t Signed-off-by: Pedro Amorim <pedro.amorim(a)openfifth.co.uk> Signed-off-by: Andrew Fuerste Henry <andrew(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15516] Allow to place a hold on first available item from a group of titles
by bugzilla-daemon＠bugs.koha-community.org 29 Aug '25

29 Aug '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Andrew Fuerste-Henry <andrew(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185463|0 |1 is obsolete| | --- Comment #544 from Andrew Fuerste-Henry <andrew(a)bywatersolutions.com> --- Created attachment 185954 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185954&action=e… Bug 15516: (follow-up) integrate BZ 15516 and BZ 15565 This patch makes DisplayAddHoldGroups and DisplayMultiItemHolds work together, so that you can add multiple items to 1 hold group from the staff detail page, the OPAC detail page, or the OPAC search results. Note: At this time, you can't add multiple items to a hold group from the staff search results. This is due to the existing constraints in request.pl Over the last 10 years, in practice most hold groups have been formed at the OPAC anyway. Test plan: __OPAC search results__ - Enable both DisplayAddHoldGroups and DisplayMultiItemHolds - Go to http://localhost:8080/cgi-bin/koha/opac-search.pl?idx=&q=test&weight_search… - Choose "Gairm" and "Continuous delivery" and click "Place hold" - Checkbox "Treat as hold group" - Click "Show more options" for each record - Click "A specific item" for "Continuous delivery" - Checkbox both specific items for that title - Press "Confirm hold" - Note 3 holds are in the hold group - Cancel all the holds __OPAC detail page__ - Go to http://localhost:8080/cgi-bin/koha/opac-detail.pl?biblionumber=134 - Click "Place hold" - Checkbox "Treat as hold group" - Click "Show more options" - Choose "A specific item" - Checkbox both items - Click "Confirm hold" - Note 2 holds are in the hold group - Cancel all the holds __Staff detail page__ - Go to http://localhost:8081/cgi-bin/koha/reserve/request.pl?biblionumber=134&borr… - Choose "Hold a specific item" - Checkbox "Treat as hold group" - Checkbox both items - Click "Place hold" - Note 2 holds are in the hold group - Cancel all the holds Signed-off-by: Pedro Amorim <pedro.amorim(a)openfifth.co.uk> Signed-off-by: Andrew Fuerste Henry <andrew(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15516] Allow to place a hold on first available item from a group of titles
by bugzilla-daemon＠bugs.koha-community.org 29 Aug '25

29 Aug '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Andrew Fuerste-Henry <andrew(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185462|0 |1 is obsolete| | --- Comment #543 from Andrew Fuerste-Henry <andrew(a)bywatersolutions.com> --- Created attachment 185953 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185953&action=e… Bug 15516: (follow-up) Have DisplayAddHoldGroups disabled by default Signed-off-by: Pedro Amorim <pedro.amorim(a)openfifth.co.uk> Signed-off-by: Andrew Fuerste Henry <andrew(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15516] Allow to place a hold on first available item from a group of titles
by bugzilla-daemon＠bugs.koha-community.org 29 Aug '25

29 Aug '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Andrew Fuerste-Henry <andrew(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185461|0 |1 is obsolete| | --- Comment #542 from Andrew Fuerste-Henry <andrew(a)bywatersolutions.com> --- Created attachment 185952 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185952&action=e… Bug 15516: (follow-up) Fix some merge bugs Signed-off-by: Pedro Amorim <pedro.amorim(a)openfifth.co.uk> Signed-off-by: Andrew Fuerste Henry <andrew(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0