- Koha-bugs - lists.koha-community.org

[Bug 14250] Can generate discharge for patrons with fines
by bugzilla-daemon＠bugs.koha-community.org 26 Aug '24

26 Aug '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14250 --- Comment #22 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 170707 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170707&action=e… Bug 14250: (QA follow-up) Tidy code -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14250] Can generate discharge for patrons with fines
by bugzilla-daemon＠bugs.koha-community.org 26 Aug '24

26 Aug '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14250 --- Comment #21 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 170706 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170706&action=e… Bug 14250: (QA follow-up) Deduplicate checks Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14250] Can generate discharge for patrons with fines
by bugzilla-daemon＠bugs.koha-community.org 26 Aug '24

26 Aug '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14250 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170662|0 |1 is obsolete| | Attachment #170663|0 |1 is obsolete| | Attachment #170664|0 |1 is obsolete| | --- Comment #20 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 170705 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170705&action=e… Bug 14250: Patron with fines cannot be discharged anymore TEST PLAN: 1 - In the intranet add fines to a client and ensure they have no checkout 2 - Set syspref useDischarge to 'Allow' 3 - On client profile click on "Discharge", see it is possible 4 - On the opac, go to the tab "Ask for discharge", see it is possible 5 - Apply patch 6 - Click on the button "Ask for discharge" -> it will not be possible and you will be propperly messaged 7 - Return to the tab "Ask for a discharge", there will be no button anymore 8 - On the intranet page, there will be no button anymore 9 - Check out a book 10 - Repeat 7 and 8 and see the message include issue with checkout 11 - Remove fine and repeat 7 & 8 Signed-off-by: Roman Dolny <roman.dolny(a)jezuici.pl> Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14250] Can generate discharge for patrons with fines
by bugzilla-daemon＠bugs.koha-community.org 26 Aug '24

26 Aug '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14250 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 35402] Update the OPAC and staff interface to Bootstrap 5
by bugzilla-daemon＠bugs.koha-community.org 26 Aug '24

26 Aug '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35402 Jonathan Druart <jonathan.druart(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed --- Comment #16 from Jonathan Druart <jonathan.druart(a)gmail.com> --- There is something wrong for ktd users: Error in plugin "sass" Message: koha-tmpl/intranet-tmpl/prog/css/src/installer.scss Error: Can't find stylesheet to import. ╷ 3 │ @import "../../../../../node_modules/bootstrap5/scss/functions"; │ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ╵ koha-tmpl/intranet-tmpl/prog/css/src/installer.scss 3:9 root stylesheet You are importing only what is in /kohadevbox/koha/node_modules. But we are expecting ktd to have /kohadevbox/node_modules part of the image. At the moment jenkins is failing because of this, `yarn css:build` does not succeed. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14250] Can generate discharge for patrons with fines
by bugzilla-daemon＠bugs.koha-community.org 26 Aug '24

26 Aug '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14250 David Nind <david(a)davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david(a)davidnind.com --- Comment #19 from David Nind <david(a)davidnind.com> --- I was just been about to say the same (that the patch no longer applies). 8-) I was testing last week, and hadn't finished before it was signed off. I had some suggested text changes - I am happy to add a follow-up once the patches apply again. This is so that it makes more sense if there are multiple reasons for not discharging. Suggested text changes for the OPAC =================================== You cannot be discharged because: . You have unpaid charges of X. Please pay your charges before reapplying. . You have X item(s) checked out. Please return your checked out items before reapplying. . You cannot be discharged for an unknown reason. Please contact library staff for more information. Suggested text changes for the staff interface ============================================== A discharge cannot be generated for this patron because: . The patron has unpaid charges of X. . The patron has X item(s) checked out. . The patron cannot be discharged for an unknown reason. Please review the patron's account to determine why. (Not sure about this one.) The patron has holds. These will be cancelled if the discharge is generated. Testing notes ============= 1. In the staff interface, set up these scenarios for some patrons: - Patron A: check out an item and add a manual fee (I used Henry Acevedo) - Patron B: add a manual fee (I used Mary Burton) - Patron C: check out an item (I used Lisa Charles) - Patron D: add a manual fee (I used Bobbie Middleton) 2. Edit the patrons so that they have a password and that you can log in to their accounts in the OPAC. 3. Set the useDischarge system preference to 'Allow'. 4. Attempt to request a discharge for the patrons (OPAC > You account > Ask for a discharge): - Patron A (Manual fee and a checked out item) (Henry): Message is "You cannot be discharged, you have checked out items. Please return items before asking for a discharge." - Patron B (Manual fee) (Mary): "Ask for a discharge" button is available and a discharge can be requested. Message "Your discharge request has been sent. Your discharge will be available on this page within a few days." - Patron C (A checked out item (Lisa)): Message is "You cannot be discharged, you have checked out items. Please return items before asking for a discharge." 5. Apply the patches and restart everything (restart_all). 6. Attempt to request a discharge for the patrons from their OPAC accounts (OPAC > You account > Ask for a discharge): - Patron A (Manual fee and a checked out item)(Henry): Message is now You cannot be discharged for following reasons: . You have 1 item(s) checked out. Please return them before reapplying. . They have unpaid fines totaling 5.00. Please pay your fines before reapplying. - Patron C (A checked out item) (Lisa): Message is now You cannot be discharged for following reasons: . You have 1 item(s) checked out. Please return them before reapplying. - Patron D (A manual fee)(Bobbie): You cannot be discharged for following reasons: . They have unpaid fines totaling 5.00. Please pay your fines before reapplying. 7. Attempt to discharge the patrons from the staff interface, from their patron account: - Patron A (Manual fee and a checked out item)(Henry): Message is now Cannot edit discharge for following reasons: . They have 1 item(s) checked out . They have unpaid fines totaling 5.00 - Patron C (A checked out item) (Lisa): Message is now Cannot edit discharge for following reasons: . They have 1 item(s) checked out - Patron D (A manual fee)(Bobbie): Cannot edit discharge for following reasons: . They have unpaid fines totaling 5.00 OPAC discharge text =================== I've created bug 37729 for the discharge text on the OPAC "Ask for a discharge" page, suggesting that this is changed to an HTML customization - so that the text can be customised and translated. Current hard coded text ----------------------- Discharge What is a discharge? This document certifies that you have returned all borrowed items. It is sometimes asked during a file transfer from a school to another. The discharge is sent by us to your school. You will also find it available on your reader account. Warning: This request is only valid if you are in good standing with the library. Once the application is made, you can not borrow library materials. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 37729] New: Add HTML customization for 'Ask for a discharge' page text
by bugzilla-daemon＠bugs.koha-community.org 26 Aug '24

26 Aug '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37729 Bug ID: 37729 Summary: Add HTML customization for 'Ask for a discharge' page text Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs(a)lists.koha-community.org Reporter: david(a)davidnind.com QA Contact: testopia(a)bugs.koha-community.org If the useDischarge system preference is enabled, the text on the 'Your account > Ask for a discharge' page is hard coded and cannot be customized. I think it would be useful to add this to Tools > Additional tools > HTML customizations, so that the text can be customized and translated. (Suggested name: OPACDischarge.) Current text ============ Discharge What is a discharge? This document certifies that you have returned all borrowed items. It is sometimes asked during a file transfer from a school to another. The discharge is sent by us to your school. You will also find it available on your reader account. Warning: This request is only valid if you are in good standing with the library. Once the application is made, you can not borrow library materials. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 14250] Can generate discharge for patrons with fines
by bugzilla-daemon＠bugs.koha-community.org 26 Aug '24

26 Aug '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14250 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Patch doesn't apply --- Comment #18 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Please rebase: Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 14250: Patron with fines cannot be discharged anymore Using index info to reconstruct a base tree... M koha-tmpl/intranet-tmpl/prog/en/modules/members/discharge.tt M koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-discharge.tt M t/db_dependent/Patron/Borrower_Discharge.t Falling back to patching base and 3-way merge... Auto-merging t/db_dependent/Patron/Borrower_Discharge.t Auto-merging koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-discharge.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/members/discharge.tt Applying: Bug 14250: (QA follow-up) Deduplicate checks Applying: Bug 14250: (QA follow-up) Tidy code error: sha1 information is lacking or useless (t/db_dependent/Patron/Borrower_Discharge.t). error: could not build fake ancestor -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 2486] Show user comments in staff interface
by bugzilla-daemon＠bugs.koha-community.org 26 Aug '24

26 Aug '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2486 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14322] Can't link to an item search
by bugzilla-daemon＠bugs.koha-community.org 26 Aug '24

26 Aug '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14322 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed --- Comment #36 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- 1) Translatability Please fix the "Copied!" string here to make it translatable. + $(this).tooltip({trigger: 'manual', title: 'Copied!'}).tooltip('show'); You can attach the follow-up patch here and reset to Passed QA if the status has changed already. -- You are receiving this mail because: You are watching all bug changes.

1 0