- Koha-bugs - lists.koha-community.org

[Bug 7376] Transfer limits should be checked at check-in
by bugzilla-daemon＠bugs.koha-community.org 19 Dec '24

19 Dec '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376 --- Comment #136 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski(a)biblibre.com> --- Created attachment 175696 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175696&action=e… Bug 7376: Allow passing 'transferbranch' to CanBookBeReturned This patch adds the optional 'tranferbranch' parameter to the CanBookBeReturned routine. This allows for passing the correct 'ReturnToX' transfer to be tested at return time for transfer limit restrictions. Signed-off-by: Julian Maurice <julian.maurice(a)biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7376] Transfer limits should be checked at check-in
by bugzilla-daemon＠bugs.koha-community.org 19 Dec '24

19 Dec '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376 --- Comment #135 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski(a)biblibre.com> --- Created attachment 175695 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175695&action=e… Subject: [PATCH] Bug 7376: Clarify tests further We want to prevent returns where the item cannot be transfered 'back to where it came from (be that Homebranch or Holdingbranch as defined respectively in the circulation rules). This patch clarifies the tests further by testing this transfer functionality distinctly from the 'AllowReturnToBranch' preference functionality. Signed-off-by: Julian Maurice <julian.maurice(a)biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7376] Transfer limits should be checked at check-in
by bugzilla-daemon＠bugs.koha-community.org 19 Dec '24

19 Dec '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376 --- Comment #134 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski(a)biblibre.com> --- Created attachment 175694 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175694&action=e… Bug 7376: (follow-up) Fix C4/Circulation.pm This follow-up patch actually fixes the issue. This patch forbids a patron to return a book to a library from where the book may not return to its home or holding library. Signed-off-by: Julian Maurice <julian.maurice(a)biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7376] Transfer limits should be checked at check-in
by bugzilla-daemon＠bugs.koha-community.org 19 Dec '24

19 Dec '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376 --- Comment #133 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski(a)biblibre.com> --- Created attachment 175693 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175693&action=e… Bug 7376: (follow-up) Make extended tests mock the actual desired behaviour Signed-off-by: Julian Maurice <julian.maurice(a)biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7376] Transfer limits should be checked at check-in
by bugzilla-daemon＠bugs.koha-community.org 19 Dec '24

19 Dec '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376 --- Comment #132 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski(a)biblibre.com> --- Created attachment 175692 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175692&action=e… Bug 7376: (follow-up) Extend test coverage and document I'm not sure about the requirements for this bug. This patch extends the tests to cover the new combinations introduced and highlights exactly what changes in the logic.. which appears to be fairly little. Signed-off-by: Julian Maurice <julian.maurice(a)biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7376] Transfer limits should be checked at check-in
by bugzilla-daemon＠bugs.koha-community.org 19 Dec '24

19 Dec '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376 --- Comment #131 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski(a)biblibre.com> --- Created attachment 175691 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175691&action=e… Bug 7376: Unit test Signed-off-by: Julian Maurice <julian.maurice(a)biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7376] Transfer limits should be checked at check-in
by bugzilla-daemon＠bugs.koha-community.org 19 Dec '24

19 Dec '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144435|0 |1 is obsolete| | Attachment #144436|0 |1 is obsolete| | Attachment #144437|0 |1 is obsolete| | Attachment #144438|0 |1 is obsolete| | Attachment #144439|0 |1 is obsolete| | Attachment #144440|0 |1 is obsolete| | Attachment #144441|0 |1 is obsolete| | --- Comment #130 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski(a)biblibre.com> --- Created attachment 175690 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175690&action=e… Bug 7376: Transfer limits should be checked at check-in Test case: * UseBranchTransferLimits must be set * define your branch transfer limit. Refuse transfers from libraryA to libraryB * checkout a book owned by libraryB, from libraryB, with a librarian located at libraryB * move the librarian to libraryA ("Set Library" link top/right) * check-in the book => it's possible whatever your setup After the patch, the behaviour respect the branch transfer limit parameter: you can check-in if you accept transfers, you can't if you refuse them. (Note: IndependantBranches must be OFF, otherwise it's not possible to do the checkin whatever the branch transfer limits) Sponsored-by: National Library of Finland Signed-off-by: Arthur Suzuki <arthur.suzuki(a)biblibre.com> Signed-off-by: Julian Maurice <julian.maurice(a)biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7376] Transfer limits should be checked at check-in
by bugzilla-daemon＠bugs.koha-community.org 19 Dec '24

19 Dec '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8137] Checkout limit for all libraries
by bugzilla-daemon＠bugs.koha-community.org 19 Dec '24

19 Dec '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8137 --- Comment #133 from Mathieu Saby <mathsabypro(a)gmail.com> --- Hi We would be interested by testing too. Thibauld do you plan to provide a fixed patch in next months ? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 38618] New: Remove implicit template translations (in .tt and .inc), use only explicit macro invocations
by bugzilla-daemon＠bugs.koha-community.org 19 Dec '24

19 Dec '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38618 Bug ID: 38618 Summary: Remove implicit template translations (in .tt and .inc), use only explicit macro invocations Change sponsored?: --- Product: Koha Version: Main Hardware: All URL: https://wiki.koha-community.org/wiki/Translation_in_te mplates_fix_RFC OS: All Status: NEW Severity: enhancement Priority: P4 Component: I18N/L10N Assignee: koha-bugs(a)lists.koha-community.org Reporter: schodkowy.omegi-0r(a)icloud.com QA Contact: testopia(a)bugs.koha-community.org CC: f.demians(a)tamil.fr, jonathan.druart(a)gmail.com, julian.maurice(a)biblibre.com See this: https://wiki.koha-community.org/wiki/Translation_in_templates_fix_RFC Also important thread on mattermost: https://chat.koha-community.org/koha-community/channels/translators/m5yxaxz… -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 4