- Koha-bugs - lists.koha-community.org

[Bug 13945] Multiple dialogs for item that needs transferred and hold captured at checkin
by bugzilla-daemon＠bugs.koha-community.org 15 May '24

15 May '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13945 Laura Escamilla <Laura.escamilla(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs(a)lists.koha-commun |Laura.escamilla@bywatersolu |ity.org |tions.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0

[Bug 13945] Multiple dialogs for item that needs transferred and hold captured at checkin
by bugzilla-daemon＠bugs.koha-community.org 15 May '24

15 May '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13945 --- Comment #1 from Laura Escamilla <Laura.escamilla(a)bywatersolutions.com> --- Created attachment 166785 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166785&action=e… Bug 13945: Prevent multiple dialog modals from popping up when capturing a hold at checkin 1. Select/Create Library Branches: - Select or create two library branches: Library A and Library B. 2. Locate/Create Item: - Locate or create an item with the "Current library" and "Home library" set to Library A. 3. Place Hold: - Place a hold on the item for a patron whose pickup location is Library B. 4. Check-in at Library A - First Attempt: - Check in the item at Library A. - Verify that the 'Hold found' modal pops up. - Click on 'Confirm hold and transfer'. 5. Check-in at Library A - Second Attempt: - Check in the item at Library A again. - Verify that the 'Hold found' modal pops up. - Click on 'Ignore'. - Verify that the 'Please return this item to (Library B)' modal has popped up behind it. 6. Apply Patch and Restart: - Apply the patch to the system. - Restart all relevant services. 7. Repeat Check-in Process: - Repeat steps 4 and 5. - Verify that no matter how many times you check in the item and hit 'Ignore' or 'Confirm the hold', the second modal does not pop up. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0

[Bug 13945] Multiple dialogs for item that needs transferred and hold captured at checkin
by bugzilla-daemon＠bugs.koha-community.org 15 May '24

15 May '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13945 Laura Escamilla <Laura.escamilla(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 15279] Deprecate bespoke syntax for Slips and Notices
by bugzilla-daemon＠bugs.koha-community.org 15 May '24

15 May '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15279 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |36815 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36815 [Bug 36815] Add the option to 'Reset to default' in the notices editor -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14251] Allow use of CSS in discharge letter
by bugzilla-daemon＠bugs.koha-community.org 15 May '24

15 May '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14251 --- Comment #45 from David Cook <dcook(a)prosentient.com.au> --- (In reply to Katrin Fischer from comment #43) > (In reply to David Cook from comment #40) > > Reviewing about.pl and noticed the missing weasyprint on an upgraded system. > > Like often happens, it looks like it's in debian/control.in but not > > debian/control. We need to get better at managing packaged dependencies... > > I just added it the other week - did you check main? Ah cheers. I thought that I had an up-to-date main, but it appears that I didn't! My bad. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14251] Allow use of CSS in discharge letter
by bugzilla-daemon＠bugs.koha-community.org 15 May '24

15 May '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14251 --- Comment #44 from David Cook <dcook(a)prosentient.com.au> --- But I've also just been in an extra cranky mood today and commenting at 11:47pm doesn't help 😅. I'll try to add some more positive comments... I used wkhtmltopdf for years as a CLI tool, but I've found in recent years Webkit doesn't render many webpages very well anymore. Complex HTML/CSS/Javascript that looks good in Chrome often wouldn't look good in the Webkit used by wkhtmltopdf. Still... a pretty good tool overall. Headless Chrome is great, since it's the closest to the Chrome user experience, but... as a CLI tool it's a bit limited in terms of options. My overall preference these days for HTML to PDF is either Puppeteer or Playwright. While there are bindings out there (not for Perl though I think), I use Node.js to control them, and I have them use Chrome under the head (stored in their node_modules directory). I've found these tools to produce the most accurate outputs. However, Puppeteer, Playwright, and Chrome are probably all too heavyweight for Koha. While I moaned about weasyprint having 500MB of dependencies, they're mostly Python libraries and low level libraries. And they're all packaged up. As Kyle said... if weasyprint works fine then I wouldn't rock the boat. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14251] Allow use of CSS in discharge letter
by bugzilla-daemon＠bugs.koha-community.org 15 May '24

15 May '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14251 --- Comment #43 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- (In reply to David Cook from comment #40) > Reviewing about.pl and noticed the missing weasyprint on an upgraded system. > Like often happens, it looks like it's in debian/control.in but not > debian/control. We need to get better at managing packaged dependencies... I just added it the other week - did you check main? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14251] Allow use of CSS in discharge letter
by bugzilla-daemon＠bugs.koha-community.org 15 May '24

15 May '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14251 --- Comment #42 from David Cook <dcook(a)prosentient.com.au> --- Also probably would've been better to create a Koha::HtmlToPDF module or something like that, so that it could be re-used in other parts of Koha. For instance, I imagine we could add this into the label creator at some stage. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14251] Allow use of CSS in discharge letter
by bugzilla-daemon＠bugs.koha-community.org 15 May '24

15 May '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14251 --- Comment #41 from David Cook <dcook(a)prosentient.com.au> --- Also, weasyprint installs an additional 57 packaged dependencies totally up 504MB. Sometimes, we quibble over adding 1 Perl dependency, but then this huge one gets added with little discussion. Might've been better to make this optional. Keeping the original code and then optionally using weasyprint if you wanted better HTML to PDF support. Hmm... too late now I guess. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14251] Allow use of CSS in discharge letter
by bugzilla-daemon＠bugs.koha-community.org 15 May '24

15 May '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14251 David Cook <dcook(a)prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook(a)prosentient.com.au --- Comment #40 from David Cook <dcook(a)prosentient.com.au> --- Reviewing about.pl and noticed the missing weasyprint on an upgraded system. Like often happens, it looks like it's in debian/control.in but not debian/control. We need to get better at managing packaged dependencies... -- You are receiving this mail because: You are watching all bug changes.

1 0