- Koha-bugs - lists.koha-community.org

[Bug 6796] Overnight checkouts taking into account opening and closing hours
by bugzilla-daemon＠bugs.koha-community.org 08 Apr '24

08 Apr '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6796 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162096|0 |1 is obsolete| | --- Comment #131 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 164517 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164517&action=e… Bug 6796: Updated schema files -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 6796] Overnight checkouts taking into account opening and closing hours
by bugzilla-daemon＠bugs.koha-community.org 08 Apr '24

08 Apr '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6796 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162095|0 |1 is obsolete| | --- Comment #130 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 164516 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164516&action=e… Bug 6796: Don't add a day if hourly loan period pushes due date If ConsiderLibraryHoursWhenIssuing is set to shorten the loan period to the closing time, if the loan period initially pushes the due date to the following day, the day still gets added when calculating the due date. We simply need to hardcode the due time here as the due day is the same as the issue day. We only need to calculate a due date if ConsiderLibraryHoursWhenIssuing is set to extend the loan period to the next opening day, as we'll need to consider holidays/closed days. Signed-off-by: Sam Lau <samalau(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 6796] Overnight checkouts taking into account opening and closing hours
by bugzilla-daemon＠bugs.koha-community.org 08 Apr '24

08 Apr '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6796 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162094|0 |1 is obsolete| | --- Comment #129 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 164515 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164515&action=e… Bug 6796: Fix saving of libraries and tests Signed-off-by: Sam Lau <samalau(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 6796] Overnight checkouts taking into account opening and closing hours
by bugzilla-daemon＠bugs.koha-community.org 08 Apr '24

08 Apr '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6796 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162093|0 |1 is obsolete| | --- Comment #128 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 164514 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164514&action=e… Bug 6796: (follow-up) Fix logic for calculating following day's open hours Since days for branch hours are stored as 0-6 in the database, when it's a Saturday (6) incrementing the date leads to an error when issuing an hourly loan because no opening hours are found for the non-existent day (7). This patch fixes this by calculating the tomorrow day and setting it to 0 if it's greater than 6. This patch also corrects the mappings for days, where local_day_of_week caluclates the date with Sunday first, which put it out of sync with the database opening hours days. Sponsored-by: Auckland University of Technology Sponsored-by: Catalyst IT Signed-off-by: Sam Lau <samalau(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 6796] Overnight checkouts taking into account opening and closing hours
by bugzilla-daemon＠bugs.koha-community.org 08 Apr '24

08 Apr '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6796 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162092|0 |1 is obsolete| | --- Comment #127 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 164513 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164513&action=e… Bug 6796: Consider library hours when calculating due date + tests This feature adds the ability to set opening and closing hours for your library and for these hours to be considered when calculating due dates for hourly loans. If the due date for an hourly loan falls after the library closes, the library can choose for the due date to be shortened to meet the close time, or extended to meet the open time the next day. This feature adds a new table 'branch_hours' for storing the open and close times per day for each library, and a new system preference 'ConsiderLibraryHoursInCirculation' to choose which behaviour should be followed when calculating due dates. To test: 1. Apply patches and update database. Upgrade schema if not applying patch with schema changes. Restart services. 2. Go to Administration -> Libraries. Edit a library and scroll to the bottom to find the 'opening hours' section. Test adding and removing open and close times on various days. Confirm saving works as expected. 3. Add a new library and test adding open and close times works as expected. 4. Edit your default library and save open and close times for each day. 5. Go to Administration -> Circulation and fine rules. Edit a rule, set the unit to 'hours' and set the loan period to a number that would cause a checkout to be due after the close time you just set, i.e. if you set your close time to be 5pm and your system time is currently 1pm, set the loan period to be 5 (5 hours) so the calculated due date would be 6pm. 6. Go to Administration -> system preferences. Search for ConsiderLibraryHoursInCirculation. It should be under 'Checkout policy' in the Circulation system preferences. Confirm the pre-selected option is 'ignore'. Keep this tab open. 6. In a new tab, get the barcode for an item that has an itemtype matching the circulation rule you just set. 7. Go to the checkouts for a patron that has a categorycode matching the circulation rule you just set. 8. Check out your item. Confirm that the checkout is due at the end of the loan period, not taking closing hours into consideration. Return the item. 9. Back in your other tab, set ConsiderLibraryHoursInCirculation to 'close', so the due date should be shortened to meet the close time. 10. Check out your item. Confirm the checkout is due when the library closes. Return the item. 11. Back in your other tab, set ConsiderLibraryHoursInCirculation to 'open', so the due date should be extended to meet the opening time. 12. Check out your item. Confirm the checkout is due the next day when the library opens. 13. Confirm tests pass t/db_dependent/Circulation/CalcDateDue.t Sponsored-by: Catalyst IT Signed-off-by: Sam Lau <samalau(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 6796] Overnight checkouts taking into account opening and closing hours
by bugzilla-daemon＠bugs.koha-community.org 08 Apr '24

08 Apr '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6796 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162091|0 |1 is obsolete| | --- Comment #126 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 164512 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164512&action=e… Bug 6796: ConsiderLibraryHoursInCirculation system preference -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 6796] Overnight checkouts taking into account opening and closing hours
by bugzilla-daemon＠bugs.koha-community.org 08 Apr '24

08 Apr '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6796 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162090|0 |1 is obsolete| | --- Comment #125 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 164511 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164511&action=e… Bug 6796: Add library_hours table and set opening hours for library -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9762] Log circulation overrides
by bugzilla-daemon＠bugs.koha-community.org 08 Apr '24

08 Apr '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9762 --- Comment #26 from Matthias Le Gac <matthias.le-gac(a)inlibro.com> --- Rebase to master -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0

[Bug 9762] Log circulation overrides
by bugzilla-daemon＠bugs.koha-community.org 08 Apr '24

08 Apr '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9762 Matthias Le Gac <matthias.le-gac(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #164426|0 |1 is obsolete| | --- Comment #25 from Matthias Le Gac <matthias.le-gac(a)inlibro.com> --- Created attachment 164510 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164510&action=e… Bug 9762: Test CanBookBeIssued.pm To test: 1) Apply the patch 2) run prove t/db_dependent/Circulation/CanBookBeIssued.t --After each step, a message will be displayed in the action_logs table and in Tools > Log viewer -- Circulation -- Checking out 1) Check out an item that is age-restricted (AgeRestrictionOverride syspref) 2) Check out an item that has a “not for loan” status (AllowNotForLoanOverride syspref) 3) Check out an item that has a “lost” status (IssueLostItem syspref) 4) Check out an item to a patron who has reached the checkout limit (AllowTooManyOverride syspref) 5) Check out an item to a patron who is not allowed to borrow this item type 6) Check out an item to a patron who has unpaid fines (AllFinesNeedOverride and/or AllowFineOverride + noissuescharge sysprefs) 7) Check out an item on hold for someone else 8) Check out an item on hold ready for pickup by someone else 9) Check out an item already checked out to someone else (AutoReturnCheckedOutItems syspref) 10) Check out to a patron who has restrictions Circulation -- Checking in 11) Ignore a hold upon check in 12) Ignore a hold and transfer upon check in Circulation – Renewing 13) Renew an item on hold for someone else (AllowRenewalOnHoldOverride syspref) 14) Renew an item that has reached the maximum number of renewals (AllowRenewalLimitOverride syspref) Holds 15) Place a hold for a patron who is not allowed to place this item type on hold (AllowHoldPolicyOverride syspref) 16) Place a hold for a patron who has reached the maximum number of holds 17) Place an item-level hold when rules dictate that this is not allowed (In circulation rules put "On shelf holds allowed" to "If any unavailable") -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0

[Bug 9762] Log circulation overrides
by bugzilla-daemon＠bugs.koha-community.org 08 Apr '24

08 Apr '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9762 Matthias Le Gac <matthias.le-gac(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #164387|0 |1 is obsolete| | --- Comment #24 from Matthias Le Gac <matthias.le-gac(a)inlibro.com> --- Created attachment 164509 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164509&action=e… Bug 9762: Change how to pass the param -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0