- Koha-bugs - lists.koha-community.org

[Bug 10190] Overdue notice triggers based on item type
by bugzilla-daemon＠bugs.koha-community.org 04 Sep '26

04 Sep '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190 --- Comment #911 from Chloé Zermatten <chloe.zermatten(a)openfifth.co.uk> --- Created attachment 205021 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205021&action=e… Bug 10190: fix four more issues spotted in the overdues script - Patron.pm has_restricting_overdues: sort ASC not DESC so the oldest (most overdue) item is checked per branch/itemtype; DESC caused the deduplication skip to discard the very items most likely to trigger a restriction - overdue_notices.pl: fix --itemtypesout option name in GetOptions (was 'itemtypeouts', never matched the documented --itemtypesout flag) - overdue_notices.pl: fix typo 'catagorycode' -> 'categorycode' in --borcatout search, which silently broke category exclusion - circulation_triggers.pl: add flagsrequired => parameters/manage_circ_rules so the admin page enforces the correct permission; also add missing use Koha::Notice::Templates Signed-off-by: Michaela <michaela.sieber(a)kit.edu> Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10190] Overdue notice triggers based on item type
by bugzilla-daemon＠bugs.koha-community.org 04 Sep '26

04 Sep '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190 --- Comment #910 from Chloé Zermatten <chloe.zermatten(a)openfifth.co.uk> --- Created attachment 205020 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205020&action=e… Bug 10190: fix three regressions in overdue_notices.pl - Store patron name/address fields in \$borrower_overdues so prepare_letter_for_printing has data for printed/CSV/text notices - Fix email->print fallback: look up items under original MTT key, not the effective (fallback) key - Set \$admin_email_address from \$library unconditionally in _enact_trigger; previously undef in non-patron_homelibrary mode, stripping the from_address on all queued notices Signed-off-by: Michaela <michaela.sieber(a)kit.edu> Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10190] Overdue notice triggers based on item type
by bugzilla-daemon＠bugs.koha-community.org 04 Sep '26

04 Sep '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190 --- Comment #909 from Chloé Zermatten <chloe.zermatten(a)openfifth.co.uk> --- Created attachment 205019 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205019&action=e… Bug 10190: rewrite atomicupdate with correct 1:1 rule migration The previous migration had two fundamental errors: 1. It manufactured phantom empty rows for all patron categories that had no rule, which corrupted the "most frequent" calculation. 2. It created categorycode=NULL (all-categories) default rules for every branchcode seen, silently extending overdue notice coverage to patron categories that had no configured rule in the old system. The backend (overdue_notices.pl) does not consult has_rules, so these invented defaults would cause notices to be sent to patrons that were deliberately uncovered. The rewrite migrates only explicit (branchcode, categorycode) pairs that had a positive delay configured. No default rules are created. branchcode='' maps to NULL as before. exit is replaced with return to avoid killing subsequent atomicupdate scripts. Signed-off-by: Michaela <michaela.sieber(a)kit.edu> Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10190] Overdue notice triggers based on item type
by bugzilla-daemon＠bugs.koha-community.org 04 Sep '26

04 Sep '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190 --- Comment #908 from Chloé Zermatten <chloe.zermatten(a)openfifth.co.uk> --- Created attachment 205018 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205018&action=e… Bug 10190: Deprecate permission user_permissions rows do not need manual cleanup because the FK on user_permissions(module_bit, code) references permissions(module_bit, code) ON DELETE CASCADE, so deleting from permissions automatically removes per-patron rows. Signed-off-by: Michaela <michaela.sieber(a)kit.edu> Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10190] Overdue notice triggers based on item type
by bugzilla-daemon＠bugs.koha-community.org 04 Sep '26

04 Sep '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190 --- Comment #907 from Chloé Zermatten <chloe.zermatten(a)openfifth.co.uk> --- Created attachment 205017 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205017&action=e… Bug 10190: prevent duplicate ruleset load - prevent the initial API call and subsequent exhaustive applied ruleset list generation logic from running twice Signed-off-by: Michaela <michaela.sieber(a)kit.edu> Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10190] Overdue notice triggers based on item type
by bugzilla-daemon＠bugs.koha-community.org 04 Sep '26

04 Sep '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190 --- Comment #906 from Chloé Zermatten <chloe.zermatten(a)openfifth.co.uk> --- Created attachment 205016 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205016&action=e… Bug 10190: (QA follow-up) swap undef for all in update db output Signed-off-by: Michaela <michaela.sieber(a)kit.edu> Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10190] Overdue notice triggers based on item type
by bugzilla-daemon＠bugs.koha-community.org 04 Sep '26

04 Sep '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190 --- Comment #905 from Chloé Zermatten <chloe.zermatten(a)openfifth.co.uk> --- Created attachment 205015 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205015&action=e… Bug 10190: trigger add/edit form UI/UX enhancements - scroll to the add/edit form on button click - prevent redundant full page reload upon the user swapping between adding and editing while the modal is open - ensure robust scroll behaviour, handling: - the URL being accessed directly - the edit button in the table in the main page being used to access the form directly - the stepper workflow being used - the user swapping between add and edit once already looking at the form - dynamic display of 'Transport Type' consistency: only show if a 'Notice' has been selected - if a notice has been selected, prevent form submission if transport type isn't set and display an alert on submission attempt Signed-off-by: Michaela <michaela.sieber(a)kit.edu> Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10190] Overdue notice triggers based on item type
by bugzilla-daemon＠bugs.koha-community.org 04 Sep '26

04 Sep '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190 --- Comment #904 from Chloé Zermatten <chloe.zermatten(a)openfifth.co.uk> --- Created attachment 205014 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205014&action=e… Bug 10190: (QA follow-up) add missing filter Signed-off-by: Michaela <michaela.sieber(a)kit.edu> Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10190] Overdue notice triggers based on item type
by bugzilla-daemon＠bugs.koha-community.org 04 Sep '26

04 Sep '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190 --- Comment #903 from Chloé Zermatten <chloe.zermatten(a)openfifth.co.uk> --- Created attachment 205013 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205013&action=e… Bug 10190: enhance trigger context display in modal - improve modal scroll behaviour - improve modal dimensions - display contexts as a horizontal list to make better use of the available space - fully contain dropdowns within the modal body Signed-off-by: Michaela <michaela.sieber(a)kit.edu> Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10190] Overdue notice triggers based on item type
by bugzilla-daemon＠bugs.koha-community.org 04 Sep '26

04 Sep '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190 --- Comment #902 from Chloé Zermatten <chloe.zermatten(a)openfifth.co.uk> --- Created attachment 205012 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205012&action=e… Bug 10190: (QA follow-up) typo Signed-off-by: Michaela <michaela.sieber(a)kit.edu> Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0