- Koha-bugs - lists.koha-community.org

[Bug 15278] [Omnibus] Port default slips and notices from bespoke syntax to Template Toolkit
by bugzilla-daemon＠bugs.koha-community.org 21 Mar '24

21 Mar '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15278 --- Comment #23 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- It's not just the custom --- handling if digests that need thought.. there is also a customer loop syntax in our <<>> style I believe.. that and the special handling for attributes code conversion stuff that I'm already also working on. As for the --- digest thing, I feel like the logic for that one is backwards and strange.. we should be generating the notice all in one hit at a later point in time rather than queuing a notice and then munging extra stuff into it after the fact at various times. Food for thought. Happy to grab a call some time to discuss the things I've been contemplating around this area for some time now if it helps -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 28108] New: LetterLog/Acquistions/Claims: Logging filters are broken
by bugzilla-daemon＠bugs.koha-community.org 21 Mar '24

21 Mar '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28108 Bug ID: 28108 Summary: LetterLog/Acquistions/Claims: Logging filters are broken Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs(a)lists.koha-community.org Reporter: martin.renvoize(a)ptfs-europe.com QA Contact: testopia(a)bugs.koha-community.org We stripped out the fix for claims/acquisitions/letter logging filtering from bug 14233. I'll attach a copy of the code here for prosperity. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 31

[Bug 36389] New: Acquisition order logging does not depend on AcquisitionLog system preference
by bugzilla-daemon＠bugs.koha-community.org 21 Mar '24

21 Mar '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36389 Bug ID: 36389 Summary: Acquisition order logging does not depend on AcquisitionLog system preference Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Tools Assignee: koha-bugs(a)lists.koha-community.org Reporter: fridolin.somers(a)biblibre.com QA Contact: testopia(a)bugs.koha-community.org Since Bug 28108 logging acquisition order is in module 'ACQUISITIONS'. So logging must depend on AcquisitionLog system preference. Currently it depends on ClaimsLog system preference. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 2

[Bug 15278] [Omnibus] Port default slips and notices from bespoke syntax to Template Toolkit
by bugzilla-daemon＠bugs.koha-community.org 21 Mar '24

21 Mar '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15278 --- Comment #22 from Emily Lamancusa <emily.lamancusa(a)montgomerycountymd.gov> --- Hmmm, I hadn't actually thought about replacing the digest syntax... [% FOREACH %] doesn't work for digest-building, because the ---- marker doesn't represent a piece of logic or substitution internal to one notice, but rather it's metadata that tells the code how to parse and store the prepared message so that a new message can be combined properly with an old message after the fact, without duplicating the parts that should be the same: > sub _metadata { > my ($letter) = @_; > if ($letter->{content} =~ /----/) { > my ($header, $body, $footer) = split(/----\r?\n?/, $letter->{content}); > return { > header => $header, > body => [$body], > footer => $footer, > }; > } else { > return { > header => '', > body => [$letter->{content}], > footer => '', > }; > } > } Is that something we can (usefully) replace with Template Toolkit? (this may also be a "next step" question, to avoid making the perfect the enemy of the good) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 36387] New: debian/scripts: daemon --user should contain colon instead of period
by bugzilla-daemon＠bugs.koha-community.org 21 Mar '24

21 Mar '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36387 Bug ID: 36387 Summary: debian/scripts: daemon --user should contain colon instead of period Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: m.de.rooy(a)rijksmuseum.nl QA Contact: testopia(a)bugs.koha-community.org Documentation says: -u, --user=user[:group] - Run the client as user[:group] Koha uses a period. So thats formally incorrect (but seems to work). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 2

[Bug 6834] $template->{param_map} is deprecated with the introduction of Template::Toolkit
by bugzilla-daemon＠bugs.koha-community.org 21 Mar '24

21 Mar '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6834 Laura Escamilla <Laura.escamilla(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163619|0 |1 is obsolete| | --- Comment #9 from Laura Escamilla <Laura.escamilla(a)bywatersolutions.com> --- Created attachment 163620 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163620&action=e… Bug 6834 : Removing last of the $template->{param_map} Signed-off-by: Ian Walls <ian.walls(a)bywatersolutions.com> Signed-off-by: Chris Cormack <chrisc(a)catalyst.net.nz> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 6834] $template->{param_map} is deprecated with the introduction of Template::Toolkit
by bugzilla-daemon＠bugs.koha-community.org 21 Mar '24

21 Mar '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6834 Laura Escamilla <Laura.escamilla(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5270|0 |1 is obsolete| | --- Comment #8 from Laura Escamilla <Laura.escamilla(a)bywatersolutions.com> --- Created attachment 163619 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163619&action=e… Bug 6834 : Removing last of the $template->{param_map} Signed-off-by: Ian Walls <ian.walls(a)bywatersolutions.com> Signed-off-by: Chris Cormack <chrisc(a)catalyst.net.nz> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 23969] New: Add library to public lists
by bugzilla-daemon＠bugs.koha-community.org 21 Mar '24

21 Mar '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23969 Bug ID: 23969 Summary: Add library to public lists Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Lists Assignee: koha-bugs(a)lists.koha-community.org Reporter: baselibrary.consortium(a)nhs.net QA Contact: testopia(a)bugs.koha-community.org CC: m.de.rooy(a)rijksmuseum.nl We would like to add a column and sort by library name, or separate tabs for each library on the public lists on the OPAC. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 5

[Bug 34478] Full CSRF protection
by bugzilla-daemon＠bugs.koha-community.org 21 Mar '24

21 Mar '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34478 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |36384 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36384 [Bug 36384] 'Used saved' typo in guided reports -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 36355] New: Auth/csrf.ts is failing if many libraries in the DB
by bugzilla-daemon＠bugs.koha-community.org 21 Mar '24

21 Mar '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36355 Bug ID: 36355 Summary: Auth/csrf.ts is failing if many libraries in the DB Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Test Suite Assignee: chris(a)bigballofwax.co.nz Reporter: jonathan.druart(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org The test is selecting "All" in the length dropdown list of DT, but the query takes more than the timeout delay (10sec) and we never see the "Delete" button. We could fix this failure but actually it is catching another problem: we should not have that many libraries in the DB. Koha_Master/2813 koha_1 | Running: Auth/csrf.ts (3 of 15) koha_1 | <?xml version="1.0" encoding="UTF-8"?> koha_1 | <testsuites name="Mocha Tests" time="41.862" tests="6" failures="2"> koha_1 | <testsuite name="Root Suite" timestamp="2024-03-18T11:18:40" tests="0" file="t/cypress/integration/Auth/csrf.ts" time="0.000" failures="0"> koha_1 | </testsuite> koha_1 | <testsuite name="CSRF" timestamp="2024-03-18T11:18:40" tests="6" time="41.845" failures="2"> koha_1 | <testcase name="CSRF Add using POST without csrf" time="3.693" classname="Add using POST without csrf"> koha_1 | </testcase> koha_1 | <testcase name="CSRF Add using POST with invalid csrf" time="3.749" classname="Add using POST with invalid csrf"> koha_1 | </testcase> koha_1 | <testcase name="CSRF Add using GET" time="1.737" classname="Add using GET"> koha_1 | </testcase> koha_1 | <testcase name="CSRF Add" time="5.895" classname="Add"> koha_1 | </testcase> koha_1 | <testcase name="CSRF Delete without CSRF" time="0.000" classname="Delete without CSRF"> koha_1 | <failure message="Timed out retrying after 10050ms: `cy.click()` failed because the center of this element is hidden from view: koha_1 | koha_1 | `<button type="submit" id="delete_library_TEST_LIB" class="btn btn-default btn-xs" role="button">...</button>` koha_1 | koha_1 | Fix this problem, or use `{force: true}` to disable error checking. koha_1 | koha_1 | https://on.cypress.io/element-cannot-be-interacted-with" type="CypressError"><![CDATA[CypressError: Timed out retrying after 10050ms: `cy.click()` failed because the center of this element is hidden from view: koha_1 | koha_1 | `<button type="submit" id="delete_library_TEST_LIB" class="btn btn-default btn-xs" role="button">...</button>` koha_1 | koha_1 | Fix this problem, or use `{force: true}` to disable error checking. -- You are receiving this mail because: You are watching all bug changes.

1 17