- Koha-bugs - lists.koha-community.org

[Bug 15516] Allow to place a hold on first available item from a group of titles
by bugzilla-daemon＠bugs.koha-community.org 12 Mar '24

12 Mar '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 David Cook <dcook(a)prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Failed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15516] Allow to place a hold on first available item from a group of titles
by bugzilla-daemon＠bugs.koha-community.org 12 Mar '24

12 Mar '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #470 from David Cook <dcook(a)prosentient.com.au> --- Comment on attachment 162078 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162078 Bug 15516: Relevant controller changes and tests Review of attachment 162078: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=155…) ----------------------------------------------------------------- ::: Koha/Holds.pm @@ +213,5 @@ > + > +sub count_holds { > + my ( $self, $search_params ) = @_; > + > + $search_params = { These $search_params lines redefine the variable instead of updating the variable. This means that you end up selecting all holds and not just the holds for particular criteria (like an individual patron). -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15516] Allow to place a hold on first available item from a group of titles
by bugzilla-daemon＠bugs.koha-community.org 12 Mar '24

12 Mar '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #469 from David Cook <dcook(a)prosentient.com.au> --- Found a nasty bug in Koha::Holds->count_holds(). I'm going to need to review this code in-depth again... -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 34478] Full CSRF protection
by bugzilla-daemon＠bugs.koha-community.org 12 Mar '24

12 Mar '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34478 --- Comment #185 from David Cook <dcook(a)prosentient.com.au> --- (In reply to David Cook from comment #184) > (In reply to David Cook from comment #183) > > However, I have been thinking a bit about how to provide some protection to > > stable branches. > > I think my abbreviated anti-CSRF plus bug 33259 (when it's ready) would be > an OK compromise for stable branches. Although as I say that I'm finding more changes that need to be backported to really support this... heh... -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 34478] Full CSRF protection
by bugzilla-daemon＠bugs.koha-community.org 12 Mar '24

12 Mar '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34478 --- Comment #184 from David Cook <dcook(a)prosentient.com.au> --- (In reply to David Cook from comment #183) > However, I have been thinking a bit about how to provide some protection to > stable branches. I think my abbreviated anti-CSRF plus bug 33259 (when it's ready) would be an OK compromise for stable branches. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 34478] Full CSRF protection
by bugzilla-daemon＠bugs.koha-community.org 12 Mar '24

12 Mar '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34478 --- Comment #183 from David Cook <dcook(a)prosentient.com.au> --- (In reply to Fridolin Somers from comment #182) > Not for backport I bet ? I don't think that it would be possible to backport this one. However, I have been thinking a bit about how to provide some protection to stable branches. Locally, I've applied the following: - Bug 36098 (the Koha::Session patches) - Bug 34755: Backport Koha::Token change from bug 34478 - Bug 34478: Add csrf-token in meta I've created a middleware based off Koha::Middleware::CSRF and then using a mix of ideas from Marcel and myself, I've used Javascript to inject CSRF tokens into forms and Koha API calls. At the moment, I'm testing this on the OPAC, and then I'm going to look at the Staff Interface. I want to do some more thinking about how we can use "Strict" in the SameSite attribute for the CGISESSID cookie to cover off CSRF for GET requests as well. Less of a problem for 34478 because it fixes a lot of stateful GET requests, but for older versions... -- Long story short... it might be worth backporting just "Bug 34478: Add csrf-token in meta" for now. Maybe a new bug report for that? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13706] Deduping authorities script (dedup_authorities.pl)
by bugzilla-daemon＠bugs.koha-community.org 11 Mar '24

11 Mar '24

1 0

[Bug 35955] New CSRF token generated everytime we need one
by bugzilla-daemon＠bugs.koha-community.org 11 Mar '24

11 Mar '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35955 --- Comment #13 from David Cook <dcook(a)prosentient.com.au> --- (In reply to Fridolin Somers from comment #12) > May we backport this for better performance ? I can't imagine that it would hurt. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 23335] New: "There are no items that can be placed on hold."
by bugzilla-daemon＠bugs.koha-community.org 11 Mar '24

11 Mar '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23335 Bug ID: 23335 Summary: "There are no items that can be placed on hold." Change sponsored?: --- Product: Koha Version: 18.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard(a)myacpl.org Reporter: jmmureithi(a)nationalbank.co.ke QA Contact: testopia(a)bugs.koha-community.org Created attachment 91571 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91571&action=ed… THE MESSAGE APPEARING IN OPAC The clients/users are trying to place hold and the following message is displayed yet there are items: There are no items that can be placed on hold. -- You are receiving this mail because: You are watching all bug changes.

1 2

[Bug 32636] New: More info with batch patron deletion
by bugzilla-daemon＠bugs.koha-community.org 11 Mar '24

11 Mar '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32636 Bug ID: 32636 Summary: More info with batch patron deletion Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs(a)lists.koha-community.org Reporter: cbrannon(a)cdalibrary.org QA Contact: testopia(a)bugs.koha-community.org When batch deleting patrons, it tells you how many patrons will be deleted. It would be great if it also told you how many patrons fit your parameters, but are being skipped because they have active loans or fees. Better yet, if that piece of information could link to a report showing which patrons are skipped and why, that would even be helpful. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 1