- Koha-bugs - lists.koha-community.org

[Bug 2486] Show user comments in staff interface
by bugzilla-daemon＠bugs.koha-community.org 13 Jun '24

13 Jun '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2486 Lucas Gass <lucas(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas(a)bywatersolutions.com --- Comment #9 from Lucas Gass <lucas(a)bywatersolutions.com> --- Nice to see a 4 digit bug from 2010 move along, thanks Owen! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 2486] Show user comments in staff interface
by bugzilla-daemon＠bugs.koha-community.org 13 Jun '24

13 Jun '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2486 Lucas Gass <lucas(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167674|0 |1 is obsolete| | --- Comment #8 from Lucas Gass <lucas(a)bywatersolutions.com> --- Created attachment 167703 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167703&action=e… Bug 2486: Show user comments in staff interface This patch the staff interface's bibliographic detail page, adding a tab that shows comments submitted by users from the OPAC. To test, apply the patch and restart services. - If necessary, enable the "OPACComments" system preference and submit some comments in the OPAC. - In the staff interface, locate the title you submitted comments on. - The bibliographic detail page should show a "Comments" tab with a count of the number of all comments (approved and unapproved). Sponsored-By: Athens County Public Libraries Signed-off-by: Lucas Gass <lucas(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 2486] Show user comments in staff interface
by bugzilla-daemon＠bugs.koha-community.org 13 Jun '24

13 Jun '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2486 Lucas Gass <lucas(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7782] Replace yes/no for cancelling holds with checkboxes and add delete link in patron account
by bugzilla-daemon＠bugs.koha-community.org 13 Jun '24

13 Jun '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7782 Lucas Gass <lucas(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167696|0 |1 is obsolete| | --- Comment #7 from Lucas Gass <lucas(a)bywatersolutions.com> --- Created attachment 167697 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167697&action=e… Bug 7782: Replace yes/no dropdown with checkboxes for cancelling holds This patch replaces the yes/no options for selecting which holds to cancel with checkboxes. Furthermore, a select all/none link was added to the column header for even easier selection. To test: 1) Request multiple holds (at least 3) on different bibs for the same patron. 2) Visit the patrons detail page. 3) Click on the holds table tab. 4) Notice in the "Delete?" column there is a "Yes/No" dropdown option for each hold. 5) Apply patch, restart_all 6) Notice now that there is a "Cancel?" column that has "select all | none" links along with a checkbox for each hold. 7) Click the select all link ensure it works as expect. Do the same for the select none link 8) Select one hold, then press the cancel marked holds button at the bottom. Open the table again and notice the hold was removed for the table. 9) Now press the 'select all' link and press cancel marked holds. Notice that the remaining holds are removed from the table. 10) Ensure that these holds were also correctly removed from the holds tab on that particular items page. Signed-off-by: Lucas Gass <lucas(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7782] Replace yes/no for cancelling holds with checkboxes and add delete link in patron account
by bugzilla-daemon＠bugs.koha-community.org 13 Jun '24

13 Jun '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7782 Lucas Gass <lucas(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7782] Replace yes/no for cancelling holds with checkboxes and add delete link in patron account
by bugzilla-daemon＠bugs.koha-community.org 13 Jun '24

13 Jun '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7782 --- Comment #6 from Sam Lau <samalau(a)gmail.com> --- Also wanted to mention that in Bug 19371, the 'Delete?' column was renamed to the 'Cancel?' column. This change was lost somewhere (Bug 33528 from my investigation). To me, it makes sense to have it say 'Cancel?' as the button you press to remove the holds says 'Cancel Marked Holds'. So, in this patch, I just changed it back to saying "Cancel?". If anyone disagrees with this change lmk and I will revert it back. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7782] Replace yes/no for cancelling holds with checkboxes and add delete link in patron account
by bugzilla-daemon＠bugs.koha-community.org 13 Jun '24

13 Jun '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7782 --- Comment #5 from Sam Lau <samalau(a)gmail.com> --- Created attachment 167696 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167696&action=e… Bug 7782: Replace yes/no dropdown with checkboxes for cancelling holds This patch replaces the yes/no options for selecting which holds to cancel with checkboxes. Furthermore, a select all/none link was added to the column header for even easier selection. To test: 1) Request multiple holds (at least 3) on different bibs for the same patron. 2) Visit the patrons detail page. 3) Click on the holds table tab. 4) Notice in the "Delete?" column there is a "Yes/No" dropdown option for each hold. 5) Apply patch, restart_all 6) Notice now that there is a "Cancel?" column that has "select all | none" links along with a checkbox for each hold. 7) Click the select all link ensure it works as expect. Do the same for the select none link 8) Select one hold, then press the cancel marked holds button at the bottom. Open the table again and notice the hold was removed for the table. 9) Now press the 'select all' link and press cancel marked holds. Notice that the remaining holds are removed from the table. 10) Ensure that these holds were also correctly removed from the holds tab on that particular items page. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7782] Replace yes/no for cancelling holds with checkboxes and add delete link in patron account
by bugzilla-daemon＠bugs.koha-community.org 13 Jun '24

13 Jun '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7782 Sam Lau <samalau(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7782] Replace yes/no for cancelling holds with checkboxes and add delete link in patron account
by bugzilla-daemon＠bugs.koha-community.org 13 Jun '24

13 Jun '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7782 Sam Lau <samalau(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |samalau(a)gmail.com Assignee|oleonard(a)myacpl.org |samalau(a)gmail.com -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 37064] New: Spurious CSRF error logged by 500.pl when a POST request fails
by bugzilla-daemon＠bugs.koha-community.org 13 Jun '24

13 Jun '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37064 Bug ID: 37064 Summary: Spurious CSRF error logged by 500.pl when a POST request fails Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org I haven't been able to set things up to recreate on KTD, but in production: 1 - Set an email for a patron and enable HOLD notifications 2 - Edit the HOLD letter to use a spurious item field [% item.itemcopynumber %] 3 - Place a hold for patron and confirm 4 - Error in logs ERROR PROCESSING TEMPLATE: undef error - The method Koha::Item->itemcopynumber is not covered by tests! 5 - But also: [WARN] Programming error - op 'cud-affect_reserve' must not start with 'cud-' for GET https://staff-library.provider.com/intraneterrors/500.pl (referer: https://staff-library.provider.com/cgi-bin/koha/circ/returns.pl) at /usr/share/koha/lib/Koha/Middleware/CSRF.pm line 82. 6 - The ErrorDocument middleware automatically transforms every request into a GET - so suddenly the cud- op is rejected -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 5